From: Guenter Roeck <linux@roeck-us.net>
To: Claudiu <claudiu.beznea@tuxon.dev>,
wim@linux-watchdog.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
geert+renesas@glider.be, magnus.damm@gmail.com,
mturquette@baylibre.com, sboyd@kernel.org,
p.zabel@pengutronix.de, biju.das.jz@bp.renesas.com
Cc: linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-clk@vger.kernel.org,
Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Subject: Re: [PATCH 03/10] watchdog: rzg2l_wdt: Check return status of pm_runtime_put()
Date: Mon, 22 Jan 2024 09:31:59 -0800 [thread overview]
Message-ID: <c857cdd4-459b-41ae-b4bb-0da45e461335@roeck-us.net> (raw)
In-Reply-To: <20240122111115.2861835-4-claudiu.beznea.uj@bp.renesas.com>
On 1/22/24 03:11, Claudiu wrote:
> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
>
> pm_runtime_put() may return an error code. Check its return status.
>
> Fixes: 2cbc5cd0b55f ("watchdog: Add Watchdog Timer driver for RZ/G2L")
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
> ---
> drivers/watchdog/rzg2l_wdt.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/rzg2l_wdt.c b/drivers/watchdog/rzg2l_wdt.c
> index 4ab9e7c5e771..0554965027cd 100644
> --- a/drivers/watchdog/rzg2l_wdt.c
> +++ b/drivers/watchdog/rzg2l_wdt.c
> @@ -144,9 +144,13 @@ static int rzg2l_wdt_start(struct watchdog_device *wdev)
> static int rzg2l_wdt_stop(struct watchdog_device *wdev)
> {
> struct rzg2l_wdt_priv *priv = watchdog_get_drvdata(wdev);
> + int ret;
>
> rzg2l_wdt_reset(priv);
> - pm_runtime_put(wdev->parent);
> +
> + ret = pm_runtime_put(wdev->parent);
> + if (ret < 0)
> + return ret;
>
> return 0;
> }
A simple
return pm_runtime_put();
might do.
However, one question: Given that pm_runtime_put() returns -ENOSYS if
CONFIG_PM is disabled, that means the driver will depend on CONFIG_PM=y.
Assuming this is intentional, would it make sense to explicitly declare
that dependency in Kconfig ? It doesn't seem to make any sense to build
the driver if it won't work anyway.
Thanks,
Guenter
next prev parent reply other threads:[~2024-01-22 17:32 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 11:11 [PATCH 00/10] watchdog: rzg2l_wdt: Add support for RZ/G3S Claudiu
2024-01-22 11:11 ` [PATCH 01/10] clk: renesas: r9a08g045: Add clock and reset support for watchdog Claudiu
2024-01-30 16:38 ` Geert Uytterhoeven
2024-01-22 11:11 ` [PATCH 02/10] watchdog: rzg2l_wdt: Use pm_runtime_resume_and_get() Claudiu
2024-01-30 16:43 ` Geert Uytterhoeven
2024-01-22 11:11 ` [PATCH 03/10] watchdog: rzg2l_wdt: Check return status of pm_runtime_put() Claudiu
2024-01-22 17:31 ` Guenter Roeck [this message]
2024-01-23 7:02 ` claudiu beznea
2024-01-23 10:00 ` Guenter Roeck
2024-01-22 11:11 ` [PATCH 04/10] watchdog: rzg2l_wdt: Remove reset de-assert on probe/stop Claudiu
2024-01-22 11:11 ` [PATCH 05/10] watchdog: rzg2l_wdt: Remove comparison with zero Claudiu
2024-01-22 11:11 ` [PATCH 06/10] watchdog: rzg2l_wdt: Rely on the reset driver for doing proper reset Claudiu
2024-01-22 11:11 ` [PATCH 07/10] watchdog: rzg2l_wdt: Add suspend/resume support Claudiu
2024-01-22 17:39 ` Guenter Roeck
2024-01-22 21:05 ` Jerry Hoemann
2024-01-22 22:00 ` Guenter Roeck
2024-01-23 7:13 ` claudiu beznea
2024-01-23 10:09 ` Guenter Roeck
2024-01-23 11:40 ` claudiu beznea
2024-01-22 11:11 ` [PATCH 08/10] dt-bindings: watchdog: renesas,wdt: Document RZ/G3S support Claudiu
2024-01-22 17:12 ` Conor Dooley
2024-01-30 16:48 ` Geert Uytterhoeven
2024-01-22 11:11 ` [PATCH 09/10] arm64: dts: renesas: r9a08g045: Add watchdog node Claudiu
2024-01-30 16:51 ` Geert Uytterhoeven
2024-01-22 11:11 ` [PATCH 10/10] arm64: dts: renesas: rzg3s-smarc-som: Enable the watchdog interface Claudiu
2024-01-30 16:51 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c857cdd4-459b-41ae-b4bb-0da45e461335@roeck-us.net \
--to=linux@roeck-us.net \
--cc=biju.das.jz@bp.renesas.com \
--cc=claudiu.beznea.uj@bp.renesas.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).