From: "Mark Pearson" <mpearson-lenovo@squebb.ca>
To: "Guenter Roeck" <linux@roeck-us.net>
Cc: wim@linux-watchdog.org, linux-watchdog@vger.kernel.org,
linux-kernel@vger.kernel.org, "David Ober" <dober@lenovo.com>
Subject: Re: [PATCH] watchdog: lenovo_se10_wdt: Watchdog driver for Lenovo SE10 platform
Date: Fri, 15 Mar 2024 17:12:51 -0400 [thread overview]
Message-ID: <d8529238-8e3e-4d70-a1d4-40dc134f3d97@app.fastmail.com> (raw)
In-Reply-To: <75b89923-f78b-4661-bc6a-fee6c15367da@roeck-us.net>
On Fri, Mar 15, 2024, at 4:05 PM, Guenter Roeck wrote:
> On 3/15/24 12:52, Mark Pearson wrote:
>> Watchdog driver implementation for Lenovo SE10 platform.
>>
>> Signed-off-by: Mark Pearson <mpearson-lenovo@squebb.ca>
>> Signed-off-by: David Ober <dober@lenovo.com>
>
> I don't like the "Found Lenovo SE10" noise in the probe function,
> but that isn't worth arguing about.
>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>
If I get any other feedback, and need to do a v2, I will remove that.
Many thanks for the review.
Mark
prev parent reply other threads:[~2024-03-15 21:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-15 19:52 [PATCH] watchdog: lenovo_se10_wdt: Watchdog driver for Lenovo SE10 platform Mark Pearson
2024-03-15 20:05 ` Guenter Roeck
2024-03-15 21:12 ` Mark Pearson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8529238-8e3e-4d70-a1d4-40dc134f3d97@app.fastmail.com \
--to=mpearson-lenovo@squebb.ca \
--cc=dober@lenovo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).