From: Judith Mendez <jm@ti.com>
To: Francesco Dolcini <francesco@dolcini.it>
Cc: Guenter Roeck <linux@roeck-us.net>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
<linux-watchdog@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] watchdog: rti_wdt: Set min_hw_heartbeat_ms to accommodate 5% safety margin
Date: Tue, 9 Apr 2024 16:44:25 -0500 [thread overview]
Message-ID: <e1d1aad3-0635-45e1-9470-6398a04820d0@ti.com> (raw)
In-Reply-To: <ZhWchn3qr_7Ocggm@gaggiata.pivistrello.it>
Hi Francesco,
On 4/9/24 2:52 PM, Francesco Dolcini wrote:
> On Tue, Apr 09, 2024 at 02:37:15PM -0500, Judith Mendez wrote:
>> Hi all,
>>
>> On 4/6/24 8:01 AM, Guenter Roeck wrote:
>>> On Thu, Apr 04, 2024 at 10:33:19AM -0500, Judith Mendez wrote:
>>>> On AM62x, the watchdog is pet before the valid window
>>>> is open. Fix min_hw_heartbeat and accommodate a 5% safety
>>>> margin with the exception of open window size < 10%,
>>>> which shall use <5% due to the smaller open window size.
>>
>> Please do not merge this patch, I will add an additional
>> patch removing the hack in this driver.
>
> Is the patch buggy, or you are just talking about an additional clean-up?
> If it is an additional patch and this code is fine, why holding it back?
1. If we leave the hack, the hack shifts the valid window. This
is not desirable behavior. It is better to add a safety margin
that works in all possible scenarios.
2. 5% safety margin works in almost all cases except when the
timeout is < 5s. This due to a requirement of a min of 0.25s for the
safety margin due max possible error. At < 5s timeout, 5% is not
enough.
I am not 100% sure if using < 5s timeout is a real use-case
but I would rather use a safety margin that works for all cases.
~ Judith
prev parent reply other threads:[~2024-04-09 21:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-04 15:33 [PATCH v2] watchdog: rti_wdt: Set min_hw_heartbeat_ms to accommodate 5% safety margin Judith Mendez
2024-04-05 13:11 ` Rafael Beims
2024-04-06 13:01 ` Guenter Roeck
2024-04-09 19:37 ` Judith Mendez
2024-04-09 19:52 ` Francesco Dolcini
2024-04-09 21:44 ` Judith Mendez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1d1aad3-0635-45e1-9470-6398a04820d0@ti.com \
--to=jm@ti.com \
--cc=francesco@dolcini.it \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).