From: Guenter Roeck <linux@roeck-us.net>
To: Nik Bune <n2h9z4@gmail.com>
Cc: wim@linux-watchdog.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
skhan@linuxfoundation.org, baruch@tkos.co.il,
linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] dt-bindings: watchdog: cnxt,cx92755-wdt: convert txt to yaml
Date: Tue, 24 Oct 2023 11:05:37 -0700 [thread overview]
Message-ID: <f55d2749-f311-4d8f-a394-3591d18fc523@roeck-us.net> (raw)
In-Reply-To: <20231023202622.18558-1-n2h9z4@gmail.com>
On Mon, Oct 23, 2023 at 10:26:22PM +0200, Nik Bune wrote:
> Convert txt file to yaml.
> Add maintainers list.
>
> Signed-off-by: Nik Bune <n2h9z4@gmail.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
>
> Changes in v2 (according to review comments):
> - Updated clocks property to have only maxItems without $ref and description.
> - Removed timeout-sec explicit definition, as it is defined in watchdog.yaml.
>
> v1 patch: https://lore.kernel.org/all/20231022120328.137788-1-n2h9z4@gmail.com/
>
> .../bindings/watchdog/cnxt,cx92755-wdt.yaml | 45 +++++++++++++++++++
> .../bindings/watchdog/digicolor-wdt.txt | 25 -----------
> 2 files changed, 45 insertions(+), 25 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/watchdog/cnxt,cx92755-wdt.yaml
> delete mode 100644 Documentation/devicetree/bindings/watchdog/digicolor-wdt.txt
>
> diff --git a/Documentation/devicetree/bindings/watchdog/cnxt,cx92755-wdt.yaml b/Documentation/devicetree/bindings/watchdog/cnxt,cx92755-wdt.yaml
> new file mode 100644
> index 000000000000..1844d7e026fe
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/cnxt,cx92755-wdt.yaml
> @@ -0,0 +1,45 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/watchdog/cnxt,cx92755-wdt.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Conexant Digicolor SoCs Watchdog timer
> +
> +description: |
> + The watchdog functionality in Conexant Digicolor SoCs relies on the so called
> + "Agent Communication" block. This block includes the eight programmable system
> + timer counters. The first timer (called "Timer A") is the only one that can be
> + used as watchdog.
> +
> +allOf:
> + - $ref: watchdog.yaml#
> +
> +maintainers:
> + - Baruch Siach <baruch@tkos.co.il>
> +
> +properties:
> + compatible:
> + const: cnxt,cx92755-wdt
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + watchdog@f0000fc0 {
> + compatible = "cnxt,cx92755-wdt";
> + reg = <0xf0000fc0 0x8>;
> + clocks = <&main_clk>;
> + timeout-sec = <15>;
> + };
> diff --git a/Documentation/devicetree/bindings/watchdog/digicolor-wdt.txt b/Documentation/devicetree/bindings/watchdog/digicolor-wdt.txt
> deleted file mode 100644
> index a882967e17d4..000000000000
> --- a/Documentation/devicetree/bindings/watchdog/digicolor-wdt.txt
> +++ /dev/null
> @@ -1,25 +0,0 @@
> -Conexant Digicolor SoCs Watchdog timer
> -
> -The watchdog functionality in Conexant Digicolor SoCs relies on the so called
> -"Agent Communication" block. This block includes the eight programmable system
> -timer counters. The first timer (called "Timer A") is the only one that can be
> -used as watchdog.
> -
> -Required properties:
> -
> -- compatible : Should be "cnxt,cx92755-wdt"
> -- reg : Specifies base physical address and size of the registers
> -- clocks : phandle; specifies the clock that drives the timer
> -
> -Optional properties:
> -
> -- timeout-sec : Contains the watchdog timeout in seconds
> -
> -Example:
> -
> - watchdog@f0000fc0 {
> - compatible = "cnxt,cx92755-wdt";
> - reg = <0xf0000fc0 0x8>;
> - clocks = <&main_clk>;
> - timeout-sec = <15>;
> - };
> --
> 2.34.1
>
next prev parent reply other threads:[~2023-10-24 18:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 20:26 [PATCH v2] dt-bindings: watchdog: cnxt,cx92755-wdt: convert txt to yaml Nik Bune
2023-10-24 7:39 ` Krzysztof Kozlowski
2023-10-24 18:05 ` Guenter Roeck [this message]
2023-10-25 20:01 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f55d2749-f311-4d8f-a394-3591d18fc523@roeck-us.net \
--to=linux@roeck-us.net \
--cc=baruch@tkos.co.il \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=n2h9z4@gmail.com \
--cc=robh+dt@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).