Linux-Watchdog Archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Peter Griffin <peter.griffin@linaro.org>,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	mturquette@baylibre.com, conor+dt@kernel.org, sboyd@kernel.org,
	tomasz.figa@gmail.com, s.nawrocki@samsung.com,
	linus.walleij@linaro.org, wim@linux-watchdog.org,
	linux@roeck-us.net, catalin.marinas@arm.com, will@kernel.org,
	arnd@arndb.de, olof@lixom.net, gregkh@linuxfoundation.org,
	cw00.choi@samsung.com
Cc: tudor.ambarus@linaro.org, andre.draszik@linaro.org,
	semen.protsenko@linaro.org, saravanak@google.com,
	willmcvicker@google.com, soc@kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org,
	linux-gpio@vger.kernel.org, linux-watchdog@vger.kernel.org,
	kernel-team@android.com, linux-serial@vger.kernel.org
Subject: Re: [PATCH v3 17/20] arm64: dts: google: Add initial Google gs101 SoC support
Date: Thu, 12 Oct 2023 08:44:00 +0200	[thread overview]
Message-ID: <ff91f9e7-6018-402e-935a-c9fa10ced9fd@linaro.org> (raw)
In-Reply-To: <20231011184823.443959-18-peter.griffin@linaro.org>

On 11/10/2023 20:48, Peter Griffin wrote:
> Google gs101 SoC is ARMv8 mobile SoC found in the Pixel 6,
> (oriole) Pixel 6a (bluejay) and Pixel 6 pro (raven) mobile
> phones. It features:
> * 4xA55 little cluster
> * 2xA76 Mid cluster
> * 2xX1 Big cluster
> 

...

> +	gpa10: gpa10-gpio-bank  {
> +		gpio-controller;
> +		#gpio-cells = <2>;
> +		interrupt-controller;
> +		#interrupt-cells = <2>;
> +		interrupts = <GIC_SPI 43 IRQ_TYPE_LEVEL_HIGH>,
> +			   <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>;
> +	};
> +
> +	uart15_bus: uart15-bus-pins {
> +	       samsung,pins = "gpa2-3", "gpa2-4";
> +	       samsung,pin-function = <2>;

GS101_PIN_FUNC_2

> +	       samsung,pin-pud = <0>;

GS101_PIN_PULL_NONE

> +	};
> +
> +	uart16_bus: uart16-bus-pins {
> +	       samsung,pins = "gpa3-0", "gpa3-1", "gpa3-2", "gpa3-3";
> +	       samsung,pin-function = <GS101_PIN_FUNC_2>;
> +	       samsung,pin-pud = <GS101_PIN_PULL_NONE>;

But here it is correct...

> +	};
> +
> +	uart16_bus_rts: uart1-bus-rts-pins {
> +		samsung,pins = "gpa3-2";
> +		samsung,pin-function = <GS101_PIN_FUNC_OUTPUT>;
> +		samsung,pin-pud = <GS101_PIN_PULL_NONE>;
> +		samsung,pin-val = <1>;

Why do you set UART RTS pin value?

> +	};
> +
> +	uart16_bus_tx_dat: uart1-bus-tx-dat-pins {
> +		samsung,pins = "gpa3-1";
> +		samsung,pin-val = <1>;
> +	};
> +


Best regards,
Krzysztof


  parent reply	other threads:[~2023-10-12  6:44 UTC|newest]

Thread overview: 100+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-11 18:48 [PATCH v3 00/20] Add minimal Tensor/GS101 SoC support and Oriole/Pixel6 board Peter Griffin
2023-10-11 18:48 ` [PATCH v3 01/20] dt-bindings: soc: samsung: exynos-pmu: Add gs101 compatible Peter Griffin
2023-10-11 18:54   ` Sam Protsenko
2023-10-11 18:48 ` [PATCH v3 02/20] dt-bindings: clock: Add Google gs101 clock management unit bindings Peter Griffin
2023-10-11 21:48   ` William McVicker
2023-10-12  6:07     ` Krzysztof Kozlowski
2023-10-12  8:56       ` Peter Griffin
2023-10-12  9:36         ` Krzysztof Kozlowski
2023-10-12 10:45           ` Peter Griffin
2023-10-12 11:33             ` Krzysztof Kozlowski
2023-10-12 16:41               ` William McVicker
2023-10-11 22:55   ` Sam Protsenko
2023-10-12  6:11   ` Krzysztof Kozlowski
2023-10-12 10:15     ` Peter Griffin
2023-10-12 10:20       ` Krzysztof Kozlowski
2023-10-12 10:39         ` Peter Griffin
2023-10-11 18:48 ` [PATCH v3 03/20] dt-bindings: soc: google: exynos-sysreg: add dedicated SYSREG compatibles to GS101 Peter Griffin
2023-10-11 22:56   ` Sam Protsenko
2023-10-16 13:36   ` Rob Herring
2023-10-19 13:10     ` Peter Griffin
2023-10-11 18:48 ` [PATCH v3 04/20] dt-bindings: watchdog: Document Google gs101 & gs201 watchdog bindings Peter Griffin
2023-10-11 22:57   ` Sam Protsenko
2023-10-12 10:56     ` Peter Griffin
2023-10-11 18:48 ` [PATCH v3 05/20] dt-bindings: arm: google: Add bindings for Google ARM platforms Peter Griffin
2023-10-11 23:06   ` Sam Protsenko
2023-10-12 11:19     ` Peter Griffin
2023-10-11 18:48 ` [PATCH v3 06/20] dt-bindings: pinctrl: samsung: add google,gs101-pinctrl compatible Peter Griffin
2023-10-11 23:10   ` Sam Protsenko
2023-10-16 13:41   ` Rob Herring
2023-11-07 12:18     ` Peter Griffin
2023-10-11 18:48 ` [PATCH v3 07/20] dt-bindings: pinctrl: samsung: add gs101-wakeup-eint compatible Peter Griffin
2023-10-12  6:13   ` Krzysztof Kozlowski
2023-10-11 18:48 ` [PATCH v3 08/20] dt-bindings: serial: samsung: Add google-gs101-uart compatible Peter Griffin
2023-10-11 23:13   ` Sam Protsenko
2023-10-11 18:48 ` [PATCH v3 09/20] clk: samsung: clk-pll: Add support for pll_{0516,0517,518} Peter Griffin
2023-10-11 21:49   ` William McVicker
2023-10-11 23:19   ` Sam Protsenko
2023-10-12 11:50     ` Peter Griffin
     [not found]   ` <ef25ed87-f065-4a75-9e57-1f1073d9c805@kernel.org>
2023-10-17 20:39     ` Peter Griffin
2023-10-11 18:48 ` [PATCH v3 10/20] clk: samsung: clk-gs101: Add cmu_top registers, plls, mux and gates Peter Griffin
2023-10-11 21:50   ` William McVicker
2023-10-12  0:06   ` Sam Protsenko
2023-10-12 12:06     ` Peter Griffin
2023-10-12 12:24       ` Krzysztof Kozlowski
2023-10-12 13:52         ` Peter Griffin
     [not found]   ` <aae4e6cd-dcfc-442d-9ed7-d5a73c419ba8@kernel.org>
2023-11-07 13:57     ` Peter Griffin
2023-11-08 17:33       ` Sam Protsenko
2023-12-01 13:59         ` Peter Griffin
2023-10-11 18:48 ` [PATCH v3 11/20] clk: samsung: clk-gs101: add CMU_APM support Peter Griffin
2023-10-11 21:50   ` William McVicker
2023-10-12  0:10   ` Sam Protsenko
2023-10-11 18:48 ` [PATCH v3 12/20] clk: samsung: clk-gs101: Add support for CMU_MISC clock unit Peter Griffin
2023-10-11 21:51   ` William McVicker
2023-10-12  0:12   ` Sam Protsenko
2023-10-12 16:02     ` Peter Griffin
2023-10-11 18:48 ` [PATCH v3 13/20] pinctrl: samsung: Add filter selection support for alive banks Peter Griffin
2023-10-11 21:51   ` William McVicker
2023-10-11 22:47   ` Sam Protsenko
2023-10-20 13:54     ` Peter Griffin
2023-10-11 18:48 ` [PATCH v3 14/20] pinctrl: samsung: Add gs101 SoC pinctrl configuration Peter Griffin
2023-10-11 21:52   ` William McVicker
2023-10-11 21:53   ` William McVicker
2023-10-12  5:59   ` Sam Protsenko
2023-11-08 13:43     ` Peter Griffin
2023-10-11 18:48 ` [PATCH v3 15/20] watchdog: s3c2410_wdt: Add support for Google tensor SoCs Peter Griffin
2023-10-11 21:20   ` Guenter Roeck
2023-10-17 21:26     ` Peter Griffin
2023-10-12  2:32   ` Sam Protsenko
2023-10-17 21:39     ` Peter Griffin
2023-10-12  6:22   ` Krzysztof Kozlowski
2023-10-11 18:48 ` [PATCH v3 16/20] tty: serial: samsung: Add gs101 compatible and SoC data Peter Griffin
2023-10-11 21:54   ` William McVicker
2023-10-12  5:38   ` Sam Protsenko
2023-10-12  6:07   ` Arnd Bergmann
2023-10-20 21:47     ` Peter Griffin
2023-10-12  6:26   ` Krzysztof Kozlowski
2023-10-12 14:03     ` Peter Griffin
2023-10-12 14:10       ` Krzysztof Kozlowski
2023-10-11 18:48 ` [PATCH v3 17/20] arm64: dts: google: Add initial Google gs101 SoC support Peter Griffin
2023-10-11 21:55   ` William McVicker
2023-10-12  6:40   ` Krzysztof Kozlowski
2023-11-24 23:22     ` Peter Griffin
2023-11-28  8:58       ` Krzysztof Kozlowski
2023-10-12  6:44   ` Krzysztof Kozlowski [this message]
2023-11-24 23:53     ` Peter Griffin
2023-10-12  7:23   ` Sam Protsenko
2023-10-12  7:39     ` Krzysztof Kozlowski
2023-11-28 22:43     ` Peter Griffin
2023-10-11 18:48 ` [PATCH v3 18/20] arm64: dts: google: Add initial Oriole/pixel 6 board support Peter Griffin
2023-10-11 21:55   ` William McVicker
2023-10-12  6:44   ` Krzysztof Kozlowski
2023-10-12  7:40   ` Sam Protsenko
2023-10-11 18:48 ` [PATCH v3 19/20] arm64: defconfig: Enable Google Tensor SoC Peter Griffin
2023-10-11 21:56   ` William McVicker
2023-10-12  6:15   ` Sam Protsenko
2023-10-11 18:48 ` [PATCH v3 20/20] MAINTAINERS: add entry for " Peter Griffin
2023-10-12  6:02   ` Sam Protsenko
2023-10-11 21:58 ` [PATCH v3 00/20] Add minimal Tensor/GS101 SoC support and Oriole/Pixel6 board William McVicker
2023-10-11 22:51 ` Sam Protsenko
2023-10-12  6:28 ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ff91f9e7-6018-402e-935a-c9fa10ced9fd@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=andre.draszik@linaro.org \
    --cc=arnd@arndb.de \
    --cc=catalin.marinas@arm.com \
    --cc=conor+dt@kernel.org \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel-team@android.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=mturquette@baylibre.com \
    --cc=olof@lixom.net \
    --cc=peter.griffin@linaro.org \
    --cc=robh+dt@kernel.org \
    --cc=s.nawrocki@samsung.com \
    --cc=saravanak@google.com \
    --cc=sboyd@kernel.org \
    --cc=semen.protsenko@linaro.org \
    --cc=soc@kernel.org \
    --cc=tomasz.figa@gmail.com \
    --cc=tudor.ambarus@linaro.org \
    --cc=will@kernel.org \
    --cc=willmcvicker@google.com \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).