From: Ping-Ke Shih <pkshih@realtek.com>
To: Bitterblue Smith <rtl8821cerfe2@gmail.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Stefan Lippers-Hollmann <s.l-h@gmx.de>,
Christian Hewitt <chewitt@libreelec.tv>
Subject: RE: [PATCH v6 5/6] wifi: rtlwifi: Clean up rtl8192d-common a bit
Date: Mon, 22 Apr 2024 03:13:33 +0000 [thread overview]
Message-ID: <13ed709559ee4a48993519c88223a8d3@realtek.com> (raw)
In-Reply-To: <fe031948-9602-4f6b-9c13-7797047c03b6@gmail.com>
Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote:
> Improve readability:
> * add empty lines
> * use abs_diff in rtl92d_dm_txpower_tracking_callback_thermalmeter
> * roll up repeated statements into a for loop in
> rtl92d_dm_txpower_tracking_callback_thermalmeter
> * shorten lines by replacing many instances of "rtlpriv->dm" with "dm"
> pointer in rtl92d_dm_txpower_tracking_callback_thermalmeter
> * sort some declarations by length
> * refactor _rtl92d_get_txpower_writeval_by_regulatory a little
> * refactor _rtl92de_readpowervalue_fromprom a little
>
> Delete unused structs tag_dynamic_init_gain_operation_type_definition
> and swat.
>
> Simplify rtl92d_fill_h2c_cmd a little and delete a pointless wrapper
> function.
>
> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
Thanks for the cleanup and test. Please also provide tested devices
to me.
Reviewed-by: Ping-Ke Shih <pkshih@realtek.com>
next prev parent reply other threads:[~2024-04-22 3:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-19 13:34 [PATCH v6 0/6] wifi: rtlwifi: Move common code from rtl8192de to rtl8192d-common Bitterblue Smith
2024-04-19 13:35 ` [PATCH v6 1/6] wifi: rtlwifi: rtl8192de: Fix 5 GHz TX power Bitterblue Smith
2024-04-19 13:36 ` [PATCH v6 2/6] wifi: rtlwifi: rtl8192de: Fix low speed with WPA3-SAE Bitterblue Smith
2024-04-19 13:37 ` [PATCH v6 3/6] wifi: rtlwifi: rtl8192de: Fix endianness issue in RX path Bitterblue Smith
2024-04-19 13:37 ` [PATCH v6 4/6] wifi: rtlwifi: Move code from rtl8192de to rtl8192d-common Bitterblue Smith
2024-04-22 2:55 ` Ping-Ke Shih
2024-04-22 17:25 ` Bitterblue Smith
2024-04-23 0:48 ` Ping-Ke Shih
2024-04-23 11:06 ` Bitterblue Smith
2024-04-19 13:38 ` [PATCH v6 5/6] wifi: rtlwifi: Clean up rtl8192d-common a bit Bitterblue Smith
2024-04-22 3:13 ` Ping-Ke Shih [this message]
2024-04-22 17:18 ` Bitterblue Smith
2024-04-19 13:39 ` [PATCH v6 6/6] wifi: rtlwifi: Adjust rtl8192d-common for USB Bitterblue Smith
2024-04-22 3:39 ` Ping-Ke Shih
2024-04-22 17:13 ` Bitterblue Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13ed709559ee4a48993519c88223a8d3@realtek.com \
--to=pkshih@realtek.com \
--cc=Larry.Finger@lwfinger.net \
--cc=chewitt@libreelec.tv \
--cc=linux-wireless@vger.kernel.org \
--cc=rtl8821cerfe2@gmail.com \
--cc=s.l-h@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).