From: Kalle Valo <kvalo@kernel.org>
To: Karthikeyan Periyasamy <quic_periyasa@quicinc.com>
Cc: <ath12k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
Karthikeyan Periyasamy <quic_periyasa@quicinc.com>,
Jeff Johnson <quic_jjohnson@quicinc.com>
Subject: Re: [PATCH v3 1/4] wifi: ath12k: avoid redundant code in Rx cookie conversion init
Date: Mon, 22 Apr 2024 12:06:49 +0000 (UTC) [thread overview]
Message-ID: <171378760774.1358009.4155348032452693062.kvalo@kernel.org> (raw)
In-Reply-To: <20240411102226.4045323-2-quic_periyasa@quicinc.com>
Karthikeyan Periyasamy <quic_periyasa@quicinc.com> wrote:
> Currently, in the Rx data path cookie conversion initialization procedure,
> the primary page table index (ppt_idx) is computed within the secondary
> page table iteration. However this is invariant, and hence the ppt_idx
> should be calculated outside of the iteration to avoid repeated execution
> of the statement.
>
> Found in code review.
>
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.1.1-00188-QCAHKSWPL_SILICONZ-1
> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3
>
> Signed-off-by: Karthikeyan Periyasamy <quic_periyasa@quicinc.com>
> Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
4 patches applied to ath-next branch of ath.git, thanks.
3ea19127d154 wifi: ath12k: avoid redundant code in Rx cookie conversion init
b3e9e82b31c0 wifi: ath12k: Refactor the hardware cookie conversion init
682ca418d40a wifi: ath12k: displace the Tx and Rx descriptor in cookie conversion table
d4e3fc4f45c6 wifi: ath12k: Refactor data path cmem init
--
https://patchwork.kernel.org/project/linux-wireless/patch/20240411102226.4045323-2-quic_periyasa@quicinc.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2024-04-22 12:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-11 10:22 [PATCH v3 0/4] wifi: ath12k: Refactor hardware cookie conversion Karthikeyan Periyasamy
2024-04-11 10:22 ` [PATCH v3 1/4] wifi: ath12k: avoid redundant code in Rx cookie conversion init Karthikeyan Periyasamy
2024-04-22 12:06 ` Kalle Valo [this message]
2024-04-11 10:22 ` [PATCH v3 2/4] wifi: ath12k: Refactor the hardware " Karthikeyan Periyasamy
2024-04-11 10:22 ` [PATCH v3 3/4] wifi: ath12k: displace the Tx and Rx descriptor in cookie conversion table Karthikeyan Periyasamy
2024-04-11 10:22 ` [PATCH v3 4/4] wifi: ath12k: Refactor data path cmem init Karthikeyan Periyasamy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171378760774.1358009.4155348032452693062.kvalo@kernel.org \
--to=kvalo@kernel.org \
--cc=ath12k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_jjohnson@quicinc.com \
--cc=quic_periyasa@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).