From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: Rameshkumar Sundaram <quic_ramess@quicinc.com>,
<ath12k@lists.infradead.org>
Cc: <linux-wireless@vger.kernel.org>, Sriram R <quic_srirrama@quicinc.com>
Subject: Re: [PATCH v2 1/3] wifi: ath12k: prepare vif data structure for MLO handling
Date: Thu, 2 May 2024 11:27:21 -0700 [thread overview]
Message-ID: <1b260786-310c-4143-bf78-7afce33f05fe@quicinc.com> (raw)
In-Reply-To: <20240502171240.927155-2-quic_ramess@quicinc.com>
On 5/2/2024 10:12 AM, Rameshkumar Sundaram wrote:
> From: Sriram R <quic_srirrama@quicinc.com>
>
> To prepare the driver for MLO support, split the driver vif
> data structure to scale for multiple links. This requires changing
> the use of arvif to per link and not per hw which can now
> comprise of multiple links.
> Also since most configurations from mac80211 are done per link, do refactoring
> of the driver functions to apply these configurations at link level.
>
> Split ath12k_vif which is the driver private of ieee80211_vif to store
> link specific information as ath12k_link_vif. For default use cases
> the ath12k vif will have a preallocated link vif called deflink which will
> be used by non ML and the first link vif of ML vif.
>
> With MLO Support to be added, remaining link vifs will be allocated during
> channel assignment where vdev create/start happens. These link vifs will be
> freed during interface down.
>
> Current ath12k_vif(arvif) structure
>
> +---------------+ +---------------+ +---------------+
> | ieee80211_vif | | ieee80211_vif | | ieee80211_vif |
> | private data | | private data | | private data |
> | | | | | |
> | ath12k_vif | | ath12k_vif | | ath12k_vif |
> | (arvif) | | (arvif) | | (arvif) |
> | | | | | |
> | +----------+ | | +----------+ | | +----------+ |
> | |*ar (2GHz)| | | |*ar (5GHz)| | | |*ar (2GHz)| |
> | +----------+ | | +----------+ | | +----------+ |
> | | | | | |
> +---------------+ +---------------+ +---------------+
>
> Proposed ath12k_vif(ahvif) containing ath12k_link_vif(s) (arvif)
> (deflink is preallocated member which is always the first link if
> ieee80211_vif is MLD and is the only link otherwise)
>
> +---------------------------------+
> | ieee80211_vif |
> | private data |
> | |
> | ath12k_vif(ahvif) |
> | |
> | +-------------------------------+
> | |ath12k_link_vif deflink (arvif)|
> | | +---------------+ |
> | | | *ar(2GHz) | |
> | +-------------------------------+
> | +-------------------------------+
> | | ath12k_link_vif *link (arvif)|
> | | +---------------+ |
> | | | *ar(5GHz) | |
> | +-------------------------------+
> | +-------------------------------+
> | | ath12k_link_vif *link (arvif)|
> | | +---------------+ |
> | | | *ar(6GHz) | |
> | +-------------------------------+
> | |
> +---------------------------------+
>
> To refactor existing ath12k_vif to make use of link vifs, following
> changes are made,
>
> 1. ath12k_vif now called by variable name ahvif stores multiple
> arvifs(ah12k_link_vif) and also has a back pointer to ieee80211_vif.
>
> 2. In this patch set, only deflink is used to be on par with the
> existing code. When MLO support is added the link id will be used to
> fetch the arvif.
>
> 3. For mac80211 ops which doesn't use specific link_id, the config or info
> is common for the vif, hence apply the config to all link vifs.
> The links_map in the ahvif, will be used to identify all the link vifs that
> are setup.
>
> 4. Change ath12k_vif_to_arvif() as ath12k_vif_to_ahvif() to fetch the
> hw level vif. The link vif can be fetched from ahvif->link[], or the
> deflink can be accessed via ahvif->deflink. API to access link
> vif(arvif) by passing link_id can be introduced with MLO Support.
>
> 5. The ieee80211_vif can be accessed from ahvif using ath12k_vif_to_vif()
>
> Locking:
> Currently modifications to members of arvif and arsta are protected by ar->conf_mutex
> and it stays as such.
> Now with these hw level structure (ahvif) being introduced, any modifications
> to its members and link objects (i.e., arvifs[] which are dynamically allocated)
> needs to be protected for writing and ah->conf_mutex is used for the same.
> Also, atomic contexts(say WMI events and certain mac_ops) that we currently have in driver
> will not(shouldn't be allowed) do any modifications but can read them and
> rcu_read_lock() is used for the same.
>
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3
>
> Signed-off-by: Sriram R <quic_srirrama@quicinc.com>
> Co-developed-by: Rameshkumar Sundaram <quic_ramess@quicinc.com>
> Signed-off-by: Rameshkumar Sundaram <quic_ramess@quicinc.com>
Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>
next prev parent reply other threads:[~2024-05-02 18:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-02 17:12 [PATCH v2 0/3] wifi: ath12k: prepare vif and sta datastructure for MLO handling Rameshkumar Sundaram
2024-05-02 17:12 ` [PATCH v2 1/3] wifi: ath12k: prepare vif data structure " Rameshkumar Sundaram
2024-05-02 18:27 ` Jeff Johnson [this message]
2024-05-02 17:12 ` [PATCH v2 2/3] wifi: ath12k: pass ath12k_link_vif instead of vif/ahvif Rameshkumar Sundaram
2024-05-02 17:12 ` [PATCH v2 3/3] wifi: ath12k: prepare sta data structure for MLO handling Rameshkumar Sundaram
2024-05-03 14:45 ` [PATCH v2 0/3] wifi: ath12k: prepare vif and sta datastructure " Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b260786-310c-4143-bf78-7afce33f05fe@quicinc.com \
--to=quic_jjohnson@quicinc.com \
--cc=ath12k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_ramess@quicinc.com \
--cc=quic_srirrama@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).