From: Lewis Robbins <lewis.robbins2@gmail.com>
To: pkshih@realtek.com
Cc: lewis.robbins2@gmail.com, linux-wireless@vger.kernel.org
Subject: RE: [PATCH] wifi: rtw88: suppress messages of failed to flush queue
Date: Wed, 17 Apr 2024 23:14:52 +0100 [thread overview]
Message-ID: <20240417221451.43964-2-lewis.robbins2@gmail.com> (raw)
In-Reply-To: <20240417014036.11234-1-pkshih@realtek.com>
Thanks, I tested it for 30 minutes and didn't receive any superfluous warning message. Only thing I could find was the comment above not reflecting the (new) debug print (but very nit-picky from me).
Acked-by: Lewis Robbins <lewis.robbins2@gmail.com>
diff --git a/drivers/net/wireless/realtek/rtw88/mac.c b/drivers/net/wireless/realtek/rtw88/mac.c
index 9038e2311596..3d1a886262d8 100644
--- a/drivers/net/wireless/realtek/rtw88/mac.c
+++ b/drivers/net/wireless/realtek/rtw88/mac.c
@@ -1026,7 +1026,7 @@ static void __rtw_mac_flush_prio_queue(struct rtw_dev *rtwdev,
msleep(20);
}
- /* priority queue is still not empty, throw a warning,
+ /* priority queue is still not empty, throw a debug message
*
* Note that if we want to flush the tx queue when having a lot of
* traffic (ex, 100Mbps up), some of the packets could be dropped.
next prev parent reply other threads:[~2024-04-17 22:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 1:40 [PATCH] wifi: rtw88: suppress messages of failed to flush queue Ping-Ke Shih
2024-04-17 22:14 ` Lewis Robbins [this message]
2024-04-18 0:31 ` Ping-Ke Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240417221451.43964-2-lewis.robbins2@gmail.com \
--to=lewis.robbins2@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).