From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: Lingbo Kong <quic_lingbok@quicinc.com>, <ath12k@lists.infradead.org>
Cc: <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH V3 0/3] wifi: ath12k: report station mode stats
Date: Mon, 15 Apr 2024 09:51:00 -0700 [thread overview]
Message-ID: <3103b7cf-fa1a-4bfc-ad78-301965b72035@quicinc.com> (raw)
In-Reply-To: <20240414131008.71519-1-quic_lingbok@quicinc.com>
On 4/14/2024 6:10 AM, Lingbo Kong wrote:
> Currently, the transmit rate, the receive rate and signal strength of
> “iw dev xxx station dump” always show an invalid value.
>
> This is because ath12k has no logic to handle this relevant information.
>
> To solve this issue, ath12k parses the information passed by the firmware
> and passes it to mac80211.
>
> After that, "iw dev xxx station dump" show the correct value.
> Such as:
>
> Station 00:03:7f:12:03:03 (on wlo1)
> inactive time: 600 ms
> rx bytes: 4642228
> rx packets: 23796
> tx bytes: 933967
> tx packets: 8761
> tx retries: 66
> tx failed: 0
> beacon loss: 0
> beacon rx: 8925
> rx drop misc: 191
> signal: -20 dBm
> beacon signal avg: -18 dBm
> tx bitrate: 1441.1 MBit/s 80MHz EHT-MCS 13 EHT-NSS 2 EHT-GI 0
> tx duration: 0 us
> rx bitrate: 1801.4 MBit/s 80MHz EHT-MCS 11 EHT-NSS 3 EHT-GI 0
> rx duration: 0 us
>
> v3:
> 1.change wmi_vdev_stats_event to wmi_vdev_stats_params
>
> v2:
> 1.change copyright
> 2.change name according Naming conventions for structures
>
> Lingbo Kong (3):
> wifi: ath12k: report station mode transmit rate
> wifi: ath12k: report station mode receive rate for IEEE 802.11be
> wifi: ath12k: report station mode signal strength
>
> drivers/net/wireless/ath/ath12k/core.h | 5 +
> drivers/net/wireless/ath/ath12k/dp_rx.c | 20 ++-
> drivers/net/wireless/ath/ath12k/dp_rx.h | 3 +
My Qualcomm Innovation Center copyright checker reports:
drivers/net/wireless/ath/ath12k/dp_rx.h copyright missing 2024
However note that "wifi: ath12k: support suspend/resume" is modifying the same
file, so if you rebase on that you'll pick up the copyright change
> drivers/net/wireless/ath/ath12k/dp_tx.c | 147 +++++++++++++++++-
> drivers/net/wireless/ath/ath12k/hal_tx.h | 9 +-
> drivers/net/wireless/ath/ath12k/mac.c | 180 +++++++++++++++++++++-
> drivers/net/wireless/ath/ath12k/mac.h | 3 +
> drivers/net/wireless/ath/ath12k/rx_desc.h | 2 +
> drivers/net/wireless/ath/ath12k/wmi.c | 130 ++++++++++++++++
> drivers/net/wireless/ath/ath12k/wmi.h | 48 ++++++
> 10 files changed, 538 insertions(+), 9 deletions(-)
next prev parent reply other threads:[~2024-04-15 16:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-14 13:10 [PATCH V3 0/3] wifi: ath12k: report station mode stats Lingbo Kong
2024-04-14 13:10 ` [PATCH V3 1/3] wifi: ath12k: report station mode transmit rate Lingbo Kong
2024-04-14 13:10 ` [PATCH V3 2/3] wifi: ath12k: report station mode receive rate for IEEE 802.11be Lingbo Kong
2024-04-14 13:10 ` [PATCH V3 3/3] wifi: ath12k: report station mode signal strength Lingbo Kong
2024-04-15 14:02 ` [PATCH V3 0/3] wifi: ath12k: report station mode stats Lingbo Kong
2024-04-15 16:51 ` Jeff Johnson [this message]
2024-04-16 2:32 ` Lingbo Kong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3103b7cf-fa1a-4bfc-ad78-301965b72035@quicinc.com \
--to=quic_jjohnson@quicinc.com \
--cc=ath12k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_lingbok@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).