From: Ping-Ke Shih <pkshih@realtek.com>
To: Bitterblue Smith <rtl8821cerfe2@gmail.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: Ping-Ke Shih <pkshih@realtek.com>, Sascha Hauer <sha@pengutronix.de>
Subject: Re: [PATCH] wifi: rtw88: usb: Fix disconnection after beacon loss
Date: Thu, 9 May 2024 14:23:25 +0800 [thread overview]
Message-ID: <5fc4ad6b-5af8-469b-9665-d41ddb6d465f@RTEXMBS04.realtek.com.tw> (raw)
In-Reply-To: <ecbf0601-810d-4609-b8fc-8b0e38d2948d@gmail.com>
Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote:
> When there is beacon loss, for example due to unrelated Bluetooth
> devices transmitting music nearby, the wifi connection dies soon
> after the first beacon loss message:
>
> Apr 28 20:47:14 ideapad2 wpa_supplicant[1161]: wlp3s0f3u4:
> CTRL-EVENT-BEACON-LOSS
> Apr 28 20:47:15 ideapad2 wpa_supplicant[1161]: wlp3s0f3u4:
> CTRL-EVENT-DISCONNECTED bssid=... reason=4 locally_generated=1
>
> Apr 28 20:47:24 ideapad2 wpa_supplicant[1161]: wlp3s0f3u4:
> CTRL-EVENT-BEACON-LOSS
> Apr 28 20:47:25 ideapad2 wpa_supplicant[1161]: wlp3s0f3u4:
> CTRL-EVENT-DISCONNECTED bssid=... reason=4 locally_generated=1
>
> Apr 28 20:47:34 ideapad2 wpa_supplicant[1161]: wlp3s0f3u4:
> CTRL-EVENT-BEACON-LOSS
> Apr 28 20:47:35 ideapad2 wpa_supplicant[1161]: wlp3s0f3u4:
> CTRL-EVENT-DISCONNECTED bssid=... reason=4 locally_generated=1
>
> When the beacon loss happens, mac80211 makes rtw88 transmit a QOS
> NULL frame and asks to confirm the ACK status. Even though rtw88
> confirms to mac80211 that the QOS NULL was transmitted successfully,
> the connection still dies. This is because rtw88 is handing the QOS
> NULL back to mac80211 with skb->data pointing to the headroom (the
> TX descriptor) instead of ieee80211_hdr.
>
> Fix the disconnection by moving skb->data to the correct position
> before ieee80211_tx_status_irqsafe().
>
> The problem was observed with RTL8811AU (TP-Link Archer T2U Nano)
> and the potential future rtw88_8821au driver. Also tested with
> RTL8811CU (Tenda U9).
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
1 patch(es) applied to rtw-next branch of rtw.git, thanks.
28818b4d871b wifi: rtw88: usb: Fix disconnection after beacon loss
---
https://github.com/pkshih/rtw.git
prev parent reply other threads:[~2024-05-09 6:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-29 17:57 [PATCH] wifi: rtw88: usb: Fix disconnection after beacon loss Bitterblue Smith
2024-04-30 0:50 ` Ping-Ke Shih
2024-04-30 12:14 ` Bitterblue Smith
2024-05-09 6:23 ` Ping-Ke Shih [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5fc4ad6b-5af8-469b-9665-d41ddb6d465f@RTEXMBS04.realtek.com.tw \
--to=pkshih@realtek.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rtl8821cerfe2@gmail.com \
--cc=sha@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).