From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: Lingbo Kong <quic_lingbok@quicinc.com>, <ath12k@lists.infradead.org>
Cc: <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 3/3] wifi: ath12k: report station mode signal strength
Date: Fri, 12 Apr 2024 08:47:38 -0700 [thread overview]
Message-ID: <600c43f3-a069-44a6-be7a-2cc3281cf88c@quicinc.com> (raw)
In-Reply-To: <70f73d7c-4ed1-4678-9eb4-7d4594af1df9@quicinc.com>
On 4/12/2024 2:45 AM, Lingbo Kong wrote:
> On 2024/4/12 5:51, Jeff Johnson wrote:
>> On 4/10/2024 7:53 PM, Lingbo Kong wrote:
>>> +struct ath12k_wmi_vdev_stats {
>>
>> this name does not conform to the "Naming conventions for structures" outlined
>> at the beginning of the file:
>> * _params is a structure which is embedded either into _cmd or _event (or
>> * both), it is not sent individually.
>>
>
> Oh, thanks for pointing out.
> I get what you mean, but the ath12k_wmi_vdev_stats belongs to event, so,
> i can changes it to wmi_vdev_stats_event, i will apply it in next version.
note that _event should only be used for the first TLV in the event payload.
Any subsequent TLVs in either a command or event should use _params
next prev parent reply other threads:[~2024-04-12 15:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-11 2:53 [PATCH 0/3] wifi: ath12k: report station mode stats Lingbo Kong
2024-04-11 2:53 ` [PATCH 1/3] wifi: ath12k: report station mode transmit rate Lingbo Kong
2024-04-11 21:47 ` Jeff Johnson
2024-04-11 2:53 ` [PATCH 2/3] wifi: ath12k: report station mode receive rate for IEEE 802.11be Lingbo Kong
2024-04-11 2:53 ` [PATCH 3/3] wifi: ath12k: report station mode signal strength Lingbo Kong
2024-04-11 21:51 ` Jeff Johnson
2024-04-12 9:45 ` Lingbo Kong
2024-04-12 15:47 ` Jeff Johnson [this message]
2024-04-11 21:39 ` [PATCH 0/3] wifi: ath12k: report station mode stats Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=600c43f3-a069-44a6-be7a-2cc3281cf88c@quicinc.com \
--to=quic_jjohnson@quicinc.com \
--cc=ath12k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_lingbok@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).