From: Vasanthakumar Thiagarajan <quic_vthiagar@quicinc.com>
To: Tamizh Chelvam Raja <quic_tamizhr@quicinc.com>,
<ath12k@lists.infradead.org>
Cc: <linux-wireless@vger.kernel.org>
Subject: Re: [PATCHv2 0/3] wifi: ath12k: Remove unsupported and unused ring configurations
Date: Mon, 29 Apr 2024 10:55:51 +0530 [thread overview]
Message-ID: <64e35352-b301-8464-6fc9-f8b0a2e3474b@quicinc.com> (raw)
In-Reply-To: <4f567b1a-aebc-709c-5303-ecbeb5cebc30@quicinc.com>
On 4/29/2024 9:54 AM, Tamizh Chelvam Raja wrote:
> On 4/28/2024 8:59 AM, Vasanthakumar Thiagarajan wrote:
>>
>>
>> On 4/27/2024 9:56 PM, Tamizh Chelvam Raja wrote:
>>> Currently in driver doing memory allocation for tx_monitor,
>>> tcl_cmd_ring and tcl_status ring. Here driver support for
>>> tx_monitor mode is not there and memory for tcl_cmd and tcl_status
>>> rings are allocated by firmware and it uses that memory instead of
>>> host allocated. So avoid these unused ring setup configuration.
>>>
>>> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
>>>
>>> Tamizh Chelvam Raja (3):
>>> wifi: ath12k: fix calling correct function for rx monitor mode
>>> wifi: ath12k: Remove unsupported tx monitor handling
>>> wifi: ath12k: Remove unused tcl_*_ring configuration
>>>
>>> v2:
>>> * Rebased on top of ToT
>>>
>>> drivers/net/wireless/ath/ath12k/dp.c | 16 -------
>>> drivers/net/wireless/ath/ath12k/dp.h | 2 -
>>> drivers/net/wireless/ath/ath12k/dp_mon.c | 40 +----------------
>>> drivers/net/wireless/ath/ath12k/dp_rx.c | 56 ------------------------
>>> drivers/net/wireless/ath/ath12k/dp_tx.c | 44 +------------------
>>> drivers/net/wireless/ath/ath12k/dp_tx.h | 1 -
>>> 6 files changed, 2 insertions(+), 157 deletions(-)
>>>
>>>
>>
>> It nice to see code removal in general :)
>> But I've also seen some concerns internally around code removal
>> especially when the code will have to be re-added in future while
>> properly supporting the feature. I guess the cover letter
>> may need to clarify those concerns at least for internal review.
>>
> This is mainly to avoid unnecessary memory allocation for the unused rings.
> And this can be added in the future while enabling the feature.
I agree. I think I somehow overlooked the memory optimization part. Thanks
for the clarification.
Vasanth
prev parent reply other threads:[~2024-04-29 5:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-27 16:26 [PATCHv2 0/3] wifi: ath12k: Remove unsupported and unused ring configurations Tamizh Chelvam Raja
2024-04-27 16:26 ` [PATCHv2 1/3] wifi: ath12k: fix calling correct function for rx monitor mode Tamizh Chelvam Raja
2024-04-28 4:58 ` Karthikeyan Periyasamy
2024-04-27 16:26 ` [PATCHv2 2/3] wifi: ath12k: Remove unsupported tx monitor handling Tamizh Chelvam Raja
2024-04-27 16:26 ` [PATCHv2 3/3] wifi: ath12k: Remove unused tcl_*_ring configuration Tamizh Chelvam Raja
2024-04-28 3:29 ` [PATCHv2 0/3] wifi: ath12k: Remove unsupported and unused ring configurations Vasanthakumar Thiagarajan
2024-04-29 4:24 ` Tamizh Chelvam Raja
2024-04-29 5:25 ` Vasanthakumar Thiagarajan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64e35352-b301-8464-6fc9-f8b0a2e3474b@quicinc.com \
--to=quic_vthiagar@quicinc.com \
--cc=ath12k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_tamizhr@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).