From: Ping-Ke Shih <pkshih@realtek.com>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>, <pkshih@realtek.com>
Cc: <kvalo@kernel.org>, <linux-wireless@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH v2] wifi: rtw89: Remove the redundant else branch in the function rtw89_phy_get_kpath
Date: Mon, 29 Apr 2024 09:47:05 +0800 [thread overview]
Message-ID: <6c24f3d4-0817-4ad1-8ecb-236bf6af847a@RTEXMBS04.realtek.com.tw> (raw)
In-Reply-To: <20240422072922.50940-1-jiapeng.chong@linux.alibaba.com>
Jiapeng Chong <jiapeng.chong@linux.alibaba.com> wrote:
> The assignment of the else and if branches is the same in the "case:
> MLO_2_PLUS_0_1RF" branch of the function rtw89_phy_get_kpath, so we
> remove it and add comments here to make the code easier to understand.
>
> ./drivers/net/wireless/realtek/rtw89/phy.c:6406:2-4: WARNING: possible condition with no effect (if == else).
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8812
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
1 patch(es) applied to rtw-next branch of rtw.git, thanks.
5eb027019fa3 wifi: rtw89: Remove the redundant else branch in the function rtw89_phy_get_kpath
---
https://github.com/pkshih/rtw.git
prev parent reply other threads:[~2024-04-29 1:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 7:29 [PATCH v2] wifi: rtw89: Remove the redundant else branch in the function rtw89_phy_get_kpath Jiapeng Chong
2024-04-29 1:47 ` Ping-Ke Shih [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c24f3d4-0817-4ad1-8ecb-236bf6af847a@RTEXMBS04.realtek.com.tw \
--to=pkshih@realtek.com \
--cc=abaci@linux.alibaba.com \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).