From: Johannes Berg <johannes@sipsolutions.net>
To: Jeff Johnson <quic_jjohnson@quicinc.com>,
Aditya Kumar Singh <quic_adisi@quicinc.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2 6/7] wifi: mac80211: add support to call color_change and OBSS collision on a link
Date: Tue, 23 Apr 2024 20:50:59 +0200 [thread overview]
Message-ID: <76b20f4054876cd70fb31e4b31c9653ccfe29a08.camel@sipsolutions.net> (raw)
In-Reply-To: <ca17a2f0-eb18-487a-8c5d-811748f2ca00@quicinc.com>
On Tue, 2024-04-23 at 11:46 -0700, Jeff Johnson wrote:
>
> Johannes, how do you feel about the new cleanup.h functionality? I ask because
> if we change this to just be:
>
> guard(rcu)();
>
> then we can remove all of the explicit rcu_read_unlock() calls --
> rcu_read_unlock() will be called automatically when the function goes out of
> scope.
Sounds like a good idea to me.
Jakub doesn't like it so much, see this thread:
https://lore.kernel.org/netdev/20240325223905.100979-5-johannes@sipsolutions.net/
But ultimately I don't think he'll stop us from doing it here,
especially if we use it carefully enough that we actually do need the
guard for the whole scope.
johannes
next prev parent reply other threads:[~2024-04-23 18:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 5:34 [PATCH v2 0/7] wifi: cfg80211/mac80211: add support for HE BSS color handling with Multi-Link Operation Aditya Kumar Singh
2024-04-22 5:34 ` [PATCH v2 1/7] wifi: cfg80211: send link id in color_change ops Aditya Kumar Singh
2024-04-22 5:34 ` [PATCH v2 2/7] wifi: cfg80211: notify link ID in bss_color_notify Aditya Kumar Singh
2024-04-22 5:34 ` [PATCH v2 3/7] wifi: mac80211: handle set color_change/after_color_change beacon on per link basis Aditya Kumar Singh
2024-04-22 5:34 ` [PATCH v2 4/7] wifi: mac80211: handle color_change_abort and bss_config_notify on per link Aditya Kumar Singh
2024-04-22 5:34 ` [PATCH v2 5/7] wifi: mac80211: start and finalize color change on link basis Aditya Kumar Singh
2024-04-22 5:34 ` [PATCH v2 6/7] wifi: mac80211: add support to call color_change and OBSS collision on a link Aditya Kumar Singh
2024-04-23 18:46 ` Jeff Johnson
2024-04-23 18:50 ` Johannes Berg [this message]
2024-04-22 5:34 ` [PATCH v2 7/7] wifi: mac80211_hwsim: add support for BSS color Aditya Kumar Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76b20f4054876cd70fb31e4b31c9653ccfe29a08.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_adisi@quicinc.com \
--cc=quic_jjohnson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).