* [PATCH] ath5k: fix RTS/CTS by using proper rate flags
@ 2015-11-19 15:04 Bob Copeland
2015-11-19 15:22 ` Felix Fietkau
2015-12-08 14:57 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Bob Copeland @ 2015-11-19 15:04 UTC (permalink / raw
To: linux-wireless; +Cc: Bob Copeland
The rates in the tx control rateset do not have the protection
flags applied, so RTS/CTS would never get enabled if requested.
Fix by using the rate flags in the rates returned by
ieee80211_get_tx_rates().
Signed-off-by: Bob Copeland <me@bobcopeland.com>
---
drivers/net/wireless/ath/ath5k/base.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net/wireless/ath/ath5k/base.c
index 342563a..3d946d8 100644
--- a/drivers/net/wireless/ath/ath5k/base.c
+++ b/drivers/net/wireless/ath/ath5k/base.c
@@ -767,7 +767,7 @@ ath5k_txbuf_setup(struct ath5k_hw *ah, struct ath5k_buf *bf,
if (info->flags & IEEE80211_TX_CTL_NO_ACK)
flags |= AR5K_TXDESC_NOACK;
- rc_flags = info->control.rates[0].flags;
+ rc_flags = bf->rates[0].flags;
hw_rate = ath5k_get_rate_hw_value(ah->hw, info, bf, 0);
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ath5k: fix RTS/CTS by using proper rate flags
2015-11-19 15:04 [PATCH] ath5k: fix RTS/CTS by using proper rate flags Bob Copeland
@ 2015-11-19 15:22 ` Felix Fietkau
2015-12-08 14:57 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Felix Fietkau @ 2015-11-19 15:22 UTC (permalink / raw
To: Bob Copeland, linux-wireless
On 2015-11-19 16:04, Bob Copeland wrote:
> The rates in the tx control rateset do not have the protection
> flags applied, so RTS/CTS would never get enabled if requested.
>
> Fix by using the rate flags in the rates returned by
> ieee80211_get_tx_rates().
>
> Signed-off-by: Bob Copeland <me@bobcopeland.com>
Acked-by: Felix Fietkau <nbd@openwrt.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ath5k: fix RTS/CTS by using proper rate flags
2015-11-19 15:04 [PATCH] ath5k: fix RTS/CTS by using proper rate flags Bob Copeland
2015-11-19 15:22 ` Felix Fietkau
@ 2015-12-08 14:57 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2015-12-08 14:57 UTC (permalink / raw
To: Bob Copeland; +Cc: linux-wireless
Bob Copeland <me@bobcopeland.com> writes:
> The rates in the tx control rateset do not have the protection
> flags applied, so RTS/CTS would never get enabled if requested.
>
> Fix by using the rate flags in the rates returned by
> ieee80211_get_tx_rates().
>
> Signed-off-by: Bob Copeland <me@bobcopeland.com>
Applied, thanks.
--
Kalle Valo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-12-08 14:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-19 15:04 [PATCH] ath5k: fix RTS/CTS by using proper rate flags Bob Copeland
2015-11-19 15:22 ` Felix Fietkau
2015-12-08 14:57 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).