From: Kalle Valo <kvalo@kernel.org>
To: Jeff Johnson <quic_jjohnson@quicinc.com>
Cc: Karthikeyan Kathirvel <quic_kathirve@quicinc.com>,
<ath12k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v4 2/2] wifi: ath12k: drop failed transmitted frames from metric calculation.
Date: Thu, 02 May 2024 13:39:59 +0300 [thread overview]
Message-ID: <87zft8o5ts.fsf@kernel.org> (raw)
In-Reply-To: <8a7823bb-dcee-4ddb-93e0-077371408014@quicinc.com> (Jeff Johnson's message of "Tue, 30 Apr 2024 10:50:00 -0700")
Jeff Johnson <quic_jjohnson@quicinc.com> writes:
> On 4/30/2024 12:43 AM, Karthikeyan Kathirvel wrote:
>> In mesh node traffic, internal firmware-transmitted failures are
>> reported as transmitted failures in mesh metric calculation, leading
>> to the breakage of the mesh link.
>>
>> Fix the issue by dropping the internal firmware-transmitted failures
>> before updating the TX completion status to mac80211, in order to
>> prevent false failure averaging in mesh metric calculation.
>>
>> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
>>
>> Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices")
>> Signed-off-by: Karthikeyan Kathirvel <quic_kathirve@quicinc.com>
> With one caveat noted below,
> Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>
>
> [...]
>> diff --git a/drivers/net/wireless/ath/ath12k/hal_desc.h b/drivers/net/wireless/ath/ath12k/hal_desc.h
>> index 63340256d3f6..71e8c8a091ae 100644
>> --- a/drivers/net/wireless/ath/ath12k/hal_desc.h
>> +++ b/drivers/net/wireless/ath/ath12k/hal_desc.h
>> @@ -1,7 +1,7 @@
>> /* SPDX-License-Identifier: BSD-3-Clause-Clear */
>> /*
>> * Copyright (c) 2018-2021 The Linux Foundation. All rights reserved.
>> - * Copyright (c) 2021-2022 Qualcomm Innovation Center, Inc. All rights reserved.
>> + * Copyright (c) 2021-2024 Qualcomm Innovation Center, Inc. All rights reserved.
>
> should be 2021-2022, 2024 per current guidance
>
> Kalle can probably fix this in the pending branch
Fixed to this:
--- a/drivers/net/wireless/ath/ath12k/hal_desc.h
+++ b/drivers/net/wireless/ath/ath12k/hal_desc.h
@@ -1,7 +1,7 @@
/* SPDX-License-Identifier: BSD-3-Clause-Clear */
/*
* Copyright (c) 2018-2021 The Linux Foundation. All rights reserved.
- * Copyright (c) 2021-2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2021-2022, 2024 Qualcomm Innovation Center, Inc. All rights reserved.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2024-05-02 10:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 7:43 [PATCH v4 0/2] wifi: ath12k: drop failed transmitted frames from metric calculation Karthikeyan Kathirvel
2024-04-30 7:43 ` [PATCH v4 1/2] wifi: ath12k: Don't drop tx_status in failure case Karthikeyan Kathirvel
2024-04-30 17:50 ` Jeff Johnson
2024-05-03 13:21 ` Kalle Valo
2024-04-30 7:43 ` [PATCH v4 2/2] wifi: ath12k: drop failed transmitted frames from metric calculation Karthikeyan Kathirvel
2024-04-30 17:50 ` Jeff Johnson
2024-05-02 10:39 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zft8o5ts.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=ath12k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_jjohnson@quicinc.com \
--cc=quic_kathirve@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).