From: Dan Carpenter <dan.carpenter@linaro.org>
To: "Alexis Lothoré" <alexis.lothore@bootlin.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [bug report] wifi: wilc1000: convert list management to RCU
Date: Tue, 14 May 2024 10:54:26 +0200 [thread overview]
Message-ID: <8ee9481f-7677-4a0e-be11-0c81d4bbef9f@suswa.mountain> (raw)
In-Reply-To: <1a982ba8-c5f3-415a-bb39-fae9973b100e@bootlin.com>
On Mon, May 13, 2024 at 04:16:05PM +0200, Alexis Lothoré wrote:
> Hello Dan,
> sorry for the late reply
>
> On 5/9/24 15:24, Dan Carpenter wrote:
> > Hello Alexis Lothoré,
> >
> > Commit f236464f1db7 ("wifi: wilc1000: convert list management to
> > RCU") from Apr 10, 2024 (linux-next), leads to the following Smatch
> > static checker warning:
> >
> > drivers/net/wireless/microchip/wilc1000/mon.c:236 wilc_wfi_init_mon_interface()
> > warn: sleeping in atomic context
>
> I am struggling to reproduce the warning in smatch. I executed those basic steps:
> - clone and build latest smatch
> - checkout linux-next master branch
> - export ARCH and CROSS_COMPILE
> - load a defconfig enabling all features in wilc driver
> - run ~/src/smatch/smatch_scripts/build_kernel_data.sh
> - then run ~/src/smatch/smatch_scripts/test_kernel.sh
> Yet I do no see any mention to wilc in the resulting smatch_warns.txt file. The
> outcome is the same if I run smatch only on the wilc driver:
> - ~/src/smatch/smatch_scripts/kchecker drivers/net/wireless/microchip/
>
> Am I missing something obvious ?
Yeah. I'm sorry, I need to write a blog entry about this. These checks
rely on the cross function database, and you need to rebuild it a bunch
of times. It's a simple process but very time consuming.
Instead of that, it's better to do run time testing using
CONFIG_DEBUG_ATOMIC_SLEEP=y
regards,
dan carpenter
next prev parent reply other threads:[~2024-05-14 8:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-09 13:24 [bug report] wifi: wilc1000: convert list management to RCU Dan Carpenter
2024-05-09 13:33 ` Dan Carpenter
2024-05-13 14:16 ` Alexis Lothoré
2024-05-14 8:54 ` Dan Carpenter [this message]
2024-05-14 8:59 ` Alexis Lothoré
2024-05-28 9:31 ` Alexis Lothoré
2024-05-28 9:44 ` Kalle Valo
2024-05-28 9:57 ` Alexis Lothoré
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ee9481f-7677-4a0e-be11-0c81d4bbef9f@suswa.mountain \
--to=dan.carpenter@linaro.org \
--cc=alexis.lothore@bootlin.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).