Linux-Wireless Archive mirror
 help / color / mirror / Atom feed
From: Mario Limonciello <superm1@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>, linux-firmware@kernel.org
Cc: linux-wireless@vger.kernel.org, miriam.rachel.korenblit@intel.com
Subject: Re: putting future iwlwifi firmware into intel/ ?
Date: Wed, 17 Apr 2024 09:14:41 -0500	[thread overview]
Message-ID: <9f0163ae-75bc-4a65-bc92-c9ae181ad83c@gmail.com> (raw)
In-Reply-To: <2278e0d1026ed336559adbc9ffbf6e945eba422e.camel@sipsolutions.net>



On 4/17/24 09:09, Johannes Berg wrote:
> On Wed, 2024-04-17 at 08:58 -0500, Mario Limonciello wrote:
>>>
>>> Yeah, I guess. Though not actually sure, do we need to support new
>>> kernel + old firmware install?
>>
>> I'd say you should.  Here's a few examples of why:
> 
> Right, agree.
> 
>> So yes; do the symlinks when you move directories.  It's one line in
>> WHENCE per file that you want a symlink.
>>
> 
> That doesn't achieve it though. It means the driver needs to try for the
> file in intel/ and then fall back without the intel/ if it's not found.
> 
> Or just look for new files in intel/ and old files without intel/, but
> then you don't really need the file move/symlinks?
> 
> johannes

It's probably easiest to look in intel/ and then fallback to the 
toplevel path if -ENOENT and try again.

Like Kalle mentioned, wait a few years and then tear out the fallback 
code and the symlink creation.

  reply	other threads:[~2024-04-17 14:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-17 11:18 putting future iwlwifi firmware into intel/ ? Johannes Berg
2024-04-17 12:31 ` Mario Limonciello
2024-04-17 12:39   ` Johannes Berg
2024-04-17 12:42     ` Mario Limonciello
2024-04-17 12:45       ` Johannes Berg
2024-04-17 13:58         ` Mario Limonciello
2024-04-17 14:09           ` Johannes Berg
2024-04-17 14:14             ` Mario Limonciello [this message]
2024-04-17 12:56 ` Kalle Valo
2024-04-17 14:11   ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9f0163ae-75bc-4a65-bc92-c9ae181ad83c@gmail.com \
    --to=superm1@gmail.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-firmware@kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=miriam.rachel.korenblit@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).