From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: Su Hui <suhui@nfschina.com>, <kvalo@kernel.org>,
<jjohnson@kernel.org>, <nathan@kernel.org>,
<ndesaulniers@google.com>, <morbo@google.com>,
<justinstitt@google.com>
Cc: <c_mkenna@qti.qualcomm.com>, <linux-wireless@vger.kernel.org>,
<ath10k@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
<llvm@lists.linux.dev>, <kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH wireless v2] wifi: ath10k: Fix an error code problem in ath10k_dbg_sta_write_peer_debug_trigger()
Date: Mon, 22 Apr 2024 09:21:01 -0700 [thread overview]
Message-ID: <9fc9866b-b2fb-40ee-97ea-0e819f05dc15@quicinc.com> (raw)
In-Reply-To: <20240422034243.938962-1-suhui@nfschina.com>
On 4/21/2024 8:42 PM, Su Hui wrote:
> Clang Static Checker (scan-build) Warning:
> drivers/net/wireless/ath/ath10k/debugfs_sta.c:line 429, column 3
> Value stored to 'ret' is never read.
>
> Return 'ret' rather than 'count' when 'ret' stores an error code.
> By the way, remove some useless code.
>
> Fixes: ee8b08a1be82 ("ath10k: add debugfs support to get per peer tids log via tracing")
> Signed-off-by: Su Hui <suhui@nfschina.com>Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>
next prev parent reply other threads:[~2024-04-22 16:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 3:42 [PATCH wireless v2] wifi: ath10k: Fix an error code problem in ath10k_dbg_sta_write_peer_debug_trigger() Su Hui
2024-04-22 6:53 ` Kalle Valo
2024-04-23 1:21 ` Su Hui
2024-04-22 16:21 ` Jeff Johnson [this message]
2024-04-22 16:23 ` Jeff Johnson
2024-04-24 15:40 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9fc9866b-b2fb-40ee-97ea-0e819f05dc15@quicinc.com \
--to=quic_jjohnson@quicinc.com \
--cc=ath10k@lists.infradead.org \
--cc=c_mkenna@qti.qualcomm.com \
--cc=jjohnson@kernel.org \
--cc=justinstitt@google.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=suhui@nfschina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).