From: David Lin <yu-hao.lin@nxp.com>
To: Francesco Dolcini <francesco@dolcini.it>
Cc: Brian Norris <briannorris@chromium.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kvalo@kernel.org" <kvalo@kernel.org>,
Pete Hsieh <tsung-hsien.hsieh@nxp.com>,
Francesco Dolcini <francesco.dolcini@toradex.com>
Subject: RE: [EXT] Re: [PATCH v9 1/2] wifi: mwifiex: add host mlme for client mode
Date: Tue, 19 Mar 2024 01:36:01 +0000 [thread overview]
Message-ID: <PA4PR04MB9638742AA1748A9EA7371FBDD12C2@PA4PR04MB9638.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20240318114131.GB9565@francesco-nb>
> From: Francesco Dolcini <francesco@dolcini.it>
> Sent: Monday, March 18, 2024 7:42 PM
> To: David Lin <yu-hao.lin@nxp.com>
> Cc: Brian Norris <briannorris@chromium.org>; linux-wireless@vger.kernel.org;
> linux-kernel@vger.kernel.org; kvalo@kernel.org; francesco@dolcini.it; Pete
> Hsieh <tsung-hsien.hsieh@nxp.com>; Francesco Dolcini
> <francesco.dolcini@toradex.com>
> Subject: [EXT] Re: [PATCH v9 1/2] wifi: mwifiex: add host mlme for client mode
>
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
>
>
> Hello David,
>
> On Mon, Mar 18, 2024 at 02:00:35AM +0000, David Lin wrote:
> > > From: Brian Norris <briannorris@chromium.org>
> ...
> > > > .../net/wireless/marvell/mwifiex/sta_ioctl.c | 2 +-
> > > > drivers/net/wireless/marvell/mwifiex/sta_tx.c | 9 +-
> > > > drivers/net/wireless/marvell/mwifiex/util.c | 80 +++++
> > > > 15 files changed, 671 insertions(+), 14 deletions(-)
> > >
> > > (Per the above, I'd normally consider whether ~671 new lines is
> > > worth splitting into multiple patches. But I don't see any great
> > > logical ways to do that.)
> > Francesco suggested to use two patches for this host mlme new feature
> > from previous many patches. I knew it is a lot of changes, but I think
> > it should be the best way to add host mlme with two patches (one for
> > client and one for AP).
>
> What I explicitly asked was to not add code in a patch, and fix the newly added
> code in a following patch. What you are supposed to do is to just amend the
> original code when you get review feedback.
>
Yes. I will do that for patch v10 and keep all 'Review-by:' and 'Tested-by:' tags.
> Splitting a big patch into multiple patches is welcome to easier review, and this
> needs to be done breaking down in logical pieces keeping in mind also
> bisect-ability.
>
> This [1] is an example of the addition of a relatively big new driver, and you
> can see that the series is broken down in smaller patches like "Add skeleton
> PowerVR driver", with intermediate steps that were non-functional, but they
> were building fine, they were correct and they were enabling more effective
> code review.
>
> Unfortunately, as Brian agreed here, there was no easy way to do it for this
> patch.
>
> Francesco
>
> [1]
> https://lore.kern/
> el.org%2Fall%2Fcover.1700668843.git.donald.robson%40imgtec.com%2F&data
> =05%7C02%7Cyu-hao.lin%40nxp.com%7C6ce04f812a5b4dd7e74908dc47405cc
> 7%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6384635889617189
> 65%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiL
> CJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=HPgEuiKfmtEicp
> PfTz57piOdOoT0iQfo5qnPp9p6jlY%3D&reserved=0
next prev parent reply other threads:[~2024-03-19 1:36 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 2:00 [PATCH v9 0/2] wifi: mwifiex: add code to support host mlme David Lin
2024-03-06 2:00 ` [PATCH v9 1/2] wifi: mwifiex: add host mlme for client mode David Lin
2024-03-16 0:00 ` Brian Norris
2024-03-18 2:00 ` [EXT] " David Lin
2024-03-18 11:41 ` Francesco Dolcini
2024-03-19 1:36 ` David Lin [this message]
2024-03-06 2:00 ` [PATCH v9 2/2] wifi: mwifiex: add host mlme for AP mode David Lin
2024-03-16 0:45 ` Brian Norris
2024-03-18 2:04 ` [EXT] " David Lin
2024-04-18 3:37 ` David Lin
2024-03-15 9:49 ` [PATCH v9 0/2] wifi: mwifiex: add code to support host mlme Francesco Dolcini
2024-03-15 23:59 ` Brian Norris
2024-03-18 11:28 ` Francesco Dolcini
2024-03-19 10:33 ` Kalle Valo
2024-03-20 21:06 ` Brian Norris
2024-03-16 0:49 ` Brian Norris
2024-03-19 12:12 ` Johannes Berg
2024-03-20 0:59 ` [EXT] " David Lin
2024-03-20 1:10 ` David Lin
2024-03-20 9:12 ` Johannes Berg
2024-03-20 21:50 ` Brian Norris
2024-03-21 4:07 ` David Lin
2024-03-23 1:06 ` Brian Norris
2024-03-25 16:15 ` Johannes Berg
2024-03-29 10:06 ` David Lin
2024-04-02 17:38 ` Brian Norris
2024-04-10 7:30 ` David Lin
2024-04-10 7:55 ` Johannes Berg
2024-04-10 10:33 ` David Lin
2024-04-10 17:56 ` Johannes Berg
2024-04-11 7:57 ` David Lin
2024-04-11 8:02 ` Johannes Berg
2024-04-10 7:52 ` Johannes Berg
2024-03-25 15:58 ` Johannes Berg
2024-03-29 9:58 ` David Lin
2024-03-18 9:24 ` Kalle Valo
2024-03-19 1:40 ` [EXT] " David Lin
2024-03-20 21:28 ` Brian Norris
2024-03-21 2:14 ` [EXT] " David Lin
2024-03-16 0:07 ` Brian Norris
2024-03-18 2:20 ` [EXT] " David Lin
2024-03-18 11:45 ` Francesco Dolcini
2024-03-20 21:13 ` Brian Norris
2024-03-21 2:12 ` David Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PA4PR04MB9638742AA1748A9EA7371FBDD12C2@PA4PR04MB9638.eurprd04.prod.outlook.com \
--to=yu-hao.lin@nxp.com \
--cc=briannorris@chromium.org \
--cc=francesco.dolcini@toradex.com \
--cc=francesco@dolcini.it \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=tsung-hsien.hsieh@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).