From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Ricardo Martinez <ricardo.martinez@linux.intel.com>,
Arnd Bergmann <arnd@arndb.de>,
Matt Wagantall <mattw@codeaurora.org>,
Mitchel Humpherys <mitchelh@codeaurora.org>
Cc: netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
kuba@kernel.org, davem@davemloft.net, johannes@sipsolutions.net,
ryazanov.s.a@gmail.com, loic.poulain@linaro.org,
m.chetan.kumar@intel.com, chandrashekar.devegowda@intel.com,
linuxwwan@intel.com, chiranjeevi.rapolu@linux.intel.com,
haijun.liu@mediatek.com, amir.hanania@intel.com,
dinesh.sharma@intel.com, eliot.lee@intel.com,
mika.westerberg@linux.intel.com, moises.veleta@intel.com,
pierre-louis.bossart@intel.com,
muralidharan.sethuraman@intel.com,
Soumya.Prakash.Mishra@intel.com, sreehari.kancharla@intel.com,
suresh.nagaraj@intel.com
Subject: Re: [PATCH net-next v3 06/12] net: wwan: t7xx: Data path HW layer
Date: Tue, 7 Dec 2021 14:04:31 +0200 [thread overview]
Message-ID: <Ya9Nz8U+i3r56H5h@smile.fi.intel.com> (raw)
In-Reply-To: <Ya9MlTpZ8Var/JMy@smile.fi.intel.com>
+Cc: people from "[PATCH v7 1/2] iopoll: Introduce memory-mapped IO polling macros"
Any idea why ioreadXX() doomed between v7 and v10 of that series?
Any further work is going on?
On Tue, Dec 07, 2021 at 01:59:18PM +0200, Andy Shevchenko wrote:
> On Mon, Dec 06, 2021 at 07:47:05PM -0700, Ricardo Martinez wrote:
> > From: Haijun Liu <haijun.liu@mediatek.com>
> >
> > Data Path Modem AP Interface (DPMAIF) HW layer provides HW abstraction
> > for the upper layer (DPMAIF HIF). It implements functions to do the HW
> > configuration, TX/RX control and interrupt handling.
>
> ...
>
> > + ret = readx_poll_timeout_atomic(ioread32, hw_info->pcie_base + DPMAIF_AO_UL_AP_L2TIMR0,
> > + value, (value & ul_intr_enable) != ul_intr_enable, 0,
> > + DPMAIF_CHECK_INIT_TIMEOUT_US);
> > + if (ret)
> > + return ret;
>
> ...
>
> > + ret = readx_poll_timeout_atomic(ioread32, hw_info->pcie_base + DPMAIF_AO_UL_APDL_L2TIMR0,
> > + value, (value & ul_intr_enable) != ul_intr_enable, 0,
> > + DPMAIF_CHECK_INIT_TIMEOUT_US);
> > + if (ret)
> > + return ret;
>
> ...
>
> > + ret = readx_poll_timeout_atomic(ioread32, hw_info->pcie_base + DPMAIF_AO_UL_AP_L2TIMR0,
> > + value, (value & ul_int_que_done) == ul_int_que_done, 0,
> > + DPMAIF_CHECK_TIMEOUT_US);
> > + if (ret)
> > + dev_err(dpmaif_ctrl->dev,
> > + "Could not mask the UL interrupt. DPMAIF_AO_UL_AP_L2TIMR0 is 0x%x\n",
> > + value);
>
> I would recommend to add a small patch that extends iopoll.h by ioreadXX() variants.
>
> Or as alternative just define it here at the top of the file (or in one of the
> header if it's used more than in one module) so we may move it to the iopoll.h
> in the future:
>
>
> #define ioread32_poll_timeout_atomic(addr, val, cond, delay_us, timeout_us) \
> readx_poll_timeout_atomic(ioread32, addr, val, cond, delay_us, timeout_us)
>
>
> --
> With Best Regards,
> Andy Shevchenko
>
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-12-07 12:05 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-07 2:46 [PATCH net-next v3 00/12] net: wwan: t7xx: PCIe driver for MediaTek M.2 modem Ricardo Martinez
2021-12-07 2:47 ` [PATCH net-next v3 01/12] net: wwan: t7xx: Add control DMA interface Ricardo Martinez
2021-12-07 17:11 ` Jakub Kicinski
2021-12-16 11:08 ` Ilpo Järvinen
2022-01-12 4:55 ` Martinez, Ricardo
2022-01-12 11:40 ` Andy Shevchenko
2022-01-12 14:24 ` Ilpo Järvinen
2022-01-12 16:20 ` Andy Shevchenko
2022-01-12 18:16 ` Ilpo Järvinen
2022-01-12 19:03 ` Martinez, Ricardo
2022-01-12 19:24 ` Ilpo Järvinen
2022-01-12 20:08 ` Martinez, Ricardo
2022-01-13 18:31 ` Ilpo Järvinen
2021-12-07 2:47 ` [PATCH net-next v3 02/12] net: wwan: t7xx: Add core components Ricardo Martinez
2021-12-16 11:55 ` Ilpo Järvinen
2022-01-12 21:58 ` Martinez, Ricardo
2021-12-07 2:47 ` [PATCH net-next v3 03/12] net: wwan: t7xx: Add port proxy infrastructure Ricardo Martinez
2021-12-16 12:17 ` Ilpo Järvinen
2021-12-07 2:47 ` [PATCH net-next v3 04/12] net: wwan: t7xx: Add control port Ricardo Martinez
2021-12-16 13:44 ` Ilpo Järvinen
2021-12-07 2:47 ` [PATCH net-next v3 05/12] net: wwan: t7xx: Add AT and MBIM WWAN ports Ricardo Martinez
2021-12-07 9:48 ` Loic Poulain
2021-12-16 12:25 ` Ilpo Järvinen
2021-12-16 12:59 ` Andy Shevchenko
2021-12-07 2:47 ` [PATCH net-next v3 06/12] net: wwan: t7xx: Data path HW layer Ricardo Martinez
2021-12-07 11:59 ` Andy Shevchenko
2021-12-07 12:04 ` Andy Shevchenko [this message]
2021-12-07 2:47 ` [PATCH net-next v3 07/12] net: wwan: t7xx: Add data path interface Ricardo Martinez
2021-12-16 13:30 ` Ilpo Järvinen
2022-01-12 23:27 ` Martinez, Ricardo
2021-12-07 2:47 ` [PATCH net-next v3 08/12] net: wwan: t7xx: Add WWAN network interface Ricardo Martinez
2021-12-07 2:47 ` [PATCH net-next v3 09/12] net: wwan: t7xx: Introduce power management support Ricardo Martinez
2021-12-07 2:47 ` [PATCH net-next v3 10/12] net: wwan: t7xx: Runtime PM Ricardo Martinez
2021-12-07 2:47 ` [PATCH net-next v3 11/12] net: wwan: t7xx: Device deep sleep lock/unlock Ricardo Martinez
2021-12-07 2:47 ` [PATCH net-next v3 12/12] net: wwan: t7xx: Add maintainers and documentation Ricardo Martinez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ya9Nz8U+i3r56H5h@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Soumya.Prakash.Mishra@intel.com \
--cc=amir.hanania@intel.com \
--cc=arnd@arndb.de \
--cc=chandrashekar.devegowda@intel.com \
--cc=chiranjeevi.rapolu@linux.intel.com \
--cc=davem@davemloft.net \
--cc=dinesh.sharma@intel.com \
--cc=eliot.lee@intel.com \
--cc=haijun.liu@mediatek.com \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxwwan@intel.com \
--cc=loic.poulain@linaro.org \
--cc=m.chetan.kumar@intel.com \
--cc=mattw@codeaurora.org \
--cc=mika.westerberg@linux.intel.com \
--cc=mitchelh@codeaurora.org \
--cc=moises.veleta@intel.com \
--cc=muralidharan.sethuraman@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pierre-louis.bossart@intel.com \
--cc=ricardo.martinez@linux.intel.com \
--cc=ryazanov.s.a@gmail.com \
--cc=sreehari.kancharla@intel.com \
--cc=suresh.nagaraj@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).