From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: Karthikeyan Kathirvel <quic_kathirve@quicinc.com>,
<ath12k@lists.infradead.org>
Cc: <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] ath12k: fix out-of-bound access of qmi_invoke_handler()
Date: Mon, 15 Apr 2024 11:20:57 -0700 [thread overview]
Message-ID: <a01e2408-6016-44ff-aadb-13471a43c6c5@quicinc.com> (raw)
In-Reply-To: <20240415171323.2484291-1-quic_kathirve@quicinc.com>
On 4/15/2024 10:13 AM, Karthikeyan Kathirvel wrote:
> Currently, there is no terminator entry for ath12k_qmi_msg_handlers hence
> facing below KASAN warning,
>
> ==================================================================
> BUG: KASAN: global-out-of-bounds in qmi_invoke_handler+0xa4/0x148
> Read of size 8 at addr ffffffd00a6428d8 by task kworker/u8:2/1273
>
> CPU: 0 PID: 1273 Comm: kworker/u8:2 Not tainted 5.4.213 #0
> Workqueue: qmi_msg_handler qmi_data_ready_work
> Call trace:
> dump_backtrace+0x0/0x20c
> show_stack+0x14/0x1c
> dump_stack+0xe0/0x138
> print_address_description.isra.5+0x30/0x330
> __kasan_report+0x16c/0x1bc
> kasan_report+0xc/0x14
> __asan_load8+0xa8/0xb0
> qmi_invoke_handler+0xa4/0x148
> qmi_handle_message+0x18c/0x1bc
> qmi_data_ready_work+0x4ec/0x528
> process_one_work+0x2c0/0x440
> worker_thread+0x324/0x4b8
> kthread+0x210/0x228
> ret_from_fork+0x10/0x18
>
> The address belongs to the variable:
> ath12k_mac_mon_status_filter_default+0x4bd8/0xfffffffffffe2300 [ath12k]
> [...]
> ==================================================================
>
> Add a dummy terminator entry at the end to assist the qmi_invoke_handler()
> in traversing up to the terminator entry without accessing an
> out-of-boundary index.
>
> Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices")
> Signed-off-by: Karthikeyan Kathirvel <quic_kathirve@quicinc.com>
Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>
prev parent reply other threads:[~2024-04-15 18:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 17:13 [PATCH] ath12k: fix out-of-bound access of qmi_invoke_handler() Karthikeyan Kathirvel
2024-04-15 18:20 ` Jeff Johnson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a01e2408-6016-44ff-aadb-13471a43c6c5@quicinc.com \
--to=quic_jjohnson@quicinc.com \
--cc=ath12k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_kathirve@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).