From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64ED428FC for ; Thu, 2 May 2024 16:45:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714668328; cv=none; b=t8ZEKrCEaULwIEjy6mgcoXoYUlfz925b9YxZjp7RS4fYu4c9Y1OECEA7+Jl/Fis8YzPneJUh4oZTxF58VCi4ar/8TkhuBphgIB0RN5nByuQ/4Rl1Z+AHPzJXmttnBlBOSoQLW6USTwTLt5V5OtWhbQ3nNpSUfIA+yno6vPHeDsI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714668328; c=relaxed/simple; bh=aJ4YHP7Kw4ye4gDkt68dY1VDopWj01qnWci2UTjMe+8=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=DFtJXhIHp/xDLBVP6Yia98c6pxZ/OvxG865ylSSG9kM2klUrO7agIT4fU+4suBslKKBQdvULRYk6H/+kFoB5AwxFp794Fg5lQKl7/Xbp0AHMTEGxYfHc10ohjeHwJbOcqmgSW8FVTdBvQpc07v4vP1yY4eZRMNHYu+4D3Bd2kMc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=cnUMJNR6; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="cnUMJNR6" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 442Fsr57022735; Thu, 2 May 2024 16:45:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= qcppdkim1; bh=pJXJQMuOdiarbyL2e/unM5fhQaATDSOvWOg7yDBrtzY=; b=cn UMJNR6uQUXcDg+5WCS16TQn0WMmz2/j/+lTP/mIM/LhODuMOb2JOo5zegoDxfkzy V4GNB4KRRlOaIo3RFZo85WEpdUdGhQwqjdyxt2OY61AEihodACvCyDjlCZbSAakX hUG15oY78yvIshCooqIPwItEdsHqCJB8sr6bPMGPHNIVlbrMCtzIK6805WcLUAJQ RfjhcV7SmsMjS7KFrr5JV8FSXHXQxKsh9BJ0SA0+VHnrzQHlqTcn2j09NsmZ1fRX k59peE9eMozgIoFvYnC+VgSCAUbC8C7Cuu1UxUle7knMT8vvbhVQhTBIoGRBFraM 2Z7h1z1mGbd+3yAYUZgw== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3xv7pxh0kj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 02 May 2024 16:45:10 +0000 (GMT) Received: from nalasex01b.na.qualcomm.com (nalasex01b.na.qualcomm.com [10.47.209.197]) by NALASPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 442Gj6Wv025134 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 2 May 2024 16:45:06 GMT Received: from [10.227.89.240] (10.80.80.8) by nalasex01b.na.qualcomm.com (10.47.209.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Thu, 2 May 2024 09:45:05 -0700 Message-ID: Date: Thu, 2 May 2024 09:45:05 -0700 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] wifi: mac80211: Update bssid indicator with real BSS numbers To: Johannes Berg , =?UTF-8?B?QWxsZW4gWWUgKOiRieiKt+WLsyk=?= , "linux-wireless@vger.kernel.org" , "lorenzo@kernel.org" CC: "lorenzo.bianconi@redhat.com" , "nbd@nbd.name" , =?UTF-8?B?RXZlbHluIFRzYWkgKOiUoeePiumIuik=?= , =?UTF-8?B?TW9uZXkgV2FuZyAo546L5L+h5a6JKQ==?= , "linux-mediatek@lists.infradead.org" References: <20231208063820.25983-1-allen.ye@mediatek.com> <65d21336e8f7e180352403a3e894aeaf27a22cab.camel@sipsolutions.net> <757f417d63a750e84ab883b500becc2773e9ff17.camel@sipsolutions.net> Content-Language: en-US From: Aloka Dixit In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01b.na.qualcomm.com (10.47.209.197) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: Cc96HrOslscHqjv_rey_h5jYv-z9wX2c X-Proofpoint-ORIG-GUID: Cc96HrOslscHqjv_rey_h5jYv-z9wX2c X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.650,FMLib:17.11.176.26 definitions=2024-05-02_08,2024-05-02_03,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1011 adultscore=0 suspectscore=0 mlxlogscore=715 phishscore=0 lowpriorityscore=0 mlxscore=0 bulkscore=0 spamscore=0 malwarescore=0 impostorscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2404010003 definitions=main-2405020110 On 4/23/2024 4:28 AM, Johannes Berg wrote: > On Tue, 2024-04-23 at 13:21 +0200, Johannes Berg wrote: >> >> Anyway, I think I agree, but can you please add some validation of this >> to cfg80211 as a first patch > > I guess I should say what kind of validation? I think it'd make sense to > ensure that the elements even exist/are long enough (currently there's > no validation in nl80211_parse_mbssid_elems at all!!), perhaps call > validate_ie_attr() there as well. > > Feels like something should also ensure that not only is > > config->index < wiphy->mbssid_max_interfaces > > but also actually < 2^max_bssid_indicator? > > johannes > I agree with the validation concerns. But the actual logic in this patch is valid, although considering we have had this code for so many years now, feels like no driver/target actually needs this field yet even though it is used :-)