From: Paul Geurts <paul_geurts@live.nl>
To: Krzysztof Kozlowski <krzk@kernel.org>,
"mgreer@animalcreek.com" <mgreer@animalcreek.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"robh@kernel.org" <robh@kernel.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: net/nfc: ti,trf7970a: Add rx-gain-reduction option
Date: Fri, 19 Apr 2024 07:30:56 +0000 [thread overview]
Message-ID: <acf1679f-4ee8-4b87-a793-0160affc4b64@live.nl> (raw)
In-Reply-To: <150d467e-3ea6-40fb-8ddf-21d678b150d1@kernel.org>
On 17-04-2024 15:12, Krzysztof Kozlowski wrote:
> On 17/04/2024 00:18, Paul Geurts wrote:
>> Add option to reduce the RX antenna gain to be able to reduce the
>> sensitivity.
>>
>> Signed-off-by: Paul Geurts <paul_geurts@live.nl>
>> ---
>> Documentation/devicetree/bindings/net/nfc/ti,trf7970a.yaml | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/net/nfc/ti,trf7970a.yaml b/Documentation/devicetree/bindings/net/nfc/ti,trf7970a.yaml
>> index d0332eb76ad2..bbd045f6cf04 100644
>> --- a/Documentation/devicetree/bindings/net/nfc/ti,trf7970a.yaml
>> +++ b/Documentation/devicetree/bindings/net/nfc/ti,trf7970a.yaml
>> @@ -55,6 +55,11 @@ properties:
>> description: |
>> Regulator for supply voltage to VIN pin
>>
>> + rx-gain-reduction:
> Missing vendor prefix.
>
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> + description: |
> Do not need '|' unless you need to preserve formatting.
>
>> + Specify a RX gain reduction to reduce antenna sensitivity.
> Reduction by what? What are the units?
Yes, this is a bit unclear indeed. Will clarify this.
>
>
> Best regards,
> Krzysztof
Thanks!
br,
Paul
next prev parent reply other threads:[~2024-04-19 7:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1713305374.git.paul_geurts@live.nl>
2024-04-16 22:18 ` [PATCH 1/2] dt-bindings: net/nfc: ti,trf7970a: Add rx-gain-reduction option Paul Geurts
2024-04-17 13:12 ` Krzysztof Kozlowski
2024-04-19 7:30 ` Paul Geurts [this message]
2024-04-16 22:18 ` [PATCH 2/2] NFC: trf7970a: Create device-tree parameter for RX gain reduction Paul Geurts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acf1679f-4ee8-4b87-a793-0160affc4b64@live.nl \
--to=paul_geurts@live.nl \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzk@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mgreer@animalcreek.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).