From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: Rameshkumar Sundaram <quic_ramess@quicinc.com>,
<ath12k@lists.infradead.org>
Cc: <linux-wireless@vger.kernel.org>, Sriram R <quic_srirrama@quicinc.com>
Subject: Re: [PATCH 3/3] wifi: ath12k: prepare sta data structure for MLO handling
Date: Tue, 23 Apr 2024 13:30:34 -0700 [thread overview]
Message-ID: <ae05d969-399a-47ce-99cc-40a9f77cff6b@quicinc.com> (raw)
In-Reply-To: <20240422125630.1469456-4-quic_ramess@quicinc.com>
On 4/22/2024 5:56 AM, Rameshkumar Sundaram wrote:
> From: Sriram R <quic_srirrama@quicinc.com>
>
> To prepare the driver for MLO support, split the driver sta
> data structure to scale for multiple links. This requires changing
> the use of arsta to per link and not per hw which can now
> comprise of multiple links.
> Also since most configurations from mac80211 are done per link,
> do refactoring of the driver functions to apply these configurations
> at link level.
>
> Split ath12k_sta which is the driver private of ieee80211_sta to store
> link specific information as ath12k_link_sta. For default use cases
> the ath12k_sta will have a preallocated link sta called deflink which will
> be used by non ML STAs and the first link sta of ML STA.
>
> With MLO Support to be added, remaining link stas will allocated during
> state change where new STA is added. These link stas will be freed when
> STA is deleted.
>
> Current ath12k_sta(arsta) structure
>
> +-----------------+ +----------------+
> | | | |
> | ieee80211_sta | | ieee80211_sta |
> | private data | | private data |
> | | | |
> | ath12k_sta | | ath12k_sta |
> | (arsta) | | (arsta) |
> |+---------------+| | +-------------+|
> || *arvif (link || | |*arvif (link ||
> || vif of an ar || | | vif of an ar||
> || say 5GHz) || | | say 6GHz) ||
> |+---------------+| | +-------------+|
> +-----------------+ +----------------+
>
> Proposed ath12k_sta(ahsta) containing ath12k_link_sta(s) (arsta)
> (deflink is preallocated member which is always the first link if
> ieee80211_sta is ML STA and is the only link sta otherwise)
>
> +---------------------------------------+
> | ieee80211_sta |
> | private data |
> | |
> | ath12k_sta (ahsta) |
> | +-------------------------------------+
> | | ath12k_link_sta deflink (arsta) |
> | | |
> | | *arvif (link vif of ar (5GHz)) |
> | +-------------------------------------+
> | +-------------------------------------+
> | | ath12k_link_sta *link (arsta) |
> | | |
> | | *arvif (link vif of ar (6GHz)) |
> | | |
> | +-------------------------------------+
> | |
> +---------------------------------------+
>
> To refactor existing ath12k_sta to make use of link stas, following
> changes are made,
>
> 1. Limit ieee80211_sta argument mac80211 ops unless otherwise really required.
>
> 2. ath12k_sta now called by variable name arsta stores multiple
> arstas(ah12k_link_sta) and also has a back pointer to ath12k_sta
>
> 3. Pass ath12k_link_sta to mac functions that passed ieee80211_sta arg
> and fetch ath12k_sta(ahsta) and sta(ieee80211_sta) internally.
> This is done to avoid passing link id in all the functions and performing
> validation across these functions.
> Rather the validation and sta to arsta conversion can be done only at the
> mac80211 ops.
>
> 4. In this patchset, only ahsta->deflink is used to be on par with the
> existing code. When MLO support is added the link id will be used to fetch
> the arsta.
>
> 5. Change ath12k_sta_to_arsta() to ath12k_vif_to_ahsta() to fetch the
> ML level sta. The link sta can be fetched from ahsta->link[], or the
> deflink can be accessed via ahsta->deflink. API to access link
> sta (arsta) by passing link_id can be introduced with MLO Support.
>
> 6. The ieee80211_sta can be accessed from ahsta using ath12k_sta_to_sta()
>
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3
>
> Signed-off-by: Sriram R <quic_srirrama@quicinc.com>
> Co-developed-by: Rameshkumar Sundaram <quic_ramess@quicinc.com>
> Signed-off-by: Rameshkumar Sundaram <quic_ramess@quicinc.com>
Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>
prev parent reply other threads:[~2024-04-23 20:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 12:56 [PATCH 0/3] wifi: ath12k: prepare vif and sta datastructure Rameshkumar Sundaram
2024-04-22 12:56 ` [PATCH 1/3] wifi: ath12k: prepare vif data structure for MLO handling Rameshkumar Sundaram
2024-04-23 20:30 ` Jeff Johnson
2024-04-22 12:56 ` [PATCH 2/3] wifi: ath12k: pass ath12k_link_vif instead of vif/ahvif Rameshkumar Sundaram
2024-04-23 20:30 ` Jeff Johnson
2024-04-22 12:56 ` [PATCH 3/3] wifi: ath12k: prepare sta data structure for MLO handling Rameshkumar Sundaram
2024-04-23 20:30 ` Jeff Johnson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae05d969-399a-47ce-99cc-40a9f77cff6b@quicinc.com \
--to=quic_jjohnson@quicinc.com \
--cc=ath12k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_ramess@quicinc.com \
--cc=quic_srirrama@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).