* Can ath11k automatically enable CRYPTO_MICHAEL_MIC?
@ 2023-11-08 14:33 James Prestwood
2023-11-08 14:39 ` Jeff Johnson
0 siblings, 1 reply; 3+ messages in thread
From: James Prestwood @ 2023-11-08 14:33 UTC (permalink / raw
To: linux-wireless
Hi,
I'm not very familiar with how the Kconfig stuff works, but I spent
longer than I care to admit trying to get the ath11k support to show up
in menuconfig.
The issue was CONFIG_CRYPT_MICHAEL_MIC was not set, which removed the
ath11k driver from menuconfig because of:
depends on CRYPTO_MICHAEL_MIC
Maybe there was a good reason (again, I don't know much about Kconfig),
but should/could this use "select" to automatically enable
CRYPTO_MICHAEL_MIC?
Thanks,
James
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Can ath11k automatically enable CRYPTO_MICHAEL_MIC?
2023-11-08 14:33 Can ath11k automatically enable CRYPTO_MICHAEL_MIC? James Prestwood
@ 2023-11-08 14:39 ` Jeff Johnson
2023-11-13 15:11 ` Kalle Valo
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Johnson @ 2023-11-08 14:39 UTC (permalink / raw
To: James Prestwood, linux-wireless, ath11k@lists.infradead.org
On 11/8/2023 6:33 AM, James Prestwood wrote:
> Hi,
>
> I'm not very familiar with how the Kconfig stuff works, but I spent
> longer than I care to admit trying to get the ath11k support to show up
> in menuconfig.
>
> The issue was CONFIG_CRYPT_MICHAEL_MIC was not set, which removed the
> ath11k driver from menuconfig because of:
>
> depends on CRYPTO_MICHAEL_MIC
>
> Maybe there was a good reason (again, I don't know much about Kconfig),
> but should/could this use "select" to automatically enable
> CRYPTO_MICHAEL_MIC?
>
> Thanks,
> James
+ ath11k list to see if there is any history on this topic
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Can ath11k automatically enable CRYPTO_MICHAEL_MIC?
2023-11-08 14:39 ` Jeff Johnson
@ 2023-11-13 15:11 ` Kalle Valo
0 siblings, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2023-11-13 15:11 UTC (permalink / raw
To: Jeff Johnson; +Cc: James Prestwood, linux-wireless, ath11k@lists.infradead.org
Jeff Johnson <quic_jjohnson@quicinc.com> writes:
> On 11/8/2023 6:33 AM, James Prestwood wrote:
>> Hi,
>> I'm not very familiar with how the Kconfig stuff works, but I spent
>> longer than I care to admit trying to get the ath11k support to show
>> up in menuconfig.
>> The issue was CONFIG_CRYPT_MICHAEL_MIC was not set, which removed
>> the ath11k driver from menuconfig because of:
>> depends on CRYPTO_MICHAEL_MIC
>> Maybe there was a good reason (again, I don't know much about
>> Kconfig), but should/could this use "select" to automatically enable
>> CRYPTO_MICHAEL_MIC?
>> Thanks,
>> James
>
> + ath11k list to see if there is any history on this topic
I checked the history and this dependency was added by commit
243874c64c81 ("ath11k: handle RX fragments") back in 2020, the commit
message doesn't specify why 'depends on' was used instead of 'select'.
Further investigation shows that ath11k and ath12k are the only who use
'depends on' with CRYPTO_MICHAEL_MIC:
./drivers/net/wireless/intel/ipw2x00/Kconfig: select CRYPTO_MICHAEL_MIC
./drivers/net/wireless/intersil/hostap/Kconfig: select CRYPTO_MICHAEL_MIC
./drivers/net/wireless/intersil/orinoco/Kconfig: select CRYPTO_MICHAEL_MIC
./drivers/net/wireless/ath/ath11k/Kconfig: depends on CRYPTO_MICHAEL_MIC
./drivers/net/wireless/ath/ath12k/Kconfig: depends on CRYPTO_MICHAEL_MIC
./drivers/staging/rtl8192e/Kconfig: select CRYPTO_MICHAEL_MIC
./drivers/staging/ks7010/Kconfig: select CRYPTO_MICHAEL_MIC
So switching ath11k and ath12k to use 'select' should be the best thing
to do. Patches welcome :)
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-13 15:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-08 14:33 Can ath11k automatically enable CRYPTO_MICHAEL_MIC? James Prestwood
2023-11-08 14:39 ` Jeff Johnson
2023-11-13 15:11 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).