From: Johannes Berg <johannes@sipsolutions.net>
To: Aloka Dixit <alokad@codeaurora.org>, linux-wireless@vger.kernel.org
Subject: Re: [v13 3/3] mac80211: MBSSID channel switch
Date: Fri, 26 Nov 2021 12:16:07 +0100 [thread overview]
Message-ID: <cce18c617b2a1860ebab329fb1f9077cd1399ec4.camel@sipsolutions.net> (raw)
In-Reply-To: <20211006040938.9531-4-alokad@codeaurora.org>
On Tue, 2021-10-05 at 21:09 -0700, Aloka Dixit wrote:
> From: John Crispin <john@phrozen.org>
>
> Trigger ieee80211_csa_finish() on the non-transmitting interfaces
> when channel switch concludes on the transmitting interface.
>
> Signed-off-by: John Crispin <john@phrozen.org>
> Co-developed-by: Aloka Dixit <alokad@codeaurora.org>
> Signed-off-by: Aloka Dixit <alokad@codeaurora.org>
> ---
> v13: Replaced list_for_each_entry_safe() by list_for_each_entry()
>
Uh, ouch. I guess I miscommunicated that.
What I really meant was that the list iteration here:
> + if (vif->mbssid_tx_vif == vif) {
> + struct ieee80211_sub_if_data *child;
> +
> + list_for_each_entry(child, &sdata->local->interfaces,
> list)
does not seem correct, since it's not locked, and you don't have any
guarantees that it's not being modified since the only thing here is
that the vif pointer is coming in valid from the driver?
johannes
prev parent reply other threads:[~2021-11-26 11:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-06 4:09 [v13 0/3] MBSSID and EMA support in AP mode Aloka Dixit
2021-10-06 4:09 ` [v13 1/3] mac80211: split beacon retrieval functions Aloka Dixit
2021-10-06 20:20 ` Aloka Dixit
2021-10-06 4:09 ` [v13 2/3] mac80211: MBSSID and EMA beacon handling in AP mode Aloka Dixit
2021-11-26 11:23 ` Johannes Berg
2022-01-14 19:23 ` Aloka Dixit
2022-01-14 20:12 ` Johannes Berg
2022-01-14 20:34 ` Aloka Dixit
2022-01-14 20:50 ` Johannes Berg
2021-10-06 4:09 ` [v13 3/3] mac80211: MBSSID channel switch Aloka Dixit
2021-11-26 11:16 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cce18c617b2a1860ebab329fb1f9077cd1399ec4.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=alokad@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).