From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4CB04137E for ; Fri, 19 Apr 2024 02:03:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=211.75.126.72 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713492242; cv=none; b=S0Ne+OiQyKkAc2NKJ3GBLZ8bdamPyyZ1c91r8c1uBBZaFzhj/e5ejmxDW+++fnx2WY5Igu+2OM6gG/kIfydRbsoz45awhtE2uQWnomNIE4LB4ryuA+r3JfY1MjayoJWx8p5GYRcfi2soT+ngpBKezDhpMTxwMWhb1iB/dWD33dU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713492242; c=relaxed/simple; bh=rh+RTVftgdCqeRJegfasf8EU04W4qQbszBFoNPRcXqo=; h=From:To:CC:Subject:In-Reply-To:References:MIME-Version: Content-Type:Message-ID:Date; b=fVdRYHF9gY+JGSa9sySMvLEF2vZI6N3GribfMS/ufz0E4rWX9dugQvxeMDE5BqDNLP59ciHYuZWuZuywE7ItwhZ5Ox/FMwVqMZ7j2MuS6ovrGgmqfAFCTprzmN+naI/JABInsvpHJQ6bfq7Pq4G45PIrppm9g7NyIvm2R5sA1cM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=realtek.com; spf=pass smtp.mailfrom=realtek.com; arc=none smtp.client-ip=211.75.126.72 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=realtek.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=realtek.com X-SpamFilter-By: ArmorX SpamTrap 5.78 with qID 43J23uDK2894997, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtexh36506.realtek.com.tw[172.21.6.27]) by rtits2.realtek.com.tw (8.15.2/2.95/5.92) with ESMTPS id 43J23uDK2894997 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 19 Apr 2024 10:03:56 +0800 Received: from RTEXMBS04.realtek.com.tw (172.21.6.97) by RTEXH36506.realtek.com.tw (172.21.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 19 Apr 2024 10:03:56 +0800 Received: from [127.0.1.1] (172.21.69.94) by RTEXMBS04.realtek.com.tw (172.21.6.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 19 Apr 2024 10:03:56 +0800 From: Ping-Ke Shih To: Bitterblue Smith , "linux-wireless@vger.kernel.org" CC: Jes Sorensen , Ping-Ke Shih Subject: Re: [PATCH v2] wifi: rtl8xxxu: Add LED control code for RTL8723BU In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Message-ID: Date: Fri, 19 Apr 2024 10:03:56 +0800 X-ClientProxiedBy: RTEXMBS02.realtek.com.tw (172.21.6.95) To RTEXMBS04.realtek.com.tw (172.21.6.97) Bitterblue Smith wrote: > Software control (on/off) and hardware control (automatic blinking) > tested with EDUP EP-N8568. > > Signed-off-by: Bitterblue Smith Checkpatch warns: WARNING: Missing a blank line after declarations #28: FILE: drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8723b.c:1711: + u8 ledcfg = rtl8xxxu_read8(priv, REG_LEDCFG2); + ledcfg &= LEDCFG2_DPDT_SELECT; WARNING: braces {} are not necessary for any arm of this statement #30: FILE: drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8723b.c:1713: + if (brightness == LED_OFF) { [...] + } else if (brightness == LED_ON) { [...] + } else if (brightness == RTL8XXXU_HW_LED_CONTROL) { [...] Set patchset state to Changes Requested [v2] wifi: rtl8xxxu: Add LED control code for RTL8723BU --- https://github.com/pkshih/rtw.git