From: Ping-Ke Shih <pkshih@realtek.com>
To: Kalle Valo <kvalo@kernel.org>,
Martin Kaistra <martin.kaistra@linutronix.de>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"Jes Sorensen" <Jes.Sorensen@gmail.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Bitterblue Smith <rtl8821cerfe2@gmail.com>
Subject: RE: [PATCH] wifi: rtl8xxxu: enable MFP support
Date: Wed, 17 Apr 2024 08:47:57 +0000 [thread overview]
Message-ID: <eefdf5e598eb4e758130d416793ad9d7@realtek.com> (raw)
In-Reply-To: <87v84gwfzh.fsf@kernel.org>
Kalle Valo <kvalo@kernel.org> wrote:
>
> Ping-Ke Shih <pkshih@realtek.com> writes:
>
> > Hi Kalle,
> >
> > Martin Kaistra <martin.kaistra@linutronix.de> wrote:
> >
> >> Hi Ping-Ke,
> >>
> >> Am 15.04.24 um 21:14 schrieb Bitterblue Smith:
> >> > On 15/04/2024 09:49, Martin Kaistra wrote:
> >> >> Am 14.04.24 um 13:32 schrieb Bitterblue Smith:
> >> >>> On 14/03/2024 18:48, Martin Kaistra wrote:
> >> >>>
> >> >>> Also, won't you send the patch to the stable tree?
> >> >>
> >> >> The rtl8xxxu driver previously did not have the MFP_CAPABLE flag
> >> >> set. As I am adding new functionality
> >> (support for WPA3), I don't think this should go to stable.
> >> >
> >> > Without your patch I can't connect to my phone's hotspot
> >> > when it uses WPA3:
> >> >
> >> > Apr 08 12:50:57 ideapad2 wpa_supplicant[1231]: nl80211: kernel
> >> > reports: key setting validation failed
> >> > Apr 08 12:50:57 ideapad2 wpa_supplicant[1231]: wlp3s0f3u2: WPA:
> >> > Failed to configure IGTK to the driver
> >> > Apr 08 12:50:57 ideapad2 wpa_supplicant[1231]: wlp3s0f3u2: RSN:
> >> > Failed to configure IGTK
> >> >
> >> > It doesn't say anything about WPA3 or management frame
> >> > protection, just prints those unhelpful errors and tries
> >> > to connect over and over again. To me that looks more like
> >> > fixing a bug than adding new functionality. It's just sad
> >> > that people need to install kernel 6.10+ in order to support
> >> > WPA3, when the patch is so small.
> >>
> >> I would like to know your opinion on this. imho this patch should not go to
> >> stable and I would therefore propose to just send a patch to improve the checks.
> >> If you as a maintainer however say, you would like to see this in stable, then I
> >> will send a revert and a new patch.
> >>
> >
> > We have a question about MFP support to stable tree. rtl8xxxu never supports MFP,
> > and recently we have a small patch (10+ LOC) to enable that. I feel we should
> > treat it as new feature, not add to stable tree. But as Bitterblue mentioned,
> > it looks like a bug. Need your opinion.
>
> I assume you are talking about this patch:
>
> https://lore.kernel.org/all/20240314164850.86432-1-martin.kaistra@linutronix.de/
>
> I have no strong opinion here. To me it also looks like a new feature
> but it might fall within "Serious issues as reported by a user of a
> distribution kernel may also be considered if they fix a notable
> performance or interactivity issue" stable kernel rule:
>
> https://docs.kernel.org/process/stable-kernel-rules.html
>
> Maybe go with 'Option 2'? That is, wait for the commit to go to Linus'
> tree, send a mail to stable maintainers explaining the situation and let
> them decide. But I would be fine with 'Option 1' as well, your call :)
>
Thanks for your inputs, Kalle. :)
Hi Martin,
Bitterblue had a simple way [1] to support MFP, if that also works to you, I
think we can revert your original patch [2], and add an new one with Cc stable.
If that doesn't work to you, let's keep your patch and go via 'Option 2'.
[1] https://lore.kernel.org/linux-wireless/ed12ec17-ae6e-45fa-a72f-23e0a34654da@gmail.com/
[2] https://lore.kernel.org/all/20240314164850.86432-1-martin.kaistra@linutronix.de/
prev parent reply other threads:[~2024-04-17 8:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-14 16:48 [PATCH] wifi: rtl8xxxu: enable MFP support Martin Kaistra
2024-03-15 1:22 ` Ping-Ke Shih
2024-03-20 2:03 ` Ping-Ke Shih
2024-04-14 11:32 ` Bitterblue Smith
2024-04-15 0:57 ` Ping-Ke Shih
2024-04-15 6:49 ` Martin Kaistra
2024-04-15 19:14 ` Bitterblue Smith
2024-04-17 6:43 ` Martin Kaistra
2024-04-17 7:23 ` Ping-Ke Shih
2024-04-17 8:28 ` Kalle Valo
2024-04-17 8:47 ` Ping-Ke Shih [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eefdf5e598eb4e758130d416793ad9d7@realtek.com \
--to=pkshih@realtek.com \
--cc=Jes.Sorensen@gmail.com \
--cc=bigeasy@linutronix.de \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=martin.kaistra@linutronix.de \
--cc=rtl8821cerfe2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).