linux-x25.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: YueHaibing <yuehaibing@huawei.com>,
	linux-x25@vger.kernel.org, netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
	Allison Randal <allison@lohutok.net>,
	Andrew Hendry <andrew.hendry@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jakub Kicinski <kuba@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Xin Tan <tanxin.ctf@gmail.com>,
	Xiyu Yang <xiyuyang19@fudan.edu.cn>
Subject: Re: [PATCH] net/x25: Fix null-ptr-deref in x25_disconnect
Date: Tue, 28 Apr 2020 19:52:44 +0200	[thread overview]
Message-ID: <2638b7a4-4c19-ca4d-3931-7442378b3b30@web.de> (raw)

> We should check null before do x25_neigh_put in x25_disconnect,
> otherwise may cause null-ptr-deref like this:

Will it be clearer to use the term “null pointer dereference”
in the final commit subject?

Regards,
Markus

             reply	other threads:[~2020-04-28 17:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-28 17:52 Markus Elfring [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-04-28  4:58 net test error: KASAN: null-ptr-deref Write in x25_disconnect syzbot
2020-04-28  8:12 ` [PATCH] net/x25: Fix null-ptr-deref " YueHaibing
2020-04-28 21:11   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2638b7a4-4c19-ca4d-3931-7442378b3b30@web.de \
    --to=markus.elfring@web.de \
    --cc=allison@lohutok.net \
    --cc=andrew.hendry@gmail.com \
    --cc=davem@davemloft.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-x25@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=tanxin.ctf@gmail.com \
    --cc=tglx@linutronix.de \
    --cc=xiyuyang19@fudan.edu.cn \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).