From: John Garry <john.g.garry@oracle.com>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-xfs@vger.kernel.org, ojaswin@linux.ibm.com, ritesh.list@gmail.com
Subject: Re: [PATCH 1/3] xfs: simplify extent allocation alignment
Date: Tue, 2 Apr 2024 08:49:09 +0100 [thread overview]
Message-ID: <11ba4fca-2c89-406a-83e3-cb8d20f72044@oracle.com> (raw)
In-Reply-To: <ZgueamvcnndUUwYd@dread.disaster.area>
>>> the problem should go away and the
>>> extent gets trimmed to 76 blocks.
>> ..if so, then, yes, it does. We end up with this:
>>
>> 0: [0..14079]: 42432..56511 0 (42432..56511) 14080
>> 1: [14080..14687]: 177344..177951 0 (177344..177951) 608
>> 2: [14688..14719]: 350720..350751 1 (171520..171551) 32
> Good, that's how it should work. 🙂
>
> I'll update the patchset I have with these fixes.
ok, thanks
Update:
So I have some more patches from trying to support both truncate and
fallocate + punch/insert/collapse for forcealign.
I seem to have at least 2x problems:
- unexpected -ENOSPC in some case
- sometimes misaligned extents from ordered combo of punch, truncate, write
I don't know if it is a good use of time for me to try to debug, as I
guess you could spot problems in the changes almost immediately.
Next steps:
I would like to send out a new series for XFS support for atomic writes
soon, which so far included forcealign support.
Please advise on your preference for what I should do, like wait for
your forcealign update and then combine into the XFS support for atomic
write series. Or just post the doubtful patches now, as above, and go
from there?
Thanks,
John
next prev parent reply other threads:[~2024-04-02 7:49 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-04 13:04 [PATCH v2 00/14] block atomic writes for XFS John Garry
2024-03-04 13:04 ` [PATCH v2 01/14] block: Add blk_validate_atomic_write_op_size() John Garry
2024-03-04 13:04 ` [PATCH v2 02/14] fs: xfs: Don't use low-space allocator for alignment > 1 John Garry
2024-03-04 22:15 ` Dave Chinner
2024-03-05 13:36 ` John Garry
2024-03-04 13:04 ` [PATCH v2 03/14] fs: xfs: Introduce FORCEALIGN inode flag John Garry
2024-03-04 13:04 ` [PATCH v2 04/14] fs: xfs: Make file data allocations observe the 'forcealign' flag John Garry
2024-03-05 0:44 ` Dave Chinner
2024-03-05 15:22 ` John Garry
2024-03-05 22:18 ` Dave Chinner
2024-03-06 5:20 ` [RFC PATCH 0/3] xfs: forced extent alignment Dave Chinner
2024-03-06 5:20 ` [PATCH 1/3] xfs: simplify extent allocation alignment Dave Chinner
2024-03-13 11:03 ` John Garry
2024-03-20 4:35 ` Dave Chinner
2024-03-26 16:08 ` John Garry
2024-04-02 5:58 ` Dave Chinner
2024-04-02 7:49 ` John Garry [this message]
2024-04-02 15:11 ` John Garry
2024-04-02 21:26 ` Dave Chinner
2024-04-03 8:49 ` John Garry
2024-04-02 23:44 ` Dave Chinner
2024-04-03 11:30 ` John Garry
2024-03-06 5:20 ` [PATCH 2/3] xfs: make EOF allocation simpler Dave Chinner
2024-03-06 5:20 ` [PATCH 3/3] xfs: introduce forced allocation alignment Dave Chinner
2024-03-06 11:46 ` [RFC PATCH 0/3] xfs: forced extent alignment John Garry
2024-03-06 17:52 ` John Garry
2024-03-06 20:54 ` Dave Chinner
2024-03-13 18:32 ` John Garry
2024-03-06 9:41 ` [PATCH v2 04/14] fs: xfs: Make file data allocations observe the 'forcealign' flag John Garry
2024-03-04 13:04 ` [PATCH v2 05/14] fs: xfs: Enable file data forcealign feature John Garry
2024-03-04 13:04 ` [PATCH v2 06/14] fs: xfs: Do not free EOF blocks for forcealign John Garry
2024-03-06 21:07 ` Dave Chinner
2024-03-07 11:38 ` John Garry
2024-03-04 13:04 ` [PATCH v2 07/14] fs: iomap: Sub-extent zeroing John Garry
2024-03-06 21:14 ` Dave Chinner
2024-03-07 11:51 ` John Garry
2024-03-04 13:04 ` [PATCH v2 08/14] fs: xfs: " John Garry
2024-03-06 22:00 ` Dave Chinner
2024-03-07 12:57 ` John Garry
2024-03-04 13:04 ` [PATCH v2 09/14] fs: Add FS_XFLAG_ATOMICWRITES flag John Garry
2024-03-04 13:04 ` [PATCH v2 10/14] fs: iomap: Atomic write support John Garry
2024-03-04 13:04 ` [PATCH v2 11/14] fs: xfs: Support FS_XFLAG_ATOMICWRITES for forcealign John Garry
2024-03-06 21:43 ` Dave Chinner
2024-03-07 12:42 ` John Garry
2024-03-04 13:04 ` [PATCH v2 12/14] fs: xfs: Support atomic write for statx John Garry
2024-03-06 21:31 ` Dave Chinner
2024-03-07 10:35 ` John Garry
2024-03-04 13:04 ` [PATCH v2 13/14] fs: xfs: Validate atomic writes John Garry
2024-03-06 21:22 ` Dave Chinner
2024-03-07 10:19 ` John Garry
2024-03-04 13:04 ` [PATCH v2 14/14] fs: xfs: Support setting FMODE_CAN_ATOMIC_WRITE John Garry
2024-03-06 21:33 ` Dave Chinner
2024-03-07 11:55 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11ba4fca-2c89-406a-83e3-cb8d20f72044@oracle.com \
--to=john.g.garry@oracle.com \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
--cc=ojaswin@linux.ibm.com \
--cc=ritesh.list@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).