Linux-XFS Archive mirror
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@kernel.org>
To: chandanbabu@kernel.org, djwong@kernel.org
Cc: allison.henderson@oracle.com, catherine.hoang@oracle.com,
	hch@lst.de, linux-xfs@vger.kernel.org
Subject: [GIT PULL 16/16] xfs: retain ILOCK during directory updates
Date: Mon, 15 Apr 2024 17:33:55 -0700	[thread overview]
Message-ID: <171322719997.141687.18094380315256577049.stg-ugh@frogsfrogsfrogs> (raw)
In-Reply-To: <20240416002427.GB11972@frogsfrogsfrogs>

Hi Chandan,

Please pull this branch with changes for xfs for 6.10-rc1.

As usual, I did a test-merge with the main upstream branch as of a few
minutes ago, and didn't see any conflicts.  Please let me know if you
encounter any problems.

--D

The following changes since commit 67bdcd499909708195b9408c106b94250955c5ff:

docs: describe xfs directory tree online fsck (2024-04-15 14:59:01 -0700)

are available in the Git repository at:

https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git tags/retain-ilock-during-dir-ops-6.10_2024-04-15

for you to fetch changes up to df760471477400ccd3ddcea85d2d6d92f4dad28c:

xfs: unlock new repair tempfiles after creation (2024-04-15 14:59:03 -0700)

----------------------------------------------------------------
xfs: retain ILOCK during directory updates [v13.2 16/16]

This series changes the directory update code to retain the ILOCK on all
files involved in a rename until the end of the operation.  The upcoming
parent pointers patchset applies parent pointers in a separate chained
update from the actual directory update, which is why it is now
necessary to keep the ILOCK instead of dropping it after the first
transaction in the chain.

As a side effect, we no longer need to hold the IOLOCK during an rmapbt
scan of inodes to serialize the scan with ongoing directory updates.

This has been running on the djcloud for months with no problems.  Enjoy!

Signed-off-by: Darrick J. Wong <djwong@kernel.org>

----------------------------------------------------------------
Allison Henderson (5):
xfs: Increase XFS_DEFER_OPS_NR_INODES to 5
xfs: Increase XFS_QM_TRANS_MAXDQS to 5
xfs: Hold inode locks in xfs_ialloc
xfs: Hold inode locks in xfs_trans_alloc_dir
xfs: Hold inode locks in xfs_rename

Darrick J. Wong (2):
xfs: don't pick up IOLOCK during rmapbt repair scan
xfs: unlock new repair tempfiles after creation

fs/xfs/libxfs/xfs_defer.c  |  6 ++-
fs/xfs/libxfs/xfs_defer.h  |  8 +++-
fs/xfs/scrub/rmap_repair.c | 16 +-------
fs/xfs/scrub/tempfile.c    |  2 +
fs/xfs/xfs_dquot.c         | 41 +++++++++++++++++++
fs/xfs/xfs_dquot.h         |  1 +
fs/xfs/xfs_inode.c         | 98 ++++++++++++++++++++++++++++++++++------------
fs/xfs/xfs_inode.h         |  2 +
fs/xfs/xfs_qm.c            |  4 +-
fs/xfs/xfs_qm.h            |  2 +-
fs/xfs/xfs_symlink.c       |  6 ++-
fs/xfs/xfs_trans.c         |  9 ++++-
fs/xfs/xfs_trans_dquot.c   | 15 ++++---
13 files changed, 156 insertions(+), 54 deletions(-)


      parent reply	other threads:[~2024-04-16  0:33 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-16  0:24 [GIT PULLBOMB v30.3] xfs: online repair, part 1 is done Darrick J. Wong
2024-04-16  0:27 ` [GIT PULL 01/16] xfs: improve log incompat feature handling Darrick J. Wong
2024-04-16  0:27 ` [GIT PULL 02/16] xfs: refactorings for atomic file content exchanges Darrick J. Wong
2024-04-16  0:28 ` [GIT PULL 03/16] xfs: " Darrick J. Wong
2024-04-16  0:28 ` [GIT PULL 04/16] xfs: create temporary files for online repair Darrick J. Wong
2024-04-16  0:28 ` [GIT PULL 05/16] xfs: online repair of realtime summaries Darrick J. Wong
2024-04-16  0:28 ` [GIT PULL 06/16] xfs: set and validate dir/attr block owners Darrick J. Wong
2024-04-16  0:29 ` [GIT PULL 07/16] xfs: online repair of extended attributes Darrick J. Wong
2024-04-16  0:29 ` [GIT PULL 08/16] xfs: online repair of inode unlinked state Darrick J. Wong
2024-04-16  0:29 ` [GIT PULL 09/16] xfs: online repair of directories Darrick J. Wong
2024-04-16  0:29 ` [GIT PULL 10/16] xfs: move orphan files to lost and found Darrick J. Wong
2024-04-16  0:30 ` [GIT PULL 11/16] xfs: online repair of symbolic links Darrick J. Wong
2024-04-16  0:30 ` [GIT PULL 12/16] xfs: online fsck of iunlink buckets Darrick J. Wong
2024-04-16  0:30 ` [GIT PULL 13/16] xfs: inode-related repair fixes Darrick J. Wong
2024-04-16  0:33 ` [GIT PULL 14/16] xfs: less heavy locks during fstrim Darrick J. Wong
2024-04-16  0:33 ` [GIT PULL 15/16] xfs: design documentation for online fsck, part 2 Darrick J. Wong
2024-04-16  0:33 ` Darrick J. Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=171322719997.141687.18094380315256577049.stg-ugh@frogsfrogsfrogs \
    --to=djwong@kernel.org \
    --cc=allison.henderson@oracle.com \
    --cc=catherine.hoang@oracle.com \
    --cc=chandanbabu@kernel.org \
    --cc=hch@lst.de \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).