From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Zorro Lang <zlang@redhat.com>,
linux-xfs@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH] xfs: don't run tests that require v4 file systems when not supported
Date: Thu, 28 Mar 2024 18:09:02 +0100 [thread overview]
Message-ID: <20240328170902.GA503@lst.de> (raw)
In-Reply-To: <20240328150542.GD6379@frogsfrogsfrogs>
On Thu, Mar 28, 2024 at 08:05:42AM -0700, Darrick J. Wong wrote:
>
> The crc=0 forcing case seems only to activate if
> XFS_MKFS_HAS_NO_META_SUPPORT is non-empty, which happens only if
> mkfs.xfs does /not/ support V5 filesystems. Maybe we can drop that
> case?
The way I read it is is that it is activate if
XFS_MKFS_HAS_NO_META_SUPPORT is emtpy, that is if CRC are supported
and it then disables them. But only for < 1024 bytes block sizes,
which we don't actually support for crc-enabled file systems.
Maybe just drop the 512 byte block size testing from this patch
entirely? And with that the rather oddly named
XFS_MKFS_HAS_NO_META_SUPPORT variable can go away as well.
> > xfs/096 requires an obsolete mkfs without input validation, but
> > I guess adding the doesn't hurt
>
> Why do we even keep this test then? Do we care about xfsprogs 4.5?
> 4.19^H4 is the oldest LTS kernel...
Good point. I'll add a patch to remove it.
prev parent reply other threads:[~2024-03-28 17:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-28 12:17 [PATCH] xfs: don't run tests that require v4 file systems when not supported Christoph Hellwig
2024-03-28 13:59 ` Zorro Lang
2024-03-28 14:56 ` Christoph Hellwig
2024-03-28 15:05 ` Darrick J. Wong
2024-03-28 17:09 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240328170902.GA503@lst.de \
--to=hch@lst.de \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).