From: Dave Chinner <david@fromorbit.com>
To: linux-xfs@vger.kernel.org
Subject: [PATCH 4/5] xfs: remove unused is_rt_data_fork() function
Date: Wed, 3 Apr 2024 08:28:31 +1100 [thread overview]
Message-ID: <20240402213541.1199959-5-david@fromorbit.com> (raw)
In-Reply-To: <20240402213541.1199959-1-david@fromorbit.com>
From: Dave Chinner <dchinner@redhat.com>
Sparse warns that is_rt_data_fork() is unused. Indeed, it is a
static inline function that isn't used in the file it is defined in.
It looks like xfs_ifork_is_realtime() has superceded this function,
so remove it and get rid of the sparse warning.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
---
fs/xfs/scrub/rmap_repair.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/fs/xfs/scrub/rmap_repair.c b/fs/xfs/scrub/rmap_repair.c
index e8e07b683eab..7e73ddfb3d44 100644
--- a/fs/xfs/scrub/rmap_repair.c
+++ b/fs/xfs/scrub/rmap_repair.c
@@ -432,14 +432,6 @@ xrep_rmap_scan_iroot_btree(
return error;
}
-static inline bool
-is_rt_data_fork(
- struct xfs_inode *ip,
- int whichfork)
-{
- return XFS_IS_REALTIME_INODE(ip) && whichfork == XFS_DATA_FORK;
-}
-
/*
* Iterate the block mapping btree to collect rmap records for anything in this
* fork that matches the AG. Sets @mappings_done to true if we've scanned the
--
2.43.0
next prev parent reply other threads:[~2024-04-02 21:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 21:28 [PATCH 0/5] xfs: sparse warning fixes Dave Chinner
2024-04-02 21:28 ` [PATCH 1/5] xfs: fix CIL sparse lock context warnings Dave Chinner
2024-04-03 3:53 ` Christoph Hellwig
2024-04-02 21:28 ` [PATCH 2/5] xfs: fix sparse warning in xfs_extent_busy_clear Dave Chinner
2024-04-03 4:04 ` Darrick J. Wong
2024-04-03 4:32 ` Christoph Hellwig
2024-04-02 21:28 ` [PATCH 3/5] xfs: silence sparse warning when checking version number Dave Chinner
2024-04-03 3:57 ` Darrick J. Wong
2024-04-03 4:35 ` Christoph Hellwig
2024-04-02 21:28 ` Dave Chinner [this message]
2024-04-03 3:54 ` [PATCH 4/5] xfs: remove unused is_rt_data_fork() function Darrick J. Wong
2024-04-03 4:35 ` Christoph Hellwig
2024-04-02 21:28 ` [PATCH 5/5] xfs: fix sparse warnings about unused interval tree functions Dave Chinner
2024-04-03 3:53 ` Darrick J. Wong
2024-04-03 4:39 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240402213541.1199959-5-david@fromorbit.com \
--to=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).