From: Christoph Hellwig <hch@lst.de>
To: Chandan Babu R <chandan.babu@oracle.com>,
"Darrick J. Wong" <djwong@kernel.org>
Cc: Dave Chinner <david@fromorbit.com>,
linux-xfs@vger.kernel.org (open list:XFS FILESYSTEM)
Subject: RFC: extended version of the xfs_bmapi_write retval fix
Date: Mon, 8 Apr 2024 16:54:46 +0200 [thread overview]
Message-ID: <20240408145454.718047-1-hch@lst.de> (raw)
Hi all,
this series tries to take the xfs_bmapi_wite retval fix a little further,
but I'm not entirely happy with the result.
The first patch is the actual return value fix with the comments fixed
up as per the comment from Darrick, and a dead check removed I found
while developing the rest.
The following patches are random cleanups to get the code in shape for
the last patches.
The second to last patch fixes long-standing issues in
xfs_bmap_add_extent_delay_real in code paths that haven't been used much
or at all.
The last patch changes xfs_bmapi_write to not convert the entire
delalloc extent if it hits one. This sounds simpler than it is, because
delalloc conversion has been designed to always convert the entire
extent since the initial delalloc commits. I'm not really sure that
putting strain on this code now will do us much good, so I'll just leave
these patches out for comments for now and will look into how coding up
a loop of delalloc conversion calls in every place that could allocate
blocks in the data fork of a regular file and thus hit delalloc so we
can compare the approaches.
In the mean time I think that patch 1 is a candidate for 6.9 as it fixes
the fuzzer problem.
Diffstat:
libxfs/xfs_attr_remote.c | 1
libxfs/xfs_bmap.c | 120 ++++++++++++++++++++++++++++-------------------
libxfs/xfs_da_btree.c | 20 +------
scrub/quota_repair.c | 6 --
scrub/rtbitmap_repair.c | 2
xfs_bmap_util.c | 31 +++++-------
xfs_dquot.c | 1
xfs_iomap.c | 8 ---
xfs_reflink.c | 14 -----
xfs_rtalloc.c | 2
10 files changed, 93 insertions(+), 112 deletions(-)
next reply other threads:[~2024-04-08 14:54 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-08 14:54 Christoph Hellwig [this message]
2024-04-08 14:54 ` [PATCH 1/8] xfs: fix error returns from xfs_bmapi_write Christoph Hellwig
2024-04-09 23:19 ` Darrick J. Wong
2024-04-10 4:02 ` Christoph Hellwig
2024-04-08 14:54 ` [PATCH 2/8] xfs: remove the unusued tmp_logflags variable in xfs_bmapi_allocate Christoph Hellwig
2024-04-09 23:17 ` Darrick J. Wong
2024-04-08 14:54 ` [PATCH 3/8] xfs: lifr a xfs_valid_startblock into xfs_bmapi_allocate Christoph Hellwig
2024-04-09 23:17 ` Darrick J. Wong
2024-04-08 14:54 ` [PATCH 4/8] xfs: don't open code XFS_FILBLKS_MIN in xfs_bmapi_write Christoph Hellwig
2024-04-09 23:17 ` Darrick J. Wong
2024-04-08 14:54 ` [PATCH 5/8] xfs: pass the actual offset and len to allocate to xfs_bmapi_allocate Christoph Hellwig
2024-04-09 23:20 ` Darrick J. Wong
2024-04-10 4:03 ` Christoph Hellwig
2024-04-08 14:54 ` [PATCH 6/8] xfs: remove the xfs_iext_peek_prev_extent call in xfs_bmapi_allocate Christoph Hellwig
2024-04-09 23:16 ` Darrick J. Wong
2024-04-08 14:54 ` [PATCH 7/8] xfs: fix xfs_bmap_add_extent_delay_real for partial conversions Christoph Hellwig
2024-04-09 23:16 ` Darrick J. Wong
2024-04-10 4:04 ` Christoph Hellwig
2024-04-08 14:54 ` [PATCH 8/8] xfs: do not allocate the entire delalloc extent in xfs_bmapi_write Christoph Hellwig
2024-04-09 23:16 ` Darrick J. Wong
2024-04-10 4:07 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240408145454.718047-1-hch@lst.de \
--to=hch@lst.de \
--cc=chandan.babu@oracle.com \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).