From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Zorro Lang <zlang@kernel.org>,
linux-xfs@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH 5/6] xfs/522: use reflink instead of crc as test feature
Date: Tue, 9 Apr 2024 08:39:35 -0700 [thread overview]
Message-ID: <20240409153935.GE634366@frogsfrogsfrogs> (raw)
In-Reply-To: <20240408133243.694134-6-hch@lst.de>
On Mon, Apr 08, 2024 at 03:32:42PM +0200, Christoph Hellwig wrote:
> Replace crc as the main test feature with reflink so that this test
> do not require v4 file system support.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Pretty straight conversion, so
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> ---
> tests/xfs/522 | 58 +++++++++++++++++++++++++--------------------------
> 1 file changed, 29 insertions(+), 29 deletions(-)
>
> diff --git a/tests/xfs/522 b/tests/xfs/522
> index 2475d5844..05251b0e2 100755
> --- a/tests/xfs/522
> +++ b/tests/xfs/522
> @@ -46,58 +46,58 @@ test_mkfs_config() {
> echo Simplest config file
> cat > $def_cfgfile << ENDL
> [metadata]
> -crc = 0
> +reflink = 0
> ENDL
> test_mkfs_config $def_cfgfile
>
> echo Piped-in config file
> test_mkfs_config << ENDL
> [metadata]
> -crc = 0
> +reflink = 0
> ENDL
> test_mkfs_config << ENDL
> [metadata]
> -crc = 1
> +reflink = 1
> ENDL
>
> echo Full line comment
> test_mkfs_config << ENDL
> # This is a full line comment.
> [metadata]
> -crc = 0
> +reflink = 0
> ENDL
> test_mkfs_config << ENDL
> # This is a full line comment.
> [metadata]
> -crc = 0
> +reflink = 0
> ENDL
> test_mkfs_config << ENDL
> #This is a full line comment.
> [metadata]
> -crc = 0
> +reflink = 0
> ENDL
>
> echo End of line comment
> test_mkfs_config << ENDL
> [metadata]
> -crc = 0 ; This is an eol comment.
> +reflink = 0 ; This is an eol comment.
> ENDL
> test_mkfs_config << ENDL
> [metadata]
> -crc = 0 ;This is an eol comment.
> +reflink = 0 ;This is an eol comment.
> ENDL
>
> echo Multiple directives
> test_mkfs_config << ENDL
> [metadata]
> -crc = 0
> +reflink = 0
> finobt = 0
> ENDL
>
> echo Multiple sections
> test_mkfs_config << ENDL
> [metadata]
> -crc = 0
> +reflink = 0
>
> [inode]
> sparse = 0
> @@ -111,92 +111,92 @@ ENDL
> echo Space around the section name
> test_mkfs_config << ENDL
> [metadata]
> -crc = 0
> +reflink = 0
> ENDL
> test_mkfs_config << ENDL
> [metadata]
> -crc = 0
> +reflink = 0
> ENDL
> test_mkfs_config << ENDL
> [metadata]
> -crc = 0
> +reflink = 0
> ENDL
>
> echo Single space around the key/value directive
> test_mkfs_config << ENDL
> [metadata]
> - crc=0
> + reflink=0
> ENDL
> test_mkfs_config << ENDL
> [metadata]
> -crc =0
> +reflink =0
> ENDL
> test_mkfs_config << ENDL
> [metadata]
> -crc= 0
> +reflink= 0
> ENDL
> test_mkfs_config << ENDL
> [metadata]
> -crc=0
> +reflink=0
> ENDL
>
> echo Two spaces around the key/value directive
> test_mkfs_config << ENDL
> [metadata]
> - crc =0
> + reflink =0
> ENDL
> test_mkfs_config << ENDL
> [metadata]
> - crc= 0
> + reflink= 0
> ENDL
> test_mkfs_config << ENDL
> [metadata]
> - crc=0
> + reflink=0
> ENDL
> test_mkfs_config << ENDL
> [metadata]
> -crc = 0
> +reflink = 0
> ENDL
> test_mkfs_config << ENDL
> [metadata]
> -crc =0
> +reflink =0
> ENDL
> test_mkfs_config << ENDL
> [metadata]
> -crc= 0
> +reflink= 0
> ENDL
>
> echo Three spaces around the key/value directive
> test_mkfs_config << ENDL
> [metadata]
> - crc = 0
> + reflink = 0
> ENDL
> test_mkfs_config << ENDL
> [metadata]
> - crc= 0
> + reflink= 0
> ENDL
> test_mkfs_config << ENDL
> [metadata]
> -crc = 0
> +reflink = 0
> ENDL
>
> echo Four spaces around the key/value directive
> test_mkfs_config << ENDL
> [metadata]
> - crc = 0
> + reflink = 0
> ENDL
>
> echo Arbitrary spaces and tabs
> test_mkfs_config << ENDL
> [metadata]
> - crc = 0
> + reflink = 0
> ENDL
>
> echo ambiguous comment/section names
> test_mkfs_config << ENDL
> [metadata]
> #[data]
> -crc = 0
> +reflink = 0
> ENDL
>
> echo ambiguous comment/variable names
> --
> 2.39.2
>
>
next prev parent reply other threads:[~2024-04-09 15:39 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-08 13:32 fix kernels without v5 support Christoph Hellwig
2024-04-08 13:32 ` [PATCH 1/6] xfs: remove support for tools and kernels with " Christoph Hellwig
2024-04-08 15:03 ` Eric Biggers
2024-04-08 15:04 ` Christoph Hellwig
2024-04-09 15:26 ` Darrick J. Wong
2024-04-29 9:34 ` Chandan Babu R
2024-04-29 9:53 ` Christoph Hellwig
2024-04-29 14:20 ` Zorro Lang
2024-04-08 13:32 ` [PATCH 2/6] remove xfs/096 Christoph Hellwig
2024-04-09 15:27 ` Darrick J. Wong
2024-04-08 13:32 ` [PATCH 3/6] xfs/078: remove the 512 byte block size sub-case Christoph Hellwig
2024-04-09 15:32 ` Darrick J. Wong
2024-04-08 13:32 ` [PATCH 4/6] xfs/263: remove the nocrc sub-test Christoph Hellwig
2024-04-09 15:57 ` Darrick J. Wong
2024-04-10 4:11 ` Christoph Hellwig
2024-04-08 13:32 ` [PATCH 5/6] xfs/522: use reflink instead of crc as test feature Christoph Hellwig
2024-04-09 15:39 ` Darrick J. Wong [this message]
2024-04-08 13:32 ` [PATCH 6/6] xfs: don't run tests that require v4 file systems when not supported Christoph Hellwig
2024-04-09 15:56 ` Darrick J. Wong
2024-04-10 4:14 ` Christoph Hellwig
2024-04-10 15:05 ` Darrick J. Wong
2024-04-08 14:55 ` fix kernels without v5 support Zorro Lang
2024-04-08 14:59 ` Christoph Hellwig
2024-04-08 19:00 ` Zorro Lang
2024-04-10 14:42 ` Zorro Lang
2024-04-10 14:51 ` Christoph Hellwig
2024-04-10 15:16 ` Darrick J. Wong
2024-04-10 15:18 ` Christoph Hellwig
2024-04-10 16:03 ` Darrick J. Wong
2024-04-10 19:38 ` Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240409153935.GE634366@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).