From: Ye Bin <yebin10@huawei.com>
To: <djwong@kernel.org>, <linux-xfs@vger.kernel.org>,
<chandan.babu@oracle.com>, <dchinner@redhat.com>
Cc: <linux-kernel@vger.kernel.org>, <yebin10@huawei.com>
Subject: [PATCH RFC 2/2] xfs: avoid potenial alloc inode failed
Date: Fri, 19 Apr 2024 14:18:48 +0800 [thread overview]
Message-ID: <20240419061848.1032366-3-yebin10@huawei.com> (raw)
In-Reply-To: <20240419061848.1032366-1-yebin10@huawei.com>
As 'pag->pagf_longest' may be temporarily set to 0. When the AGF buffer
lock is not held, using 'pag->pagf_longest' to determine whether the space
is available will cause misjudgment.
When the fragmentation is not serious and the reserved space exists, using
'pag->pagf_longest' to determine whether the space is available cannot filter
out the space that really cannot be allocated.
So remove judgement about 'pag->pagf_longest' in xfs_dialloc_good_ag().
Signed-off-by: Ye Bin <yebin10@huawei.com>
---
fs/xfs/libxfs/xfs_ialloc.c | 13 ++-----------
1 file changed, 2 insertions(+), 11 deletions(-)
diff --git a/fs/xfs/libxfs/xfs_ialloc.c b/fs/xfs/libxfs/xfs_ialloc.c
index e5ac3e5430c4..bb0ce2248386 100644
--- a/fs/xfs/libxfs/xfs_ialloc.c
+++ b/fs/xfs/libxfs/xfs_ialloc.c
@@ -1689,7 +1689,6 @@ xfs_dialloc_good_ag(
{
struct xfs_mount *mp = tp->t_mountp;
xfs_extlen_t ineed;
- xfs_extlen_t longest = 0;
int needspace;
int error;
@@ -1717,12 +1716,7 @@ xfs_dialloc_good_ag(
/*
* Check that there is enough free space for the file plus a chunk of
- * inodes if we need to allocate some. If this is the first pass across
- * the AGs, take into account the potential space needed for alignment
- * of inode chunks when checking the longest contiguous free space in
- * the AG - this prevents us from getting ENOSPC because we have free
- * space larger than ialloc_blks but alignment constraints prevent us
- * from using it.
+ * inodes if we need to allocate some.
*
* If we can't find an AG with space for full alignment slack to be
* taken into account, we must be near ENOSPC in all AGs. Hence we
@@ -1742,12 +1736,9 @@ xfs_dialloc_good_ag(
ineed = M_IGEO(mp)->ialloc_min_blks;
if (flags && ineed > 1)
ineed += M_IGEO(mp)->cluster_align;
- longest = pag->pagf_longest;
- if (!longest)
- longest = pag->pagf_flcount > 0;
needspace = S_ISDIR(mode) || S_ISREG(mode) || S_ISLNK(mode);
- if (pag->pagf_freeblks < needspace + ineed || longest < ineed)
+ if (pag->pagf_freeblks < needspace + ineed)
return false;
return true;
}
--
2.34.1
prev parent reply other threads:[~2024-04-19 6:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-19 6:18 [PATCH RFC 0/2] xfs: fix potential create file failed Ye Bin
2024-04-19 6:18 ` [PATCH RFC 1/2] " Ye Bin
2024-04-21 23:24 ` Dave Chinner
2024-04-19 6:18 ` Ye Bin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240419061848.1032366-3-yebin10@huawei.com \
--to=yebin10@huawei.com \
--cc=chandan.babu@oracle.com \
--cc=dchinner@redhat.com \
--cc=djwong@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).