From: Andrey Albershteyn <aalbersh@redhat.com>
To: cem@kernel.org, linux-xfs@vger.kernel.org
Cc: Andrey Albershteyn <aalbersh@redhat.com>
Subject: [PATCH v5 0/4] xfsprogs random fixes found by Coverity scan
Date: Tue, 23 Apr 2024 14:36:13 +0200 [thread overview]
Message-ID: <20240423123616.2629570-2-aalbersh@redhat.com> (raw)
Hi all,
This is bunch of random fixes found by Coverity scan, there's memory
leak, truncation of time_t to int, access overflow, and freeing of
uninitialized struct.
v5:
- printf format for time_t in repair
v4:
- remove parentheses and conversion in another expression; add
spaces for operators
v3:
- better error message
v2:
- remove parentheses
- drop count initialization patch as this code goes away with parent
pointers
- rename unload: label
- howlong limit
--
Andrey
Andrey Albershteyn (4):
xfs_db: fix leak in flist_find_ftyp()
xfs_repair: make duration take time_t
xfs_scrub: don't call phase_end if phase_rusage was not initialized
xfs_fsr: convert fsrallfs to use time_t instead of int
db/flist.c | 4 +++-
fsr/xfs_fsr.c | 10 ++++++++--
repair/globals.c | 2 +-
repair/globals.h | 2 +-
repair/progress.c | 9 +++++----
repair/progress.h | 2 +-
repair/xfs_repair.c | 2 +-
scrub/xfs_scrub.c | 3 ++-
8 files changed, 22 insertions(+), 12 deletions(-)
--
2.42.0
next reply other threads:[~2024-04-23 12:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 12:36 Andrey Albershteyn [this message]
2024-04-23 12:36 ` [PATCH v5 1/4] xfs_db: fix leak in flist_find_ftyp() Andrey Albershteyn
2024-04-23 12:36 ` [PATCH v5 2/4] xfs_repair: make duration take time_t Andrey Albershteyn
2024-04-23 13:04 ` Carlos Maiolino
2024-04-23 12:36 ` [PATCH v5 3/4] xfs_scrub: don't call phase_end if phase_rusage was not initialized Andrey Albershteyn
2024-04-23 12:36 ` [PATCH v5 4/4] xfs_fsr: convert fsrallfs to use time_t instead of int Andrey Albershteyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240423123616.2629570-2-aalbersh@redhat.com \
--to=aalbersh@redhat.com \
--cc=cem@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).