From: "Darrick J. Wong" <djwong@kernel.org>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: chandan.babu@oracle.com, linux-xfs@vger.kernel.org,
linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] xfs: Remove unused function xrep_dir_self_parent
Date: Tue, 23 Apr 2024 20:06:56 -0700 [thread overview]
Message-ID: <20240424030656.GC360919@frogsfrogsfrogs> (raw)
In-Reply-To: <20240424020638.81487-1-jiapeng.chong@linux.alibaba.com>
On Wed, Apr 24, 2024 at 10:06:38AM +0800, Jiapeng Chong wrote:
> The function are defined in the dir_repair.c file, but not called
> elsewhere, so delete the unused function.
>
> fs/xfs/scrub/dir_repair.c:186:1: warning: unused function 'xrep_dir_self_parent'.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8867
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Yep, not used anywhere in my patchsets. Thank you for catching this and
cleaning it up.
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> ---
> fs/xfs/scrub/dir_repair.c | 21 ---------------------
> 1 file changed, 21 deletions(-)
>
> diff --git a/fs/xfs/scrub/dir_repair.c b/fs/xfs/scrub/dir_repair.c
> index 38957da26b94..f8450c7f99f4 100644
> --- a/fs/xfs/scrub/dir_repair.c
> +++ b/fs/xfs/scrub/dir_repair.c
> @@ -176,27 +176,6 @@ xrep_setup_directory(
> return 0;
> }
>
> -/*
> - * If we're the root of a directory tree, we are our own parent. If we're an
> - * unlinked directory, the parent /won't/ have a link to us. Set the parent
> - * directory to the root for both cases. Returns NULLFSINO if we don't know
> - * what to do.
> - */
> -static inline xfs_ino_t
> -xrep_dir_self_parent(
> - struct xrep_dir *rd)
> -{
> - struct xfs_scrub *sc = rd->sc;
> -
> - if (sc->ip->i_ino == sc->mp->m_sb.sb_rootino)
> - return sc->mp->m_sb.sb_rootino;
> -
> - if (VFS_I(sc->ip)->i_nlink == 0)
> - return sc->mp->m_sb.sb_rootino;
> -
> - return NULLFSINO;
> -}
> -
> /*
> * Look up the dotdot entry and confirm that it's really the parent.
> * Returns NULLFSINO if we don't know what to do.
> --
> 2.20.1.7.g153144c
>
>
prev parent reply other threads:[~2024-04-24 3:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 2:06 [PATCH] xfs: Remove unused function xrep_dir_self_parent Jiapeng Chong
2024-04-24 3:06 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240424030656.GC360919@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=abaci@linux.alibaba.com \
--cc=chandan.babu@oracle.com \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).