From: "Darrick J. Wong" <djwong@kernel.org>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: linux-fsdevel@vger.kernel.org,
Christian Brauner <brauner@kernel.org>,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 27/30] iomap: Remove calls to set and clear folio error flag
Date: Thu, 25 Apr 2024 09:55:23 -0700 [thread overview]
Message-ID: <20240425165523.GB360898@frogsfrogsfrogs> (raw)
In-Reply-To: <20240420025029.2166544-28-willy@infradead.org>
On Sat, Apr 20, 2024 at 03:50:22AM +0100, Matthew Wilcox (Oracle) wrote:
> The folio error flag is not checked anywhere, so we can remove the calls
> to set and clear it.
>
> Cc: Christian Brauner <brauner@kernel.org>
> Cc: Darrick J. Wong <djwong@kernel.org>
> Cc: linux-xfs@vger.kernel.org
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Looks fine to me,
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> ---
> fs/iomap/buffered-io.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c
> index 4e8e41c8b3c0..41352601f939 100644
> --- a/fs/iomap/buffered-io.c
> +++ b/fs/iomap/buffered-io.c
> @@ -306,8 +306,6 @@ static void iomap_finish_folio_read(struct folio *folio, size_t off,
> spin_unlock_irqrestore(&ifs->state_lock, flags);
> }
>
> - if (error)
> - folio_set_error(folio);
> if (finished)
> folio_end_read(folio, uptodate);
> }
> @@ -460,9 +458,6 @@ int iomap_read_folio(struct folio *folio, const struct iomap_ops *ops)
> while ((ret = iomap_iter(&iter, ops)) > 0)
> iter.processed = iomap_readpage_iter(&iter, &ctx, 0);
>
> - if (ret < 0)
> - folio_set_error(folio);
> -
> if (ctx.bio) {
> submit_bio(ctx.bio);
> WARN_ON_ONCE(!ctx.cur_folio_in_bio);
> @@ -697,7 +692,6 @@ static int __iomap_write_begin(const struct iomap_iter *iter, loff_t pos,
>
> if (folio_test_uptodate(folio))
> return 0;
> - folio_clear_error(folio);
>
> do {
> iomap_adjust_read_range(iter->inode, folio, &block_start,
> @@ -1528,8 +1522,6 @@ iomap_finish_ioend(struct iomap_ioend *ioend, int error)
>
> /* walk all folios in bio, ending page IO on them */
> bio_for_each_folio_all(fi, bio) {
> - if (error)
> - folio_set_error(fi.folio);
> iomap_finish_folio_write(inode, fi.folio, fi.length);
> folio_count++;
> }
> --
> 2.43.0
>
>
prev parent reply other threads:[~2024-04-25 16:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240420025029.2166544-1-willy@infradead.org>
2024-04-20 2:50 ` [PATCH 27/30] iomap: Remove calls to set and clear folio error flag Matthew Wilcox (Oracle)
2024-04-22 6:16 ` Christoph Hellwig
2024-04-22 15:05 ` Matthew Wilcox
2024-04-22 15:26 ` Christoph Hellwig
2024-04-22 17:51 ` Matthew Wilcox
2024-04-25 12:23 ` Christoph Hellwig
2024-04-25 12:44 ` Matthew Wilcox
2024-04-25 12:51 ` Christoph Hellwig
2024-04-25 16:47 ` Darrick J. Wong
2024-04-25 16:55 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240425165523.GB360898@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=brauner@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).