From: Christoph Hellwig <hch@lst.de>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@lst.de>,
Chandan Babu R <chandan.babu@oracle.com>,
"Darrick J. Wong" <djwong@kernel.org>,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 3/3] xfs: simplify iext overflow checking and upgrade
Date: Wed, 1 May 2024 06:35:46 +0200 [thread overview]
Message-ID: <20240501043546.GA31252@lst.de> (raw)
In-Reply-To: <ZjFl9uwKzRUrigTI@dread.disaster.area>
On Wed, May 01, 2024 at 07:43:18AM +1000, Dave Chinner wrote:
> xfs_iext_count_extend() seems like a much better name - it tells the
> reader what the code is actually doing (i.e. we may have to extend
> the iext count before performing this operation) and it makes it
> obvious when it is done out of place....
Sure, I can change the name.
Btw, it would be nice to trim your reply a bit more, I had to scroll
down a few pages of quotes text yo get here.
next prev parent reply other threads:[~2024-05-01 4:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 12:55 iext handling fixes and cleanup Christoph Hellwig
2024-04-30 12:56 ` [PATCH 1/3] xfs: upgrade the extent counters in xfs_reflink_end_cow_extent later Christoph Hellwig
2024-04-30 12:56 ` [PATCH 2/3] xfs: remove a racy if_bytes check in xfs_reflink_end_cow_extent Christoph Hellwig
2024-04-30 12:56 ` [PATCH 3/3] xfs: simplify iext overflow checking and upgrade Christoph Hellwig
2024-04-30 21:43 ` Dave Chinner
2024-05-01 4:35 ` Christoph Hellwig [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-05-02 7:33 iext handling fixes and cleanup v2 Christoph Hellwig
2024-05-02 7:33 ` [PATCH 3/3] xfs: simplify iext overflow checking and upgrade Christoph Hellwig
2024-05-02 7:55 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240501043546.GA31252@lst.de \
--to=hch@lst.de \
--cc=chandan.babu@oracle.com \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).