From: "Darrick J. Wong" <djwong@kernel.org>
To: John Garry <john.g.garry@oracle.com>
Cc: chandan.babu@oracle.com, dchinner@redhat.com, hch@lst.de,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 0/2] xfs: fallocate RT flush unmap range fixes
Date: Thu, 9 May 2024 07:35:29 -0700 [thread overview]
Message-ID: <20240509143529.GG360919@frogsfrogsfrogs> (raw)
In-Reply-To: <20240509104057.1197846-1-john.g.garry@oracle.com>
On Thu, May 09, 2024 at 10:40:55AM +0000, John Garry wrote:
> As mentioned by Dave Chinner at [0], xfs_flush_unmap_range() and
> xfs_prepare_shift() should consider RT extents in the flush unmap range,
> and need to be fixed.
>
> I don't want to add such changes to that series, so I am sending
> separately.
>
> About the change in xfs_prepare_shift(), that function is only called
> from xfs_insert_file_space() and xfs_collapse_file_space(). Those
> functions only permit RT extent-aligned calls in xfs_is_falloc_aligned(),
> so in practice I don't think that this change would affect
> xfs_prepare_shift(). And xfs_prepare_shift() calls
> xfs_flush_unmap_range(), which is being fixed up anyway.
>
> [0] https://lore.kernel.org/linux-xfs/ZjGSiOt21g5JCOhf@dread.disaster.area/
Looks good to me,
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
>
> Changes since RFC:
> - Use roundup() and rounddown() (Darrick)
> - Change xfs_prepare_shift() comment (Darrick)
> - Add Christoph's RB tags - I think ok, even though code has changed
> since RFC
>
> John Garry (2):
> xfs: Fix xfs_flush_unmap_range() range for RT
> xfs: Fix xfs_prepare_shift() range for RT
>
> fs/xfs/xfs_bmap_util.c | 22 ++++++++++++++--------
> 1 file changed, 14 insertions(+), 8 deletions(-)
>
> --
> 2.31.1
>
>
prev parent reply other threads:[~2024-05-09 14:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-09 10:40 [PATCH 0/2] xfs: fallocate RT flush unmap range fixes John Garry
2024-05-09 10:40 ` [PATCH 1/2] xfs: Fix xfs_flush_unmap_range() range for RT John Garry
2024-05-09 22:59 ` kernel test robot
2024-05-09 23:40 ` Dave Chinner
2024-05-10 11:10 ` John Garry
2024-05-09 10:40 ` [PATCH 2/2] xfs: Fix xfs_prepare_shift() " John Garry
2024-05-10 5:35 ` kernel test robot
2024-05-09 14:35 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240509143529.GG360919@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=chandan.babu@oracle.com \
--cc=dchinner@redhat.com \
--cc=hch@lst.de \
--cc=john.g.garry@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).