From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: "Darrick J. Wong" <djwong@kernel.org>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/2] xfs: internalise all remaining i_version support
Date: Wed, 20 Mar 2024 14:10:15 +1100 [thread overview]
Message-ID: <ZfpTl/1hKUQeBsX3@dread.disaster.area> (raw)
In-Reply-To: <ZfoadKGgatGjTM_5@infradead.org>
On Tue, Mar 19, 2024 at 04:06:28PM -0700, Christoph Hellwig wrote:
> Is there much of a good reason to do this now vs oing it whenverer
> we actually sort out i_version semantics? It adds size to the inode
> and I don't see how the atomics actually cost us much. The patch
> itself does looks good, though.
I'm kinda with Darrick on this - yes, it burns an extra 8 bytes per
inode, but it doesn't leave us exposed to someone misusing the
inode->i_version field. I also don't like the idea of leaving the
disablement half done - that just makes it more work for whoever
comes later to do something with this again...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2024-03-22 0:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-18 22:50 [PATCH v2 0/2] xfs: drop SB_I_VERSION support Dave Chinner
2024-03-18 22:51 ` [PATCH 1/2] xfs: stop advertising SB_I_VERSION Dave Chinner
2024-03-19 17:51 ` Darrick J. Wong
2024-03-19 23:03 ` Christoph Hellwig
2024-03-18 22:51 ` [PATCH 2/2] xfs: internalise all remaining i_version support Dave Chinner
2024-03-19 17:54 ` Darrick J. Wong
2024-03-19 23:06 ` Christoph Hellwig
2024-03-19 23:17 ` Darrick J. Wong
2024-03-20 3:10 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZfpTl/1hKUQeBsX3@dread.disaster.area \
--to=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).