From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@lst.de>,
chandan.babu@oracle.com, djwong@kernel.org,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs: compile out v4 support if disabled
Date: Thu, 21 Mar 2024 20:25:03 -0700 [thread overview]
Message-ID: <Zfz6D_A0h6_VrfSp@infradead.org> (raw)
In-Reply-To: <Zfn+CTA88U78hiQw@dread.disaster.area>
On Wed, Mar 20, 2024 at 08:05:13AM +1100, Dave Chinner wrote:
> Is that right? This can only return true if V4 support is compiled
> in, but it should be the other way around - always return true if
> V4 support is not compiled in. i.e:
Yes. I actually also fixed that when I redid the patch. The downside
is that despite the additional stubs we actually remove less code now.
prev parent reply other threads:[~2024-03-22 3:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-19 7:19 [PATCH] xfs: compile out v4 support if disabled Christoph Hellwig
2024-03-19 17:59 ` Darrick J. Wong
2024-03-19 20:09 ` Christoph Hellwig
2024-03-19 21:13 ` Dave Chinner
2024-03-22 3:24 ` Christoph Hellwig
2024-03-19 21:05 ` Dave Chinner
2024-03-22 3:25 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zfz6D_A0h6_VrfSp@infradead.org \
--to=hch@infradead.org \
--cc=chandan.babu@oracle.com \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).