From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: hch@lst.de, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 3/4] xfs: rename xfs_da_args.attr_flags
Date: Tue, 9 Apr 2024 22:01:55 -0700 [thread overview]
Message-ID: <ZhYdQ90rqsMOGaa1@infradead.org> (raw)
In-Reply-To: <171270968435.3631393.4664304714455437765.stgit@frogsfrogsfrogs>
On Tue, Apr 09, 2024 at 05:50:07PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> This field only ever contains XATTR_{CREATE,REPLACE}, so let's change
> the name of the field to make the field and its values consistent.
So, these flags only get passed to xfs_attr_set through xfs_attr_change
and xfs_attr_setname, which means we should probably just pass them
directly as in my patch (against your whole stack) below.
Also I suspect we should do an audit of all the internal callers
if they should ever be replace an existing attr, as I guess most
don't. (and xfs_attr_change really should be folded into xfs_attr_set,
the split is confusing as hell).
diff --git a/fs/xfs/libxfs/xfs_attr.c b/fs/xfs/libxfs/xfs_attr.c
index b98d2a908452a0..38d1f4d10baa3b 100644
--- a/fs/xfs/libxfs/xfs_attr.c
+++ b/fs/xfs/libxfs/xfs_attr.c
@@ -1034,7 +1034,8 @@ xfs_attr_ensure_iext(
*/
int
xfs_attr_set(
- struct xfs_da_args *args)
+ struct xfs_da_args *args,
+ uint8_t xattr_flags)
{
struct xfs_inode *dp = args->dp;
struct xfs_mount *mp = dp->i_mount;
@@ -1109,7 +1110,7 @@ xfs_attr_set(
}
/* Pure create fails if the attr already exists */
- if (args->xattr_flags & XATTR_CREATE)
+ if (xattr_flags & XATTR_CREATE)
goto out_trans_cancel;
xfs_attr_defer_add(args, XFS_ATTR_DEFER_REPLACE);
break;
@@ -1119,7 +1120,7 @@ xfs_attr_set(
goto out_trans_cancel;
/* Pure replace fails if no existing attr to replace. */
- if (args->xattr_flags & XATTR_REPLACE)
+ if (xattr_flags & XATTR_REPLACE)
goto out_trans_cancel;
xfs_attr_defer_add(args, XFS_ATTR_DEFER_SET);
break;
@@ -1155,7 +1156,7 @@ xfs_attr_set(
* Ensure that the xattr structure maps @args->name to @args->value.
*
* The caller must have initialized @args, attached dquots, and must not hold
- * any ILOCKs. Only XATTR_CREATE may be specified in @args->xattr_flags.
+ * any ILOCKs. Only XATTR_CREATE may be specified in @xattr_flags.
* Reserved data blocks may be used if @rsvd is set.
*
* Returns -EEXIST if XATTR_CREATE was specified and the name already exists.
@@ -1163,6 +1164,7 @@ xfs_attr_set(
int
xfs_attr_setname(
struct xfs_da_args *args,
+ uint8_t xattr_flags,
bool rsvd)
{
struct xfs_inode *dp = args->dp;
@@ -1172,7 +1174,7 @@ xfs_attr_setname(
int rmt_extents = 0;
int error, local;
- ASSERT(!(args->xattr_flags & XATTR_REPLACE));
+ ASSERT(!(xattr_flags & ~XATTR_CREATE));
ASSERT(!args->trans);
args->total = xfs_attr_calc_size(args, &local);
@@ -1198,7 +1200,7 @@ xfs_attr_setname(
switch (error) {
case -EEXIST:
/* Pure create fails if the attr already exists */
- if (args->xattr_flags & XATTR_CREATE)
+ if (xattr_flags & XATTR_CREATE)
goto out_trans_cancel;
if (args->attr_filter & XFS_ATTR_PARENT)
xfs_attr_defer_parent(args, XFS_ATTR_DEFER_REPLACE);
diff --git a/fs/xfs/libxfs/xfs_attr.h b/fs/xfs/libxfs/xfs_attr.h
index 2a0ef4f633e2d1..b90e04c3e64f60 100644
--- a/fs/xfs/libxfs/xfs_attr.h
+++ b/fs/xfs/libxfs/xfs_attr.h
@@ -550,7 +550,7 @@ int xfs_inode_hasattr(struct xfs_inode *ip);
bool xfs_attr_is_leaf(struct xfs_inode *ip);
int xfs_attr_get_ilocked(struct xfs_da_args *args);
int xfs_attr_get(struct xfs_da_args *args);
-int xfs_attr_set(struct xfs_da_args *args);
+int xfs_attr_set(struct xfs_da_args *args, uint8_t xattr_flags);
int xfs_attr_set_iter(struct xfs_attr_intent *attr);
int xfs_attr_remove_iter(struct xfs_attr_intent *attr);
bool xfs_attr_check_namespace(unsigned int attr_flags);
@@ -560,7 +560,7 @@ int xfs_attr_calc_size(struct xfs_da_args *args, int *local);
void xfs_init_attr_trans(struct xfs_da_args *args, struct xfs_trans_res *tres,
unsigned int *total);
-int xfs_attr_setname(struct xfs_da_args *args, bool rsvd);
+int xfs_attr_setname(struct xfs_da_args *args, uint8_t xattr_flags, bool rsvd);
int xfs_attr_removename(struct xfs_da_args *args, bool rsvd);
/*
diff --git a/fs/xfs/libxfs/xfs_da_btree.h b/fs/xfs/libxfs/xfs_da_btree.h
index 8d7a38fe2a5c07..354d5d65043e43 100644
--- a/fs/xfs/libxfs/xfs_da_btree.h
+++ b/fs/xfs/libxfs/xfs_da_btree.h
@@ -69,7 +69,6 @@ typedef struct xfs_da_args {
uint8_t filetype; /* filetype of inode for directories */
uint8_t op_flags; /* operation flags */
uint8_t attr_filter; /* XFS_ATTR_{ROOT,SECURE,INCOMPLETE} */
- uint8_t xattr_flags; /* XATTR_{CREATE,REPLACE} */
short namelen; /* length of string (maybe no NULL) */
short new_namelen; /* length of new attr name */
xfs_dahash_t hashval; /* hash value of name */
diff --git a/fs/xfs/libxfs/xfs_parent.c b/fs/xfs/libxfs/xfs_parent.c
index 2b6ed8c1ee1522..c5422f714fcc72 100644
--- a/fs/xfs/libxfs/xfs_parent.c
+++ b/fs/xfs/libxfs/xfs_parent.c
@@ -355,7 +355,7 @@ xfs_parent_set(
memset(scratch, 0, sizeof(struct xfs_da_args));
xfs_parent_da_args_init(scratch, NULL, pptr, ip, owner, parent_name);
- return xfs_attr_setname(scratch, true);
+ return xfs_attr_setname(scratch, 0, true);
}
/*
diff --git a/fs/xfs/scrub/attr_repair.c b/fs/xfs/scrub/attr_repair.c
index e06d00ea828b3e..8863eef5a0b87b 100644
--- a/fs/xfs/scrub/attr_repair.c
+++ b/fs/xfs/scrub/attr_repair.c
@@ -615,7 +615,6 @@ xrep_xattr_insert_rec(
struct xfs_da_args args = {
.dp = rx->sc->tempip,
.attr_filter = key->flags,
- .xattr_flags = XATTR_CREATE,
.namelen = key->namelen,
.valuelen = key->valuelen,
.owner = rx->sc->ip->i_ino,
@@ -675,7 +674,7 @@ xrep_xattr_insert_rec(
* use reserved blocks because we can abort the repair with ENOSPC.
*/
xfs_attr_sethash(&args);
- error = xfs_attr_setname(&args, false);
+ error = xfs_attr_setname(&args, XATTR_CREATE, false);
if (error == -EEXIST)
error = 0;
diff --git a/fs/xfs/scrub/parent_repair.c b/fs/xfs/scrub/parent_repair.c
index cf79cbcda3ecb4..1bc05efa344036 100644
--- a/fs/xfs/scrub/parent_repair.c
+++ b/fs/xfs/scrub/parent_repair.c
@@ -1031,7 +1031,7 @@ xrep_parent_insert_xattr(
rp->xattr_name, key->namelen, key->valuelen);
xfs_attr_sethash(&args);
- return xfs_attr_setname(&args, false);
+ return xfs_attr_setname(&args, 0, false);
}
/*
diff --git a/fs/xfs/xfs_acl.c b/fs/xfs/xfs_acl.c
index 4bf69c9c088e28..1aaf3dc64bcbc1 100644
--- a/fs/xfs/xfs_acl.c
+++ b/fs/xfs/xfs_acl.c
@@ -203,7 +203,7 @@ __xfs_set_acl(struct inode *inode, struct posix_acl *acl, int type)
xfs_acl_to_disk(args.value, acl);
}
- error = xfs_attr_change(&args);
+ error = xfs_attr_change(&args, 0);
kvfree(args.value);
/*
diff --git a/fs/xfs/xfs_handle.c b/fs/xfs/xfs_handle.c
index 833b0d7d8bea1c..e3f54817b91557 100644
--- a/fs/xfs/xfs_handle.c
+++ b/fs/xfs/xfs_handle.c
@@ -492,7 +492,6 @@ xfs_attrmulti_attr_get(
struct xfs_da_args args = {
.dp = XFS_I(inode),
.attr_filter = xfs_attr_filter(flags),
- .xattr_flags = xfs_xattr_flags(flags),
.name = name,
.namelen = strlen(name),
.valuelen = *len,
@@ -526,7 +525,6 @@ xfs_attrmulti_attr_set(
struct xfs_da_args args = {
.dp = XFS_I(inode),
.attr_filter = xfs_attr_filter(flags),
- .xattr_flags = xfs_xattr_flags(flags),
.name = name,
.namelen = strlen(name),
};
@@ -544,7 +542,7 @@ xfs_attrmulti_attr_set(
args.valuelen = len;
}
- error = xfs_attr_change(&args);
+ error = xfs_attr_change(&args, xfs_xattr_flags(flags));
if (!error && (flags & XFS_IOC_ATTR_ROOT))
xfs_forget_acl(inode, name);
kfree(args.value);
diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c
index c4f9c7eec83590..d374be9f8a6e3e 100644
--- a/fs/xfs/xfs_iops.c
+++ b/fs/xfs/xfs_iops.c
@@ -64,7 +64,7 @@ xfs_initxattrs(
.value = xattr->value,
.valuelen = xattr->value_len,
};
- error = xfs_attr_change(&args);
+ error = xfs_attr_change(&args, 0);
if (error < 0)
break;
}
diff --git a/fs/xfs/xfs_trace.h b/fs/xfs/xfs_trace.h
index dc074240ad239f..1292d69087dc0c 100644
--- a/fs/xfs/xfs_trace.h
+++ b/fs/xfs/xfs_trace.h
@@ -2131,7 +2131,6 @@ DECLARE_EVENT_CLASS(xfs_attr_class,
__field(int, valuelen)
__field(xfs_dahash_t, hashval)
__field(unsigned int, attr_filter)
- __field(unsigned int, xattr_flags)
__field(uint32_t, op_flags)
),
TP_fast_assign(
@@ -2143,11 +2142,10 @@ DECLARE_EVENT_CLASS(xfs_attr_class,
__entry->valuelen = args->valuelen;
__entry->hashval = args->hashval;
__entry->attr_filter = args->attr_filter;
- __entry->xattr_flags = args->xattr_flags;
__entry->op_flags = args->op_flags;
),
TP_printk("dev %d:%d ino 0x%llx name %.*s namelen %d valuelen %d "
- "hashval 0x%x filter %s flags %s op_flags %s",
+ "hashval 0x%x filter %s op_flags %s",
MAJOR(__entry->dev), MINOR(__entry->dev),
__entry->ino,
__entry->namelen,
@@ -2157,9 +2155,6 @@ DECLARE_EVENT_CLASS(xfs_attr_class,
__entry->hashval,
__print_flags(__entry->attr_filter, "|",
XFS_ATTR_FILTER_FLAGS),
- __print_flags(__entry->xattr_flags, "|",
- { XATTR_CREATE, "CREATE" },
- { XATTR_REPLACE, "REPLACE" }),
__print_flags(__entry->op_flags, "|", XFS_DA_OP_FLAGS))
)
diff --git a/fs/xfs/xfs_xattr.c b/fs/xfs/xfs_xattr.c
index 1d57e204c850ff..69fa7b89c68972 100644
--- a/fs/xfs/xfs_xattr.c
+++ b/fs/xfs/xfs_xattr.c
@@ -80,7 +80,8 @@ xfs_attr_want_log_assist(
*/
int
xfs_attr_change(
- struct xfs_da_args *args)
+ struct xfs_da_args *args,
+ uint8_t xattr_flags)
{
struct xfs_mount *mp = args->dp->i_mount;
int error;
@@ -95,7 +96,7 @@ xfs_attr_change(
args->op_flags |= XFS_DA_OP_LOGGED;
}
- return xfs_attr_set(args);
+ return xfs_attr_set(args, xattr_flags);
}
@@ -131,7 +132,6 @@ xfs_xattr_set(const struct xattr_handler *handler,
struct xfs_da_args args = {
.dp = XFS_I(inode),
.attr_filter = handler->flags,
- .xattr_flags = flags,
.name = name,
.namelen = strlen(name),
.value = (void *)value,
@@ -139,7 +139,7 @@ xfs_xattr_set(const struct xattr_handler *handler,
};
int error;
- error = xfs_attr_change(&args);
+ error = xfs_attr_change(&args, flags);
if (!error && (handler->flags & XFS_ATTR_ROOT))
xfs_forget_acl(inode, name);
return error;
diff --git a/fs/xfs/xfs_xattr.h b/fs/xfs/xfs_xattr.h
index f097002d06571f..79c0040cc904b4 100644
--- a/fs/xfs/xfs_xattr.h
+++ b/fs/xfs/xfs_xattr.h
@@ -6,7 +6,7 @@
#ifndef __XFS_XATTR_H__
#define __XFS_XATTR_H__
-int xfs_attr_change(struct xfs_da_args *args);
+int xfs_attr_change(struct xfs_da_args *args, uint8_t xattr_flags);
int xfs_attr_grab_log_assist(struct xfs_mount *mp);
void xfs_attr_rele_log_assist(struct xfs_mount *mp);
next prev parent reply other threads:[~2024-04-10 5:01 UTC|newest]
Thread overview: 234+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-10 0:36 [PATCHBOMB v13.1] xfs: directory parent pointers Darrick J. Wong
2024-04-10 0:44 ` [PATCHSET v13.1 1/9] xfs: design documentation for online fsck, part 2 Darrick J. Wong
2024-04-10 0:46 ` [PATCH 1/4] docs: update the parent pointers documentation to the final version Darrick J. Wong
2024-04-10 4:40 ` Christoph Hellwig
2024-04-10 0:46 ` [PATCH 2/4] docs: update online directory and parent pointer repair sections Darrick J. Wong
2024-04-10 4:40 ` Christoph Hellwig
2024-04-10 0:47 ` [PATCH 3/4] docs: update offline parent pointer repair strategy Darrick J. Wong
2024-04-10 4:40 ` Christoph Hellwig
2024-04-10 0:47 ` [PATCH 4/4] docs: describe xfs directory tree online fsck Darrick J. Wong
2024-04-10 4:40 ` Christoph Hellwig
2024-04-10 0:44 ` [PATCHSET v13.1 2/9] xfs: retain ILOCK during directory updates Darrick J. Wong
2024-04-10 0:47 ` [PATCH 1/7] xfs: Increase XFS_DEFER_OPS_NR_INODES to 5 Darrick J. Wong
2024-04-10 4:41 ` Christoph Hellwig
2024-04-10 0:48 ` [PATCH 2/7] xfs: Increase XFS_QM_TRANS_MAXDQS " Darrick J. Wong
2024-04-10 4:41 ` Christoph Hellwig
2024-04-10 0:48 ` [PATCH 3/7] xfs: Hold inode locks in xfs_ialloc Darrick J. Wong
2024-04-10 4:41 ` Christoph Hellwig
2024-04-10 0:48 ` [PATCH 4/7] xfs: Hold inode locks in xfs_trans_alloc_dir Darrick J. Wong
2024-04-10 4:41 ` Christoph Hellwig
2024-04-10 0:48 ` [PATCH 5/7] xfs: Hold inode locks in xfs_rename Darrick J. Wong
2024-04-10 4:42 ` Christoph Hellwig
2024-04-10 0:49 ` [PATCH 6/7] xfs: don't pick up IOLOCK during rmapbt repair scan Darrick J. Wong
2024-04-10 4:42 ` Christoph Hellwig
2024-04-10 0:49 ` [PATCH 7/7] xfs: unlock new repair tempfiles after creation Darrick J. Wong
2024-04-10 4:42 ` Christoph Hellwig
2024-04-10 0:44 ` [PATCHSET v13.1 3/9] xfs: shrink struct xfs_da_args Darrick J. Wong
2024-04-10 0:49 ` [PATCH 1/4] xfs: remove XFS_DA_OP_REMOVE Darrick J. Wong
2024-04-10 4:43 ` Christoph Hellwig
2024-04-10 0:49 ` [PATCH 2/4] xfs: remove XFS_DA_OP_NOTIME Darrick J. Wong
2024-04-10 4:44 ` Christoph Hellwig
2024-04-10 0:50 ` [PATCH 3/4] xfs: rename xfs_da_args.attr_flags Darrick J. Wong
2024-04-10 5:01 ` Christoph Hellwig [this message]
2024-04-10 20:55 ` Darrick J. Wong
2024-04-11 0:00 ` Darrick J. Wong
2024-04-11 3:26 ` Christoph Hellwig
2024-04-11 4:15 ` Darrick J. Wong
2024-04-10 0:50 ` [PATCH 4/4] xfs: rearrange xfs_da_args a bit to use less space Darrick J. Wong
2024-04-10 5:02 ` Christoph Hellwig
2024-04-10 20:56 ` Darrick J. Wong
2024-04-10 0:45 ` [PATCHSET v13.1 4/9] xfs: improve extended attribute validation Darrick J. Wong
2024-04-10 0:50 ` [PATCH 01/12] xfs: attr fork iext must be loaded before calling xfs_attr_is_leaf Darrick J. Wong
2024-04-10 5:04 ` Christoph Hellwig
2024-04-10 20:58 ` Darrick J. Wong
2024-04-10 0:50 ` [PATCH 02/12] xfs: require XFS_SB_FEAT_INCOMPAT_LOG_XATTRS for attr log intent item recovery Darrick J. Wong
2024-04-10 5:04 ` Christoph Hellwig
2024-04-10 0:51 ` [PATCH 03/12] xfs: use an XFS_OPSTATE_ flag for detecting if logged xattrs are available Darrick J. Wong
2024-04-10 5:05 ` Christoph Hellwig
2024-04-10 0:51 ` [PATCH 04/12] xfs: check opcode and iovec count match in xlog_recover_attri_commit_pass2 Darrick J. Wong
2024-04-10 5:05 ` Christoph Hellwig
2024-04-10 0:51 ` [PATCH 05/12] xfs: fix missing check for invalid attr flags Darrick J. Wong
2024-04-10 5:07 ` Christoph Hellwig
2024-04-10 21:04 ` Darrick J. Wong
2024-04-10 0:51 ` [PATCH 06/12] xfs: restructure xfs_attr_complete_op a bit Darrick J. Wong
2024-04-10 5:07 ` Christoph Hellwig
2024-04-10 0:52 ` [PATCH 07/12] xfs: use helpers to extract xattr op from opflags Darrick J. Wong
2024-04-10 5:07 ` Christoph Hellwig
2024-04-10 0:52 ` [PATCH 08/12] xfs: validate recovered name buffers when recovering xattr items Darrick J. Wong
2024-04-10 5:08 ` Christoph Hellwig
2024-04-10 0:52 ` [PATCH 09/12] xfs: always set args->value in xfs_attri_item_recover Darrick J. Wong
2024-04-10 5:08 ` Christoph Hellwig
2024-04-10 0:52 ` [PATCH 10/12] xfs: use local variables for name and value length in _attri_commit_pass2 Darrick J. Wong
2024-04-10 5:08 ` Christoph Hellwig
2024-04-10 0:53 ` [PATCH 11/12] xfs: refactor name/length checks in xfs_attri_validate Darrick J. Wong
2024-04-10 5:09 ` Christoph Hellwig
2024-04-10 0:53 ` [PATCH 12/12] xfs: enforce one namespace per attribute Darrick J. Wong
2024-04-10 5:09 ` Christoph Hellwig
2024-04-10 0:45 ` [PATCHSET v13.1 5/9] xfs: Parent Pointers Darrick J. Wong
2024-04-10 0:53 ` [PATCH 01/32] xfs: rearrange xfs_attr_match parameters Darrick J. Wong
2024-04-10 5:10 ` Christoph Hellwig
2024-04-10 0:54 ` [PATCH 02/32] xfs: check the flags earlier in xfs_attr_match Darrick J. Wong
2024-04-10 0:54 ` [PATCH 03/32] xfs: move xfs_attr_defer_add to xfs_attr_item.c Darrick J. Wong
2024-04-10 5:11 ` Christoph Hellwig
2024-04-10 0:54 ` [PATCH 04/32] xfs: create a separate hashname function for extended attributes Darrick J. Wong
2024-04-10 5:11 ` Christoph Hellwig
2024-04-10 0:54 ` [PATCH 05/32] xfs: add parent pointer support to attribute code Darrick J. Wong
2024-04-10 5:11 ` Christoph Hellwig
2024-04-10 0:55 ` [PATCH 06/32] xfs: define parent pointer ondisk extended attribute format Darrick J. Wong
2024-04-10 5:12 ` Christoph Hellwig
2024-04-10 0:55 ` [PATCH 07/32] xfs: allow xattr matching on name and value for local/sf attrs Darrick J. Wong
2024-04-10 5:16 ` Christoph Hellwig
2024-04-10 21:13 ` Darrick J. Wong
2024-04-11 3:28 ` Christoph Hellwig
2024-04-10 0:55 ` [PATCH 08/32] xfs: allow logged xattr operations if parent pointers are enabled Darrick J. Wong
2024-04-10 5:18 ` Christoph Hellwig
2024-04-10 21:18 ` Darrick J. Wong
2024-04-10 0:55 ` [PATCH 09/32] xfs: log parent pointer xattr removal operations Darrick J. Wong
2024-04-10 5:18 ` Christoph Hellwig
2024-04-10 0:56 ` [PATCH 10/32] xfs: log parent pointer xattr setting operations Darrick J. Wong
2024-04-10 0:56 ` [PATCH 11/32] xfs: log parent pointer xattr replace operations Darrick J. Wong
2024-04-10 5:26 ` Christoph Hellwig
2024-04-10 23:07 ` Darrick J. Wong
2024-04-11 3:35 ` Christoph Hellwig
2024-04-10 0:56 ` [PATCH 12/32] xfs: record inode generation in xattr update log intent items Darrick J. Wong
2024-04-10 5:27 ` Christoph Hellwig
2024-04-10 0:56 ` [PATCH 13/32] xfs: Expose init_xattrs in xfs_create_tmpfile Darrick J. Wong
2024-04-10 5:28 ` Christoph Hellwig
2024-04-10 0:57 ` [PATCH 14/32] xfs: add parent pointer validator functions Darrick J. Wong
2024-04-10 5:31 ` Christoph Hellwig
2024-04-10 18:53 ` Darrick J. Wong
2024-04-11 3:25 ` Christoph Hellwig
2024-04-10 0:57 ` [PATCH 15/32] xfs: extend transaction reservations for parent attributes Darrick J. Wong
2024-04-10 5:31 ` Christoph Hellwig
2024-04-10 0:57 ` [PATCH 16/32] xfs: create a hashname function for parent pointers Darrick J. Wong
2024-04-10 5:33 ` Christoph Hellwig
2024-04-10 21:39 ` Darrick J. Wong
2024-04-10 0:57 ` [PATCH 17/32] xfs: parent pointer attribute creation Darrick J. Wong
2024-04-10 5:44 ` Christoph Hellwig
2024-04-10 21:50 ` Darrick J. Wong
2024-04-10 0:58 ` [PATCH 18/32] xfs: add parent attributes to link Darrick J. Wong
2024-04-10 5:45 ` Christoph Hellwig
2024-04-10 0:58 ` [PATCH 19/32] xfs: add parent attributes to symlink Darrick J. Wong
2024-04-10 5:45 ` Christoph Hellwig
2024-04-10 0:58 ` [PATCH 20/32] xfs: remove parent pointers in unlink Darrick J. Wong
2024-04-10 5:45 ` Christoph Hellwig
2024-04-10 0:58 ` [PATCH 21/32] xfs: Add parent pointers to rename Darrick J. Wong
2024-04-10 5:46 ` Christoph Hellwig
2024-04-10 0:59 ` [PATCH 22/32] xfs: Add parent pointers to xfs_cross_rename Darrick J. Wong
2024-04-10 5:46 ` Christoph Hellwig
2024-04-10 0:59 ` [PATCH 23/32] xfs: Filter XFS_ATTR_PARENT for getfattr Darrick J. Wong
2024-04-10 5:51 ` Christoph Hellwig
2024-04-10 21:58 ` Darrick J. Wong
2024-04-11 3:29 ` Christoph Hellwig
2024-04-10 0:59 ` [PATCH 24/32] xfs: pass the attr value to put_listent when possible Darrick J. Wong
2024-04-10 5:51 ` Christoph Hellwig
2024-04-10 1:00 ` [PATCH 25/32] xfs: move handle ioctl code to xfs_handle.c Darrick J. Wong
2024-04-10 5:52 ` Christoph Hellwig
2024-04-10 1:00 ` [PATCH 26/32] xfs: split out handle management helpers a bit Darrick J. Wong
2024-04-10 5:56 ` Christoph Hellwig
2024-04-10 22:01 ` Darrick J. Wong
2024-04-10 1:00 ` [PATCH 27/32] xfs: Add parent pointer ioctls Darrick J. Wong
2024-04-10 6:04 ` Christoph Hellwig
2024-04-10 23:34 ` Darrick J. Wong
2024-04-12 17:39 ` Darrick J. Wong
2024-04-14 5:18 ` Christoph Hellwig
2024-04-15 19:40 ` Darrick J. Wong
2024-04-16 4:47 ` Christoph Hellwig
2024-04-16 16:50 ` Darrick J. Wong
2024-04-16 16:54 ` Christoph Hellwig
2024-04-16 18:52 ` Darrick J. Wong
2024-04-16 19:01 ` Christoph Hellwig
2024-04-16 19:07 ` Darrick J. Wong
2024-04-16 19:14 ` Christoph Hellwig
2024-04-17 5:22 ` Darrick J. Wong
2024-04-17 5:29 ` Christoph Hellwig
2024-04-17 5:55 ` Darrick J. Wong
2024-04-10 1:00 ` [PATCH 28/32] xfs: don't remove the attr fork when parent pointers are enabled Darrick J. Wong
2024-04-10 6:04 ` Christoph Hellwig
2024-04-10 1:01 ` [PATCH 29/32] xfs: Add the parent pointer support to the superblock version 5 Darrick J. Wong
2024-04-10 6:05 ` Christoph Hellwig
2024-04-10 22:06 ` Darrick J. Wong
2024-04-10 1:01 ` [PATCH 30/32] xfs: fix unit conversion error in xfs_log_calc_max_attrsetm_res Darrick J. Wong
2024-04-10 6:05 ` Christoph Hellwig
2024-04-10 1:01 ` [PATCH 31/32] xfs: drop compatibility minimum log size computations for reflink Darrick J. Wong
2024-04-10 6:06 ` Christoph Hellwig
2024-04-10 1:01 ` [PATCH 32/32] xfs: enable parent pointers Darrick J. Wong
2024-04-10 6:06 ` Christoph Hellwig
2024-04-10 22:11 ` Darrick J. Wong
2024-04-10 0:45 ` [PATCHSET v13.1 6/9] xfs: scrubbing for " Darrick J. Wong
2024-04-10 1:02 ` [PATCH 1/7] xfs: check dirents have " Darrick J. Wong
2024-04-10 6:12 ` Christoph Hellwig
2024-04-10 1:02 ` [PATCH 2/7] xfs: deferred scrub of dirents Darrick J. Wong
2024-04-10 6:13 ` Christoph Hellwig
2024-04-10 1:02 ` [PATCH 3/7] xfs: scrub parent pointers Darrick J. Wong
2024-04-10 6:13 ` Christoph Hellwig
2024-04-10 1:02 ` [PATCH 4/7] xfs: deferred scrub of " Darrick J. Wong
2024-04-10 6:14 ` Christoph Hellwig
2024-04-10 1:03 ` [PATCH 5/7] xfs: walk directory parent pointers to determine backref count Darrick J. Wong
2024-04-10 6:14 ` Christoph Hellwig
2024-04-10 1:03 ` [PATCH 6/7] xfs: check parent pointer xattrs when scrubbing Darrick J. Wong
2024-04-10 6:14 ` Christoph Hellwig
2024-04-10 1:03 ` [PATCH 7/7] xfs: salvage parent pointers when rebuilding xattr structures Darrick J. Wong
2024-04-10 6:15 ` Christoph Hellwig
2024-04-10 0:45 ` [PATCHSET v13.1 7/9] xfs: online repair for parent pointers Darrick J. Wong
2024-04-10 1:03 ` [PATCH 01/14] xfs: add xattr setname and removename functions for internal users Darrick J. Wong
2024-04-10 6:18 ` Christoph Hellwig
2024-04-10 22:18 ` Darrick J. Wong
2024-04-11 3:32 ` Christoph Hellwig
2024-04-11 4:30 ` Darrick J. Wong
2024-04-11 4:50 ` Christoph Hellwig
2024-04-10 1:04 ` [PATCH 02/14] xfs: add raw parent pointer apis to support repair Darrick J. Wong
2024-04-10 6:18 ` Christoph Hellwig
2024-04-10 1:04 ` [PATCH 03/14] xfs: repair directories by scanning directory parent pointers Darrick J. Wong
2024-04-10 6:19 ` Christoph Hellwig
2024-04-10 1:04 ` [PATCH 04/14] xfs: implement live updates for directory repairs Darrick J. Wong
2024-04-10 6:19 ` Christoph Hellwig
2024-04-10 1:04 ` [PATCH 05/14] xfs: replay unlocked parent pointer updates that accrue during xattr repair Darrick J. Wong
2024-04-10 6:19 ` Christoph Hellwig
2024-04-10 1:05 ` [PATCH 06/14] xfs: repair directory parent pointers by scanning for dirents Darrick J. Wong
2024-04-10 6:20 ` Christoph Hellwig
2024-04-10 1:05 ` [PATCH 07/14] xfs: implement live updates for parent pointer repairs Darrick J. Wong
2024-04-10 6:20 ` Christoph Hellwig
2024-04-10 1:05 ` [PATCH 08/14] xfs: remove pointless unlocked assertion Darrick J. Wong
2024-04-10 6:20 ` Christoph Hellwig
2024-04-10 1:06 ` [PATCH 09/14] xfs: split xfs_bmap_add_attrfork into two pieces Darrick J. Wong
2024-04-10 6:21 ` Christoph Hellwig
2024-04-10 1:06 ` [PATCH 10/14] xfs: add a per-leaf block callback to xchk_xattr_walk Darrick J. Wong
2024-04-10 6:22 ` Christoph Hellwig
2024-04-10 1:06 ` [PATCH 11/14] xfs: actually rebuild the parent pointer xattrs Darrick J. Wong
2024-04-10 6:22 ` Christoph Hellwig
2024-04-10 1:06 ` [PATCH 12/14] xfs: adapt the orphanage code to handle parent pointers Darrick J. Wong
2024-04-10 6:23 ` Christoph Hellwig
2024-04-10 1:07 ` [PATCH 13/14] xfs: repair link count of nondirectories after rebuilding " Darrick J. Wong
2024-04-10 6:22 ` Christoph Hellwig
2024-04-10 1:07 ` [PATCH 14/14] xfs: inode repair should ensure there's an attr fork to store " Darrick J. Wong
2024-04-10 6:24 ` Christoph Hellwig
2024-04-10 0:46 ` [PATCHSET v13.1 8/9] xfs: detect and correct directory tree problems Darrick J. Wong
2024-04-10 1:07 ` [PATCH 1/4] xfs: teach online scrub to find directory tree structure problems Darrick J. Wong
2024-04-10 7:21 ` Christoph Hellwig
2024-04-10 1:07 ` [PATCH 2/4] xfs: invalidate dirloop scrub path data when concurrent updates happen Darrick J. Wong
2024-04-10 7:21 ` Christoph Hellwig
2024-04-10 1:08 ` [PATCH 3/4] xfs: report directory tree corruption in the health information Darrick J. Wong
2024-04-10 7:23 ` Christoph Hellwig
2024-04-10 1:08 ` [PATCH 4/4] xfs: fix corruptions in the directory tree Darrick J. Wong
2024-04-10 7:23 ` Christoph Hellwig
2024-04-10 0:46 ` [PATCHSET v13.1 9/9] xfs: vectorize scrub kernel calls Darrick J. Wong
2024-04-10 1:08 ` [PATCH 1/3] xfs: reduce the rate of cond_resched calls inside scrub Darrick J. Wong
2024-04-10 14:55 ` Christoph Hellwig
2024-04-10 22:19 ` Darrick J. Wong
2024-04-10 1:08 ` [PATCH 2/3] xfs: introduce vectored scrub mode Darrick J. Wong
2024-04-10 15:00 ` Christoph Hellwig
2024-04-11 0:59 ` Darrick J. Wong
2024-04-11 3:38 ` Christoph Hellwig
2024-04-11 4:31 ` Darrick J. Wong
2024-04-10 1:09 ` [PATCH 3/3] xfs: only iget the file once when doing vectored scrub-by-handle Darrick J. Wong
2024-04-10 15:12 ` Christoph Hellwig
2024-04-11 1:15 ` Darrick J. Wong
2024-04-11 3:49 ` Christoph Hellwig
2024-04-11 4:41 ` Darrick J. Wong
2024-04-11 4:52 ` Christoph Hellwig
2024-04-11 4:56 ` Darrick J. Wong
2024-04-11 5:02 ` Christoph Hellwig
2024-04-11 5:21 ` Darrick J. Wong
2024-04-11 14:02 ` Christoph Hellwig
2024-04-12 0:21 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZhYdQ90rqsMOGaa1@infradead.org \
--to=hch@infradead.org \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).