From: Anjali K <anjalik@linux.ibm.com>
To: kernel test robot <lkp@intel.com>
Cc: atrajeev@linux.vnet.ibm.com, oe-kbuild-all@lists.linux.dev,
maddy@linux.ibm.com, kjain@linux.ibm.com,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/perf: set cpumode flags using sample address in the PPMU_ARCH_31 case
Date: Mon, 13 May 2024 18:52:40 +0530 [thread overview]
Message-ID: <0eb29012-124e-426b-905b-07ebe5ce79de@linux.ibm.com> (raw)
In-Reply-To: <202405121056.KfeNJMXV-lkp@intel.com>
[-- Attachment #1: Type: text/plain, Size: 6950 bytes --]
On 12/05/24 07:52, kernel test robot wrote:
> Hi Anjali,
>
> kernel test robot noticed the following build warnings:
>
> [auto build test WARNING on dd5a440a31fae6e459c0d6271dddd62825505361]
>
> url:https://github.com/intel-lab-lkp/linux/commits/Anjali-K/powerpc-perf-set-cpumode-flags-using-sample-address-in-the-PPMU_ARCH_31-case/20240511-202416
> base: dd5a440a31fae6e459c0d6271dddd62825505361
> patch link:https://lore.kernel.org/r/20240511075344.1393631-1-anjalik%40linux.ibm.com
> patch subject: [PATCH] powerpc/perf: set cpumode flags using sample address in the PPMU_ARCH_31 case
> config: powerpc-allmodconfig (https://download.01.org/0day-ci/archive/20240512/202405121056.KfeNJMXV-lkp@intel.com/config)
> compiler: powerpc64-linux-gcc (GCC) 13.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240512/202405121056.KfeNJMXV-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot<lkp@intel.com>
> | Closes:https://lore.kernel.org/oe-kbuild-all/202405121056.KfeNJMXV-lkp@intel.com/
>
> All warnings (new ones prefixed by >>):
>
> arch/powerpc/perf/core-book3s.c: In function 'perf_get_misc_flags':
>>> arch/powerpc/perf/core-book3s.c:270:13: warning: unused variable 'marked' [-Wunused-variable]
> 270 | int marked = mmcra & MMCRA_SAMPLE_ENABLE;
> | ^~~~~~
Thank you for reporting the build warning.
I will fix the same and send the patch as v2.
> vim +/marked +270 arch/powerpc/perf/core-book3s.c
>
> 1ce447b90f3e71 arch/powerpc/perf/core-book3s.c Benjamin Herrenschmidt 2012-03-26 265
> 98fb1807b97e3e arch/powerpc/kernel/perf_counter.c Paul Mackerras 2009-06-17 266 static inline u32 perf_get_misc_flags(struct pt_regs *regs)
> 98fb1807b97e3e arch/powerpc/kernel/perf_counter.c Paul Mackerras 2009-06-17 267 {
> 33904054b40832 arch/powerpc/perf/core-book3s.c Michael Ellerman 2013-04-25 268 bool use_siar = regs_use_siar(regs);
> d9f7088dd6d885 arch/powerpc/perf/core-book3s.c Athira Rajeev 2020-10-21 269 unsigned long mmcra = regs->dsisr;
> d9f7088dd6d885 arch/powerpc/perf/core-book3s.c Athira Rajeev 2020-10-21 @270 int marked = mmcra & MMCRA_SAMPLE_ENABLE;
> c1c4353f6493af arch/powerpc/perf/core-book3s.c Anjali K 2024-05-11 271 unsigned long siar = mfspr(SPRN_SIAR);
> c1c4353f6493af arch/powerpc/perf/core-book3s.c Anjali K 2024-05-11 272 unsigned long addr;
> 98fb1807b97e3e arch/powerpc/kernel/perf_counter.c Paul Mackerras 2009-06-17 273
> 75382aa72f0682 arch/powerpc/perf/core-book3s.c Anton Blanchard 2012-06-26 274 if (!use_siar)
> 1ce447b90f3e71 arch/powerpc/perf/core-book3s.c Benjamin Herrenschmidt 2012-03-26 275 return perf_flags_from_msr(regs);
> 1ce447b90f3e71 arch/powerpc/perf/core-book3s.c Benjamin Herrenschmidt 2012-03-26 276
> 1ce447b90f3e71 arch/powerpc/perf/core-book3s.c Benjamin Herrenschmidt 2012-03-26 277 /*
> 1ce447b90f3e71 arch/powerpc/perf/core-book3s.c Benjamin Herrenschmidt 2012-03-26 278 * If we don't have flags in MMCRA, rather than using
> 1ce447b90f3e71 arch/powerpc/perf/core-book3s.c Benjamin Herrenschmidt 2012-03-26 279 * the MSR, we intuit the flags from the address in
> 1ce447b90f3e71 arch/powerpc/perf/core-book3s.c Benjamin Herrenschmidt 2012-03-26 280 * SIAR which should give slightly more reliable
> 1ce447b90f3e71 arch/powerpc/perf/core-book3s.c Benjamin Herrenschmidt 2012-03-26 281 * results
> 1ce447b90f3e71 arch/powerpc/perf/core-book3s.c Benjamin Herrenschmidt 2012-03-26 282 */
> cbda6aa10bd2d9 arch/powerpc/perf/core-book3s.c Michael Ellerman 2013-05-15 283 if (ppmu->flags & PPMU_NO_SIPR) {
> a2391b35f1d9d5 arch/powerpc/perf/core-book3s.c Madhavan Srinivasan 2016-12-24 284 if (is_kernel_addr(siar))
> 1ce447b90f3e71 arch/powerpc/perf/core-book3s.c Benjamin Herrenschmidt 2012-03-26 285 return PERF_RECORD_MISC_KERNEL;
> 1ce447b90f3e71 arch/powerpc/perf/core-book3s.c Benjamin Herrenschmidt 2012-03-26 286 return PERF_RECORD_MISC_USER;
> 1ce447b90f3e71 arch/powerpc/perf/core-book3s.c Benjamin Herrenschmidt 2012-03-26 287 }
> 98fb1807b97e3e arch/powerpc/kernel/perf_counter.c Paul Mackerras 2009-06-17 288
> 7abb840b496f83 arch/powerpc/kernel/perf_event.c Michael Neuling 2009-10-14 289 /* PR has priority over HV, so order below is important */
> c1c4353f6493af arch/powerpc/perf/core-book3s.c Anjali K 2024-05-11 290 if (regs_sipr(regs)) {
> c1c4353f6493af arch/powerpc/perf/core-book3s.c Anjali K 2024-05-11 291 if (!(ppmu->flags & PPMU_ARCH_31))
> 7abb840b496f83 arch/powerpc/kernel/perf_event.c Michael Neuling 2009-10-14 292 return PERF_RECORD_MISC_USER;
> c1c4353f6493af arch/powerpc/perf/core-book3s.c Anjali K 2024-05-11 293 } else if (regs_sihv(regs) && (freeze_events_kernel != MMCR0_FCHV))
> cdd6c482c9ff9c arch/powerpc/kernel/perf_event.c Ingo Molnar 2009-09-21 294 return PERF_RECORD_MISC_HYPERVISOR;
> 5682c460264149 arch/powerpc/perf/core-book3s.c Michael Ellerman 2013-04-25 295
> c1c4353f6493af arch/powerpc/perf/core-book3s.c Anjali K 2024-05-11 296 /*
> c1c4353f6493af arch/powerpc/perf/core-book3s.c Anjali K 2024-05-11 297 * Check the address in SIAR to identify the
> c1c4353f6493af arch/powerpc/perf/core-book3s.c Anjali K 2024-05-11 298 * privilege levels since the SIER[MSR_HV, MSR_PR]
> c1c4353f6493af arch/powerpc/perf/core-book3s.c Anjali K 2024-05-11 299 * bits are not set correctly in power10 sometimes
> c1c4353f6493af arch/powerpc/perf/core-book3s.c Anjali K 2024-05-11 300 */
> c1c4353f6493af arch/powerpc/perf/core-book3s.c Anjali K 2024-05-11 301 if (ppmu->flags & PPMU_ARCH_31) {
> c1c4353f6493af arch/powerpc/perf/core-book3s.c Anjali K 2024-05-11 302 addr = siar ? siar : regs->nip;
> c1c4353f6493af arch/powerpc/perf/core-book3s.c Anjali K 2024-05-11 303 if (!is_kernel_addr(addr))
> c1c4353f6493af arch/powerpc/perf/core-book3s.c Anjali K 2024-05-11 304 return PERF_RECORD_MISC_USER;
> c1c4353f6493af arch/powerpc/perf/core-book3s.c Anjali K 2024-05-11 305 }
> c1c4353f6493af arch/powerpc/perf/core-book3s.c Anjali K 2024-05-11 306
> 7abb840b496f83 arch/powerpc/kernel/perf_event.c Michael Neuling 2009-10-14 307 return PERF_RECORD_MISC_KERNEL;
> 98fb1807b97e3e arch/powerpc/kernel/perf_counter.c Paul Mackerras 2009-06-17 308 }
> 98fb1807b97e3e arch/powerpc/kernel/perf_counter.c Paul Mackerras 2009-06-17 309
>
[-- Attachment #2: Type: text/html, Size: 8430 bytes --]
prev parent reply other threads:[~2024-05-13 18:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-11 7:53 [PATCH] powerpc/perf: set cpumode flags using sample address in the PPMU_ARCH_31 case Anjali K
2024-05-12 2:22 ` kernel test robot
2024-05-13 13:22 ` Anjali K [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0eb29012-124e-426b-905b-07ebe5ce79de@linux.ibm.com \
--to=anjalik@linux.ibm.com \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=kjain@linux.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lkp@intel.com \
--cc=maddy@linux.ibm.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).