* [PATCH] powerpc: Fix incorrect PPC32 PAMU dependency
@ 2016-02-05 2:16 Andy Fleming
2016-02-08 11:13 ` Michael Ellerman
0 siblings, 1 reply; 2+ messages in thread
From: Andy Fleming @ 2016-02-05 2:16 UTC (permalink / raw
To: joro; +Cc: iommu, benh, linuxppc-dev
The Freescale PAMU can also be enabled on 64-bit power
chips. Commit 477ab7a19cec8409e4e2dd10e7348e4cac3c06e5
(iommu: Make more drivers depend on COMPILE_TEST)
added this false dependency. Fixed it by allowing PPC64, too.
Signed-off-by: Andy Fleming <afleming@gmail.com>
---
drivers/iommu/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig
index a1e75cb..63ec7ae 100644
--- a/drivers/iommu/Kconfig
+++ b/drivers/iommu/Kconfig
@@ -57,7 +57,7 @@ config IOMMU_DMA
config FSL_PAMU
bool "Freescale IOMMU support"
- depends on PPC32
+ depends on PPC32 || PPC64
depends on PPC_E500MC || COMPILE_TEST
select IOMMU_API
select GENERIC_ALLOCATOR
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] powerpc: Fix incorrect PPC32 PAMU dependency
2016-02-05 2:16 [PATCH] powerpc: Fix incorrect PPC32 PAMU dependency Andy Fleming
@ 2016-02-08 11:13 ` Michael Ellerman
0 siblings, 0 replies; 2+ messages in thread
From: Michael Ellerman @ 2016-02-08 11:13 UTC (permalink / raw
To: Andy Fleming, joro; +Cc: iommu, linuxppc-dev
On Thu, 2016-02-04 at 20:16 -0600, Andy Fleming wrote:
> The Freescale PAMU can also be enabled on 64-bit power
> chips. Commit 477ab7a19cec8409e4e2dd10e7348e4cac3c06e5
> (iommu: Make more drivers depend on COMPILE_TEST)
> added this false dependency. Fixed it by allowing PPC64, too.
>
> Signed-off-by: Andy Fleming <afleming@gmail.com>
> ---
> drivers/iommu/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig
> index a1e75cb..63ec7ae 100644
> --- a/drivers/iommu/Kconfig
> +++ b/drivers/iommu/Kconfig
> @@ -57,7 +57,7 @@ config IOMMU_DMA
>
> config FSL_PAMU
> bool "Freescale IOMMU support"
> - depends on PPC32
> + depends on PPC32 || PPC64
That's == PPC.
> depends on PPC_E500MC || COMPILE_TEST
But then you have that ^
Multiple depends are joined with &&, so you get:
depends on PPC && (PPC_E500MC || COMPILE_TEST)
PPC_E500MC depends (indirectly) on PPC, so I think it would be clearer as:
depends on PPC_E500MC || (COMPILE_TEST && PPC)
Which I /think/ matches the original intention?
cheers
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-02-08 11:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-05 2:16 [PATCH] powerpc: Fix incorrect PPC32 PAMU dependency Andy Fleming
2016-02-08 11:13 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).