From: Conor Dooley <conor@kernel.org>
To: Shengjiu Wang <shengjiu.wang@gmail.com>
Cc: devicetree@vger.kernel.org, conor+dt@kernel.org,
alsa-devel@alsa-project.org, Xiubo.Lee@gmail.com,
linuxppc-dev@lists.ozlabs.org,
Shengjiu Wang <shengjiu.wang@nxp.com>,
tiwai@suse.com, lgirdwood@gmail.com, robh+dt@kernel.org,
linux-kernel@vger.kernel.org, nicoleotsuka@gmail.com,
broonie@kernel.org, linux-sound@vger.kernel.org,
krzysztof.kozlowski+dt@linaro.org, perex@perex.cz,
festevam@gmail.com
Subject: Re: [PATCH 2/4] ASoC: dt-bindings: fsl,xcvr: Add two PLL clock sources
Date: Sat, 11 May 2024 13:47:57 +0100 [thread overview]
Message-ID: <20240511-catwalk-ipod-98f3e636360e@spud> (raw)
In-Reply-To: <CAA+D8AOQtwHTLsQcqh_LCvVP5CWXqiHc3-at8jv3B-kA8ORR_w@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1344 bytes --]
On Fri, May 10, 2024 at 10:38:30AM +0800, Shengjiu Wang wrote:
> On Fri, May 10, 2024 at 10:27 AM Shengjiu Wang <shengjiu.wang@gmail.com> wrote:
> >
> > On Fri, May 10, 2024 at 1:14 AM Conor Dooley <conor@kernel.org> wrote:
> > >
> > > On Thu, May 09, 2024 at 10:57:38AM +0800, Shengjiu Wang wrote:
> > > > Add two PLL clock sources, they are the parent clocks of the root clock
> > > > one is for 8kHz series rates, named as 'pll8k', another one is for
> > > > 11kHz series rates, named as 'pll11k'. They are optional clocks,
> > > > if there are such clocks, then the driver can switch between them to
> > > > support more accurate sample rates.
> > > >
> > > > As 'pll8k' and 'pll11k' are optional, then add 'minItems: 4' for
> > > > clocks and clock-names properties.
> > >
> > > Despite the detail given here in the commit message, the series this is
> > > appearing in and one of the driver patches makes me a bit "suspicious"
> > > of this patch. Are these newly added clocks available on all devices, or
> > > just on the imx95, or?
> >
> > These newly added clocks are only available for the imx95 XCVR.
> >
>
> Looks like I should merge patch1 & 2 together, patch 3 & 3 together. right?
Please, and also add constraints so that the newly added clocks are only
allowed on the imx95.
Thanks,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-05-11 12:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-09 2:57 [PATCH 0/4] ASoC: fsl_xcvr: Support i.MX95 platform Shengjiu Wang
2024-05-09 2:57 ` [PATCH 1/4] ASoC: dt-bindings: fsl,xcvr: Add compatible string for i.MX95 Shengjiu Wang
2024-05-09 17:11 ` Conor Dooley
2024-05-10 2:30 ` Shengjiu Wang
2024-05-09 2:57 ` [PATCH 2/4] ASoC: dt-bindings: fsl,xcvr: Add two PLL clock sources Shengjiu Wang
2024-05-09 17:14 ` Conor Dooley
2024-05-10 2:27 ` Shengjiu Wang
2024-05-10 2:38 ` Shengjiu Wang
2024-05-11 12:47 ` Conor Dooley [this message]
2024-05-09 2:57 ` [PATCH 3/4] ASoC: fsl_xcvr: Support reparent pll clocks for phy_clk Shengjiu Wang
2024-05-09 23:09 ` kernel test robot
2024-05-09 2:57 ` [PATCH 4/4] ASoC: fsl_xcvr: Add support for i.MX95 platform Shengjiu Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240511-catwalk-ipod-98f3e636360e@spud \
--to=conor@kernel.org \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nicoleotsuka@gmail.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=shengjiu.wang@gmail.com \
--cc=shengjiu.wang@nxp.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).