From: Shuai Xue <xueshuai@linux.alibaba.com>
To: bhelgaas@google.com, mahesh@linux.ibm.com, mani@kernel.org,
Jonathan.Cameron@huawei.com,
sathyanarayanan.kuppuswamy@linux.intel.com
Cc: oohall@gmail.com, xueshuai@linux.alibaba.com,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org
Subject: [PATCH v5 0/3] PCI/AER: Report fatal errors of RCiEP and EP if link recoverd
Date: Wed, 17 Sep 2025 14:33:49 +0800 [thread overview]
Message-ID: <20250917063352.19429-1-xueshuai@linux.alibaba.com> (raw)
changes since v4:
- rebase to 6.17-rc6
- pick up Reviewed-by tag for PATCH[2] from Sathyanarayanan
- minor typos in commit log per Manivannan
changes since v3:
- squash patch 1 and 2 into one patch per Sathyanarayanan
- add comments note for dpc_process_error per Sathyanarayanan
- pick up Reviewed-by tag for PATCH[1] from Sathyanarayanan
changes since v2:
- moving the "err_port" rename to a separate patch per Sathyanarayanan
- rewrite comments of dpc_process_error per Sathyanarayanan
- remove NULL initialization for err_dev per Sathyanarayanan
changes since v1:
- rewrite commit log per Bjorn
- refactor aer_get_device_error_info to reduce duplication per Keith
- fix to avoid reporting fatal errors twice for root and downstream ports per Keith
The AER driver has historically avoided reading the configuration space of an
endpoint or RCiEP that reported a fatal error, considering the link to that
device unreliable. Consequently, when a fatal error occurs, the AER and DPC
drivers do not report specific error types, resulting in logs like:
pcieport 0015:00:00.0: EDR: EDR event received
pcieport 0015:00:00.0: EDR: Reported EDR dev: 0015:00:00.0
pcieport 0015:00:00.0: DPC: containment event, status:0x200d, ERR_FATAL received from 0015:01:00.0
pcieport 0015:00:00.0: AER: broadcast error_detected message
pcieport 0015:00:00.0: AER: broadcast mmio_enabled message
pcieport 0015:00:00.0: AER: broadcast resume message
pcieport 0015:00:00.0: pciehp: Slot(21): Link Down/Up ignored
pcieport 0015:00:00.0: AER: device recovery successful
pcieport 0015:00:00.0: EDR: DPC port successfully recovered
pcieport 0015:00:00.0: EDR: Status for 0015:00:00.0: 0x80
AER status registers are sticky and Write-1-to-clear. If the link recovered
after hot reset, we can still safely access AER status and TLP header of the
error device. In such case, report fatal errors which helps to figure out the
error root case.
After this patch, the logs like:
pcieport 0015:00:00.0: EDR: EDR event received
pcieport 0015:00:00.0: EDR: Reported EDR dev: 0015:00:00.0
pcieport 0015:00:00.0: DPC: containment event, status:0x200d, ERR_FATAL received from 0015:01:00.0
pcieport 0015:00:00.0: AER: broadcast error_detected message
vfio-pci 0015:01:00.0: PCIe Bus Error: severity=Uncorrectable (Fatal), type=Transaction Layer, (Receiver ID)
pcieport 0015:00:00.0: pciehp: Slot(21): Link Down/Up ignored
vfio-pci 0015:01:00.0: device [144d:a80a] error status/mask=00001000/00400000
vfio-pci 0015:01:00.0: [12] TLP (First)
vfio-pci 0015:01:00.0: AER: TLP Header: 0x4a004010 0x00000040 0x01000000 0xffffffff
pcieport 0015:00:00.0: AER: broadcast mmio_enabled message
pcieport 0015:00:00.0: AER: broadcast resume message
pcieport 0015:00:00.0: AER: device recovery successful
pcieport 0015:00:00.0: EDR: DPC port successfully recovered
pcieport 0015:00:00.0: EDR: Status for 0015:00:00.0: 0x80
Shuai Xue (3):
PCI/DPC: Clarify naming for error port in DPC Handling
PCI/DPC: Run recovery on device that detected the error
PCI/AER: Report fatal errors of RCiEP and EP if link recoverd
drivers/pci/pci.h | 5 +++--
drivers/pci/pcie/aer.c | 11 +++++++----
drivers/pci/pcie/dpc.c | 31 ++++++++++++++++++++++++-------
drivers/pci/pcie/edr.c | 35 ++++++++++++++++++-----------------
drivers/pci/pcie/err.c | 11 +++++++++++
5 files changed, 63 insertions(+), 30 deletions(-)
--
2.39.3
next reply other threads:[~2025-09-17 6:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-17 6:33 Shuai Xue [this message]
2025-09-17 6:33 ` [PATCH v5 1/3] PCI/DPC: Clarify naming for error port in DPC Handling Shuai Xue
2025-09-17 6:33 ` [PATCH v5 2/3] PCI/DPC: Run recovery on device that detected the error Shuai Xue
2025-09-17 22:01 ` kernel test robot
2025-09-17 6:33 ` [PATCH v5 3/3] PCI/AER: Report fatal errors of RCiEP and EP if link recoverd Shuai Xue
2025-09-17 19:09 ` Kuppuswamy Sathyanarayanan
2025-09-18 2:45 ` Shuai Xue
2025-09-18 20:33 ` Bjorn Helgaas
2025-09-19 1:41 ` Shuai Xue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250917063352.19429-1-xueshuai@linux.alibaba.com \
--to=xueshuai@linux.alibaba.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mahesh@linux.ibm.com \
--cc=mani@kernel.org \
--cc=oohall@gmail.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).